From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 025D7A0C48;
	Thu,  8 Jul 2021 22:16:32 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id D822B41643;
	Thu,  8 Jul 2021 22:16:31 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.133.124])
 by mails.dpdk.org (Postfix) with ESMTP id B8EEC4014E
 for <dev@dpdk.org>; Thu,  8 Jul 2021 22:16:30 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1625775390;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=YdpNRzx8rMFsbxJ+kq7ljUIqMb7H2XaeTpWwdTGpTCw=;
 b=fec2NaADs8/0mbPGZXcdvv/fNK6R+WQA9yCW/zOar58uZjkECjPM9KJh7B3+DaLpXfYpKG
 DRiYFtc4oXjEvY3m/RJciQ+diDpJszIp9Qqy55FiDmXNnkpUrAiBRtSeMB+cEU9yRsmYnQ
 4V9w/+ZWAkCLJ16/1DipLUUtt8gygY4=
Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com
 [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-108-jtzRyJATOzOzNMvsr1aAmA-1; Thu, 08 Jul 2021 16:16:29 -0400
X-MC-Unique: jtzRyJATOzOzNMvsr1aAmA-1
Received: by mail-ua1-f70.google.com with SMTP id
 h16-20020ab038500000b029029ec7ce7c99so953092uaw.14
 for <dev@dpdk.org>; Thu, 08 Jul 2021 13:16:29 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=YdpNRzx8rMFsbxJ+kq7ljUIqMb7H2XaeTpWwdTGpTCw=;
 b=OxP2hWfRG4D5Zx1SQxvUMpkwxA5z9DwlSA7ZZrQ6aJPUJi4SfZLy7CTyVmks5jjt4r
 +GvJwPVbESLY+KxouoSD0ph4Qf45mgLIHMkay7txb4Z0fxDagStMci/CUetA91odFv85
 ZNSkAbtr4QR/gIz8E93vCtGj8nzWhFlN4TcmHlKk26y1tA4LFvYJ/Xs50FOJ9N6Fk9FT
 VZNGngkwRx2D4g1LCPoRq8hXqDwb8Dyhy3XOi5lKMg0UxU9cRl4I5wmVR4axEweFDEqw
 FuqldNdS6ygtB2qIuq7X61LgM+BAr3jjI5qpq/CB+54NVQjnoalNfnEo0002+y0c0lzB
 6GeQ==
X-Gm-Message-State: AOAM530iXhnNekVRnAGQ57HEx5Etd7l28YHQWmc/4Ob5VJVcfUfITF3J
 ++Cg8ENpM4xVt9PsIxZMDddkPwYdrSVBT8hoR4hl1wMTWkhnZr0nG5rZ3koYGjgZQgoonXP8mUt
 8S1OndRRbpp8fFWAXtRs=
X-Received: by 2002:ab0:63d1:: with SMTP id i17mr11087240uap.86.1625775388779; 
 Thu, 08 Jul 2021 13:16:28 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJy41J1bmeala2oLp9zzlprfKSAQAHhKEG1kV1XTLPAeq4ZRHXNevDGILNe6GoorrMGnpnqymYyqYAd3SouXTNM=
X-Received: by 2002:ab0:63d1:: with SMTP id i17mr11087226uap.86.1625775388588; 
 Thu, 08 Jul 2021 13:16:28 -0700 (PDT)
MIME-Version: 1.0
References: <20210707193058.1035564-1-gakhil@marvell.com>
 <DM4PR12MB51678615814B51DAE8D0944CDA199@DM4PR12MB5167.namprd12.prod.outlook.com>
In-Reply-To: <DM4PR12MB51678615814B51DAE8D0944CDA199@DM4PR12MB5167.namprd12.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Thu, 8 Jul 2021 22:16:17 +0200
Message-ID: <CAJFAV8xaUrJHGVm87yuPJX8WWVmqo1_UXRmGNNebespt7Nv7kw@mail.gmail.com>
To: Ali Alnubani <alialnu@oss.nvidia.com>,
 Tejasree Kondoj <ktejasree@marvell.com>
Cc: Akhil Goyal <gakhil@marvell.com>,
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, 
 "dev@dpdk.org" <dev@dpdk.org>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [pull-request] next-crypto 21.08 rc1
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jul 8, 2021 at 7:14 PM Ali Alnubani <alialnu@oss.nvidia.com> wrote:
> """
> $ meson --werror -Dc_args='-DRTE_ENABLE_ASSERT' --buildtype=debug build && ninja -C build
> ...
> ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c: In function 'cn10k_cpt_sec_post_process':
> ../../root/dpdk/drivers/crypto/cnxk/cn10k_cryptodev_ops.c:260:37: error: 'IPV6_VERSION' undeclared (first use in this function); did you mean 'IPVERSION'?
>   260 |         RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
> """

The simplest fix:

@@ -275,7 +275,7 @@ cn10k_cpt_sec_post_process(struct rte_crypto_op *cop,
                        m_len = rte_be_to_cpu_16(ip->total_length);
                } else {
                        PLT_ASSERT(((ip->version_ihl & 0xf0) >>
-                                   RTE_IPV4_IHL_MULTIPLIER) == IPV6_VERSION);
+                                   RTE_IPV4_IHL_MULTIPLIER) == 6);
                        ip6 = (struct rte_ipv6_hdr *)ip;
                        m_len = rte_be_to_cpu_16(ip6->payload_len) +
                                sizeof(struct rte_ipv6_hdr);


-- 
David Marchand