From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2C523A0547;
	Tue, 19 Oct 2021 22:03:22 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A66B840142;
	Tue, 19 Oct 2021 22:03:21 +0200 (CEST)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mails.dpdk.org (Postfix) with ESMTP id CC4D64003E
 for <dev@dpdk.org>; Tue, 19 Oct 2021 22:03:20 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1634673800;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=2pCD2W2GohsXPWkT8E7cBKl7YKre3da7J+V5GVCNWDw=;
 b=JoVJtnHaOmmkwm7p9LeZ3A8zjc50RtlSV7C6beEu0GKNoCl6Zvkjx5qktqOeMmZ93UWYlo
 S/qf8yX5SkGlsF2mMqXAbUk4iTJCuEs34rdS3dEYUeeHJBbFsXuq0ZBVnYA7ngE6p1xEGr
 npvy0UO4duU0OtSFrOe6z0fUucXNChY=
Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com
 [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-41-z_wawxn5MN2KvM2qdv1KQA-1; Tue, 19 Oct 2021 16:03:16 -0400
X-MC-Unique: z_wawxn5MN2KvM2qdv1KQA-1
Received: by mail-lj1-f198.google.com with SMTP id
 k12-20020a2ea26c000000b00210f22d4769so1238080ljm.4
 for <dev@dpdk.org>; Tue, 19 Oct 2021 13:03:16 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=2pCD2W2GohsXPWkT8E7cBKl7YKre3da7J+V5GVCNWDw=;
 b=dD3VrfnlUqNAy/PG2N8nI+8JdW9vWm6wI1EaN6Go0bmOUXP+bCugdTQvRtipR7jMgz
 luPvv23LssFEvKtGuJwO8tcZTNUbyCSc07i80exJj3izboVTWR+6qcGjSpY218H9zcZf
 DSVluD4qGXZxi7q4kqK0n7py1CjAK6v2wYWkg9OTR/RTIltXcmIhJEbadDm1URxIhVdO
 t6GoSmo9dEb7SVpYK6TIxEAtRHNylwqAzNuJp8M49qnIIHQMkcAhWIuqBtqCh1Z3xezP
 TDMZQQTzRzMuJmuzA/ct2nnEy33du5kz8UmAtc83dHwhflNsRAjpaXf2NOFVyadCwe7C
 83/A==
X-Gm-Message-State: AOAM530DSCVENwwxnlQ1pIM2QBUPnZm89/DZ8Nn+/mEe9NAHLbqNCypz
 48Takg5pZuQ/zVGW+KJ5ySGVqnXChzMVFRUr48nmTPVgQ99p818tVMAVSTAuRubrxOpW9Bo2bvO
 DPpyX0xVmzpI+CQVGoEc=
X-Received: by 2002:a2e:8e34:: with SMTP id r20mr9083350ljk.333.1634673795410; 
 Tue, 19 Oct 2021 13:03:15 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJzjgj9gA1yYyFCl9noqngfQp96amUoYFGtXC3tos0A1rXp2sk5vaMdSonngwuDTg6eYD33C4lzx2KnCO9bkNrM=
X-Received: by 2002:a2e:8e34:: with SMTP id r20mr9083322ljk.333.1634673795225; 
 Tue, 19 Oct 2021 13:03:15 -0700 (PDT)
MIME-Version: 1.0
References: <20211018144907.1145028-1-andrew.rybchenko@oktetlabs.ru>
 <20211019174022.2036272-1-andrew.rybchenko@oktetlabs.ru>
 <20211019174022.2036272-3-andrew.rybchenko@oktetlabs.ru>
In-Reply-To: <20211019174022.2036272-3-andrew.rybchenko@oktetlabs.ru>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 19 Oct 2021 22:03:03 +0200
Message-ID: <CAJFAV8xaZ0zkRvdS-nRwzoK2+ZrBkpRx=Kge7hCJ=aXT-jp-mQ@mail.gmail.com>
To: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: Olivier Matz <olivier.matz@6wind.com>,
 Maryam Tahhan <maryam.tahhan@intel.com>, 
 Reshma Pattan <reshma.pattan@intel.com>, Xiaoyun Li <xiaoyun.li@intel.com>, 
 Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, 
 Pavan Nikhilesh <pbhagavatula@marvell.com>,
 Shijith Thotton <sthotton@marvell.com>, Jerin Jacob <jerinj@marvell.com>,
 "Artem V. Andreev" <artem.andreev@oktetlabs.ru>, 
 Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>, 
 Maciej Czekaj <mczekaj@marvell.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>, 
 Chenbo Xia <chenbo.xia@intel.com>, dev <dev@dpdk.org>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 2/6] mempool: add namespace prefix to flags
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Oct 19, 2021 at 7:40 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
> @@ -752,7 +752,7 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void)
>         ret = rte_mempool_populate_default(mp);
>         RTE_TEST_ASSERT(ret > 0, "Failed to populate mempool: %s",
>                         rte_strerror(-ret));
> -       RTE_TEST_ASSERT(mp->flags & MEMPOOL_F_NON_IO,
> +       RTE_TEST_ASSERT(mp->flags & RTE_MEMPOOL_F_NON_IO,
>                         "NON_IO flag is not set when NO_IOVA_CONTIG is set");
>         ret = TEST_SUCCESS;
>  exit:

There is one more flag, hunk fixed adding missing:

@@ -745,14 +745,14 @@ test_mempool_flag_non_io_set_when_no_iova_contig_set(void)

     mp = rte_mempool_create_empty("empty", MEMPOOL_SIZE,
                       MEMPOOL_ELT_SIZE, 0, 0,
-                      SOCKET_ID_ANY, MEMPOOL_F_NO_IOVA_CONTIG);
+                      SOCKET_ID_ANY, RTE_MEMPOOL_F_NO_IOVA_CONTIG);
     RTE_TEST_ASSERT_NOT_NULL(mp, "Cannot create mempool: %s",
                  rte_strerror(rte_errno));
     rte_mempool_set_ops_byname(mp, rte_mbuf_best_mempool_ops(), NULL);
     ret = rte_mempool_populate_default(mp);
     RTE_TEST_ASSERT(ret > 0, "Failed to populate mempool: %s",
             rte_strerror(-ret));
-    RTE_TEST_ASSERT(mp->flags & MEMPOOL_F_NON_IO,
+    RTE_TEST_ASSERT(mp->flags & RTE_MEMPOOL_F_NON_IO,
             "NON_IO flag is not set when NO_IOVA_CONTIG is set");
     ret = TEST_SUCCESS;
 exit:


-- 
David Marchand