From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DA834235C; Wed, 11 Oct 2023 09:21:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AB0B402A2; Wed, 11 Oct 2023 09:21:57 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BE6EB4028A for ; Wed, 11 Oct 2023 09:21:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697008915; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EPA3McVPgFKTgq91qpDdJA6VFPDIHPuBlLRYq4U3irY=; b=as8XLfRjJu6hB3grQ6l2nSTrhON2A4y/bwvS637A7rCMQ9nemsrZ2nT0HsOCxhNN/j1UYg YzzjqKRf6KH7vfO6cvL9IPFdvD9K8UpcMnn07f2VvjBSTkCTeRLQgnelODQhGImkxipv6B gqP0yiUPm6iW+fLQBkGONMjHnjMjYF0= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-168-FYVDX3UkNFGKG7temQmyQA-1; Wed, 11 Oct 2023 03:21:54 -0400 X-MC-Unique: FYVDX3UkNFGKG7temQmyQA-1 Received: by mail-lf1-f69.google.com with SMTP id 2adb3069b0e04-50433324cf3so5910278e87.3 for ; Wed, 11 Oct 2023 00:21:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697008912; x=1697613712; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EPA3McVPgFKTgq91qpDdJA6VFPDIHPuBlLRYq4U3irY=; b=cNfjQPXBDEacUo+ym+d8iZf2jjNCdy/FgOaGPwab5au0sfVAfvVsVNKk/38mjZBLJt fOj8jY1BG/Na+x3+F2IIJlD6nBFT6SicpM+lknJMamp9sh9wP8QV+lO/nvb/HVJaBXDr DVtvm4xhdijd6IoPLMlJ67bK+PesqjdRWzIdbS5QybAUv3VL5T4qZlNCNiPyhh/m1bom VQujAOhTh2LDdVqhHGSlyoJfOwXuDly6oKudB/hbKcKG3EOgw8Pwssj0YT9JaWMF6OOw //D9spzsddizMXsckfH8CACmux5JaE9XhURwcwNsPrucVVVCNqR+GGr7tlnp7zcxM0lq v44w== X-Gm-Message-State: AOJu0YzOkFyof6KiVe1FC7d//dPrdWoVDfME2w/UXvmFRPS3A5i8EmuS W+2de2moKTBQKrR1Om04qEVDQhM8vzeF3aGti0ztad/yGXxP7m+sLdNvga5/BkVZ68Hs40y1h9M 7wm413bmNA2qCsRYy76E= X-Received: by 2002:ac2:4989:0:b0:502:c615:99a9 with SMTP id f9-20020ac24989000000b00502c61599a9mr16682591lfl.30.1697008912602; Wed, 11 Oct 2023 00:21:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFyW6cy0ZdorelNf6+wNKN2KgkFGsvMgaKfgl88uuIIdJAtk3B99P3Lbk1BvZjs5sYOq2RJZjwLtRn+KZPsjdw= X-Received: by 2002:ac2:4989:0:b0:502:c615:99a9 with SMTP id f9-20020ac24989000000b00502c61599a9mr16682579lfl.30.1697008912203; Wed, 11 Oct 2023 00:21:52 -0700 (PDT) MIME-Version: 1.0 References: <20231010140029.66159-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Wed, 11 Oct 2023 09:21:40 +0200 Message-ID: Subject: Re: [PATCH] eventdev: fix symbol export for port maintenance To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Jerin Jacob Cc: dev@dpdk.org, stable@dpdk.org, =?UTF-8?Q?Mattias_R=C3=B6nnblom?= X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Jerin, On Wed, Oct 11, 2023 at 9:03=E2=80=AFAM David Marchand wrote: > > On Wed, Oct 11, 2023 at 8:47=E2=80=AFAM Mattias R=C3=B6nnblom wrote: > > > > On 2023-10-10 16:00, David Marchand wrote: > > > Trying to call rte_event_maintain out of the eventdev library trigger= s > > > a link failure, as the tracepoint symbol associated to this inline > > > helper was not exported. > > > > > > Fixes: 54f17843a887 ("eventdev: add port maintenance API") > > > Cc: stable@dpdk.org > > > > > > Signed-off-by: David Marchand > > > --- > > > Caught by the CI when testing the dispatcher library. > > > See for example: > > > https://github.com/ovsrobot/dpdk/actions/runs/6460514355/job/17538348= 529#step:19:5506 > > > > > > --- > > > lib/eventdev/version.map | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > > > index b03c10d99f..249eb115b1 100644 > > > --- a/lib/eventdev/version.map > > > +++ b/lib/eventdev/version.map > > > @@ -5,6 +5,7 @@ DPDK_24 { > > > __rte_eventdev_trace_deq_burst; > > > __rte_eventdev_trace_enq_burst; > > > __rte_eventdev_trace_eth_tx_adapter_enqueue; > > > + __rte_eventdev_trace_maintain; > > > __rte_eventdev_trace_timer_arm_burst; > > > __rte_eventdev_trace_timer_arm_tmo_tick_burst; > > > __rte_eventdev_trace_timer_cancel_burst; > > > > I can't say I know why it's needed, but the change seems consistent wit= h > > other Eventdev trace points. > > The trace point framework in DPDK relies on a per trace point global > variable (whose name is __): > > #define __RTE_TRACE_POINT(_mode, _tp, _args, ...) \ > extern rte_trace_point_t __##_tp; \ > static __rte_always_inline void \ > _tp _args \ > { \ > __rte_trace_point_emit_header_##_mode(&__##_tp); \ > __VA_ARGS__ \ > } > > When tracepoints are called from within a shared library code, and > because all symbols of a group of objects are visible, the tracepoint > symbols are resolved by the linker. > But when this tracepoint is called via an inline helper from some code > out of the shared library, this symbol must be exported in the shared > library map or it won't be visible to "external" users. Could we describe / mention this in the trace point library doc? Or maybe I read too quickly and there is already something but it was not obvious to me. --=20 David Marchand