From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED98A43D6B; Thu, 28 Mar 2024 12:16:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3B0DD402E7; Thu, 28 Mar 2024 12:16:20 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 96B23402AC for ; Thu, 28 Mar 2024 12:16:19 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711624579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fqmvk2m7FVHF+23VUaxwaSdJlsh0kOqN27OqeBdVDLU=; b=ICtki6ZtfOl9GuRQE1xmTjZTAu2x8g37eFaOcEcb6TrBeOBsInwdb0BnGsfJFKUc4bP1z0 ewARn3OTv5TWYoDEx9dF959/oO9xHrHsacMZsyrfEFp4Ic8RD91Ni8SdB8K6ZKkaKrmV8L tQpvc18PGin2n+OqZNtg06+eUooxoOk= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-583-t1EkDEvoMGK6X19UOi-w6A-1; Thu, 28 Mar 2024 07:16:15 -0400 X-MC-Unique: t1EkDEvoMGK6X19UOi-w6A-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-513d125058eso791815e87.2 for ; Thu, 28 Mar 2024 04:16:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1711624574; x=1712229374; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fqmvk2m7FVHF+23VUaxwaSdJlsh0kOqN27OqeBdVDLU=; b=vMFv8ahgY28zIJSg+ADl22psQcC+pZoWCY/ykiKlGrtb/C2b/u/Gr0phYGvMQDdZue 2wasVoe9T/vsb6wk0UGJT6xNEtGcYgYulNPGdWalJaTwQ/jIf+oRhCJQRdte9LFacnth FxugAUA8+NMXRGcIHJpWJCH6YYtJw8hgmj7uCgnn2/YfLTQNllq3AnFwEjpsxZmktfRB qfMCpyCFcC0U8tXfp8xwcr5A1RsX1NiJTk8GVAevMQjz7ayMus/DlVpC/+pqZaBz0w4j EKlNC6kxRyrDI0TgEEi0TEks0ugwG5VY0qDa5n/AAsnC26quPG6yFo7PJ9t2gWaPi8qO zODQ== X-Gm-Message-State: AOJu0Yy4Z0DVv142TvNg6wuY3GAHj8n8PoD5V5x3mhfXPcWSIVqyAo2Q lyV2rzlkSsDuV7WLWz2GDIbzHTHKbu+rcYmqznJqCXbRaU3hvTKHXsyvfjvLIP9VOuyQ6rr1hBY wijiRwEo029HvziRocRcKavFL2G0q5HhwEqG+7Xg3s7m0VCpxIt1c22BJxYoDCYYGj/ItMut4VG I3g02DU0Z++y3VeCU= X-Received: by 2002:a05:6512:3133:b0:513:24ba:466a with SMTP id p19-20020a056512313300b0051324ba466amr2074343lfd.53.1711624574283; Thu, 28 Mar 2024 04:16:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG+2ifokGvOnOb4Ya04UqUTwjhJQl1q6teOXxFzpEnTZ5S1m+HLMrUEYO73+sTtgC6lsEfCVe3YPSSTLqxBT6o= X-Received: by 2002:a05:6512:3133:b0:513:24ba:466a with SMTP id p19-20020a056512313300b0051324ba466amr2074316lfd.53.1711624573906; Thu, 28 Mar 2024 04:16:13 -0700 (PDT) MIME-Version: 1.0 References: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> In-Reply-To: <20240327184413.3192526-1-vladimir.medvedkin@intel.com> From: David Marchand Date: Thu, 28 Mar 2024 12:16:02 +0100 Message-ID: Subject: Re: [PATCH] net/ice: fix vlan stripping in double VLAN mode To: Vladimir Medvedkin Cc: dev@dpdk.org, carlosmn@weg.net, mingjinx.ye@intel.com, stable@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Mar 27, 2024 at 7:44=E2=80=AFPM Vladimir Medvedkin wrote: > > The ICE hardware can operate in two modes - single vlan mode > or double vlan mode. Depending on the operating mode the hardware > handles vlan header with single vlan tag differently. > When double vlan enabled, a packet with a single VLAN is treated > as a packet with outer VLAN only. Otherwise, a single VLAN in a > packet is treated as inner VLAN. > > This patch fixes the logic of how vlan stripping is programmed. > > Bugzilla ID: 1402 Nit: no need for an empty line here, the Bugzilla ID: tag goes with the Fixes: and Cc: block. > > Fixes: de5da9d16430 ("net/ice: support double VLAN") > Cc: mingjinx.ye@intel.com > Cc: stable@dpdk.org > > Signed-off-by: Vladimir Medvedkin Thanks Vladimir. It looks to fix the issue I observed. I'll let Carlos confirm the fix is good for him too. --=20 David Marchand