From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A220425EF; Tue, 19 Sep 2023 10:29:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8490A402DA; Tue, 19 Sep 2023 10:29:23 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 9E4294026E for ; Tue, 19 Sep 2023 10:29:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695112162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HIkz3FlVJPhcUTY6jaUJWNSmZ8wvfPEtwFwVymQ8Mmo=; b=hNedP285ZCr0/hjNYnPGiwFmi24CcHr/KNhtJVYFVNmlgDYbqXlurG/jAkP068gbyKLoM3 IXAM/USHNf0pndbCCEmoxX86D59y5AHXbMXpPmPdhaFNz0M5gM5lJMlsNOUZXWNy6ucn+p J77MKL8oeyjQVVmvzkyfQuTNiJtbHR0= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-588-FNppw546O_CKVrXPLH5Qqg-1; Tue, 19 Sep 2023 04:29:20 -0400 X-MC-Unique: FNppw546O_CKVrXPLH5Qqg-1 Received: by mail-lf1-f71.google.com with SMTP id 2adb3069b0e04-5007ac1c653so6154560e87.2 for ; Tue, 19 Sep 2023 01:29:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695112159; x=1695716959; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HIkz3FlVJPhcUTY6jaUJWNSmZ8wvfPEtwFwVymQ8Mmo=; b=bONO7HPon4l56zOcVOrhfmnwRDfdt8JnQ2FrG4V1YzviUrPHRukJfh+HGD1QIY08LS VmfW0/AQkwR6zzV8dC2vTlziNMdGDrOR7zIA1gv3kEwmGoZulQ6kNnwBdiJolf1r2t6X lp4UysVcYyEMdJ7CaKtiMxCrjdZV3qwVE6M54dTuaMiY5Ov+IISbdP2X/U80lrmN7Ft4 l9nnXqJ8bINzxbD+3Pg0m6QT8GhMY9ABQoWtUJpJvtuUueIyRCAgLWU35QsTHz5rtO16 Rn6oUOWRKo8aA6OYhpYWT5HPWSFfewPtGQv3CO738gG0FwsLIuOGicEhMwmkCYE2ap4p QnHA== X-Gm-Message-State: AOJu0YwoqJbHEJ0PFWQHF5cg3E+QfmBju1NuJpHER4aQoL+RoTyQVXKI BaigjMdmC2ZeoA+ZujnyV23wXd2tm4NbhJF1o/ArNXBeygzCaVp5TwK8w+/kOSjI8wc37Y589Wi 3lpzVB8C4FLOcdqIpd7g= X-Received: by 2002:a2e:9203:0:b0:2bc:b75e:b8b with SMTP id k3-20020a2e9203000000b002bcb75e0b8bmr9240917ljg.38.1695112159088; Tue, 19 Sep 2023 01:29:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGT371dBU9AWx4JOeRam8DlqCES37DsOT8rSl02YXetA7bPIQfnFYHmeRLFguGseFEFU5NEDbw2YQWXorYhax4= X-Received: by 2002:a2e:9203:0:b0:2bc:b75e:b8b with SMTP id k3-20020a2e9203000000b002bcb75e0b8bmr9240902ljg.38.1695112158692; Tue, 19 Sep 2023 01:29:18 -0700 (PDT) MIME-Version: 1.0 References: <20230915115206.132198-1-bruce.richardson@intel.com> In-Reply-To: <20230915115206.132198-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 19 Sep 2023 10:29:07 +0200 Message-ID: Subject: Re: [PATCH 0/2] add checks for tests not in a suite To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 15, 2023 at 1:52=E2=80=AFPM Bruce Richardson wrote: > > To help ensure that we don't have "orphaned" tests not in any test > suites we can add the following checks: > > * In developer-mode builds, emit a warning for each test defined using > REGISTER_TEST_COMMAND > * In checkpatches, add a check to prevent the addition of new tests > using the REGISTER_TEST_COMMAND macro > > Bruce Richardson (2): > app/test: emit warning for tests not in a test suite > devtools: check for tests added without a test suite > > app/test/suites/meson.build | 13 ++++++++++++- > buildtools/get-test-suites.py | 12 +++++++++--- > devtools/checkpatches.sh | 8 ++++++++ > 3 files changed, 29 insertions(+), 4 deletions(-) The "non_suite_tests" testsuite returned by buildtools/get-test-suites.py is a bit strange, as it is not a testsuite from meson pov. But otherwise, the series looks good to me. --=20 David Marchand