From: David Marchand <david.marchand@redhat.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>,
Olivier Matz <olivier.matz@6wind.com>,
Gage Eads <gage.eads@intel.com>,
dev@dpdk.org, stable@dpdk.org
Subject: Re: [PATCH] stack: occasional crash due to uninitialized variable
Date: Tue, 4 Feb 2025 13:45:07 +0100 [thread overview]
Message-ID: <CAJFAV8xbW89Yn0UiDBOiPdn4oE10Aiup7nbPvVMr+pzAKCe9fg@mail.gmail.com> (raw)
In-Reply-To: <1738632218-5796-1-git-send-email-andremue@linux.microsoft.com>
On Tue, Feb 4, 2025 at 2:24 AM Andre Muezerie
<andremue@linux.microsoft.com> wrote:
>
> Variable "success" was not being initialized and there was a code
> path where the last do/while loop in __rte_stack_lf_pop_elems
> looked at the value of this variable before it was set to any.
>
> Compiling with msvc resulted in stack_lf_autotest sometimes crashing.
>
> The fix is to initialize the variable. This same fix was applied to
> stack\rte_stack_lf_generic.h in the past but was missed here.
>
> Fixes: 7e6e609939a8 ("stack: add C11 atomic implementation")
> Cc: stable@dpdk.org
>
> Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
Indeed, good catch.
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
prev parent reply other threads:[~2025-02-04 12:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 1:23 Andre Muezerie
2025-02-04 12:45 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xbW89Yn0UiDBOiPdn4oE10Aiup7nbPvVMr+pzAKCe9fg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=olivier.matz@6wind.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).