From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFE91A0A02; Tue, 27 Apr 2021 15:40:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1D7D41245; Tue, 27 Apr 2021 15:40:47 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id EF40240150 for ; Tue, 27 Apr 2021 15:40:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1619530846; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=DDSQ8VBhhLN2nlZYCEr61aZT6cO9n+ENQlGHMcaKxac=; b=KQ6Bnubt4/22Eqw2SSWpQS5ydRD9fA0rBUDYGYimzs5bBCHGJIYBkhZ2YRlIe7awfakMdr bfHfhiopCUMFXStMGYdvnuOOGb6IGUIogbWuPcIfOEAZsP9hDemnv87IHcnuwzOnTUagFo Sk8/GCVJUrLkzWCI/6YLxju/pw5CBh4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-179-542gu9hZNb2pijQrScNwXg-1; Tue, 27 Apr 2021 09:40:44 -0400 X-MC-Unique: 542gu9hZNb2pijQrScNwXg-1 Received: by mail-vs1-f71.google.com with SMTP id l11-20020a67ed0b0000b02901f3823e11e0so12433888vsp.3 for ; Tue, 27 Apr 2021 06:40:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DDSQ8VBhhLN2nlZYCEr61aZT6cO9n+ENQlGHMcaKxac=; b=hfDYg9stRs0ZRbFvc/QKTHBaDJy6F9ycJhvnfimuDByoh0UUKLmFcJn98WSzecZwPU cvzcZy8QwNU+xFFNO8zq7HZayqVOJ7lpBr2txNDuiBjetJo+fLvATAIgyZeNRjLjxrvz 3NKLHT3S68TXgXV15c/dg4wq10Ystc2E4g+CE2oBXnme5CNYF3B1S0HvZb7a2fQFu6fw pw/qJddXtRUa53vepRNlkyywrowNxdhPYX23MC5Nr2El8vEjW6Og540YamOjVxS9YUHM p2Ia764zPXPG0w/A0tmfo6oz0q0+dlqjxE5x+d3jptWbxNYpyBKbz9RNe+2fV/VXeLv3 mIgA== X-Gm-Message-State: AOAM530WF4GX2LvF5rd4Ju3JMQ0Byjv9gznUwyioOid3KTw+JOl0bG/r RJwxX6ImWxReFlxiHatKTS3g9BXklZyWdbpNOgnQqeWsMsNyunI/fs3Nor7xjOF9roWsMK3sru9 TNx4NfPGXC3uk9XF8hXg= X-Received: by 2002:a67:e317:: with SMTP id j23mr18054879vsf.17.1619530842290; Tue, 27 Apr 2021 06:40:42 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzaBG/q/KJ9QRKiUBgu730FQV4TDLqU7VnVL0747rcZC+atRpxuY7RSzSxigQeacmYF2m4WrGt07P9ZvneN6z4= X-Received: by 2002:a67:e317:: with SMTP id j23mr18054754vsf.17.1619530841288; Tue, 27 Apr 2021 06:40:41 -0700 (PDT) MIME-Version: 1.0 References: <20210421050243.130585-1-haiyue.wang@intel.com> <20210423114001.174723-1-haiyue.wang@intel.com> <20210423114001.174723-2-haiyue.wang@intel.com> In-Reply-To: From: David Marchand Date: Tue, 27 Apr 2021 15:40:30 +0200 Message-ID: To: "Wang, Haiyue" Cc: Gaetan Rivet , dev , "Zhang, Qi Z" , "Wang, Liang-min" , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/3] bus/pci: enable PCI master in command register X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 27, 2021 at 3:35 PM Wang, Haiyue wrote: > > > diff --git a/lib/pci/rte_pci.h b/lib/pci/rte_pci.h > > > index a8f8e404a..1f33d687f 100644 > > > --- a/lib/pci/rte_pci.h > > > +++ b/lib/pci/rte_pci.h > > > @@ -32,6 +32,10 @@ extern "C" { > > > > > > #define RTE_PCI_VENDOR_ID 0x00 /* 16 bits */ > > > #define RTE_PCI_DEVICE_ID 0x02 /* 16 bits */ > > > +#define RTE_PCI_COMMAND 0x04 /* 16 bits */ > > > > This file uses tab for indent. > > > > Yes, I use two tabs, then the vi editor shows that they are aligned. > but the patch doesn't show well. > > So use one tab ? Sorry, your patch was good. You can discard this comment. -- David Marchand