From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 545EFA052B; Tue, 28 Jul 2020 15:42:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 30FCC1BFF5; Tue, 28 Jul 2020 15:42:03 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 25C381BFF5 for <dev@dpdk.org>; Tue, 28 Jul 2020 15:42:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595943721; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDUrKPVqy8ssKvh9mOWkP953LeiWqc15DN+TYDhtkWg=; b=HXdG3BFIOapOd3QeixaxT0c4pRnxn+ddQHY2vVOiisXYn2rqFZwhfn5Moo6BrjXs8L18xy kohyCr/n5wUK3GKt551NmNqQh3Zffxg4qtsGowjwpEtvmQ1HMRV/GrudCRuFKabyeB/XmR t2xCdhaR27zQSdgqTiBfXtpfROI5Bkg= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-230-CjQ0sZ7SPcWMGE01N4aPhQ-1; Tue, 28 Jul 2020 09:41:57 -0400 X-MC-Unique: CjQ0sZ7SPcWMGE01N4aPhQ-1 Received: by mail-ua1-f69.google.com with SMTP id c13so6219276uav.22 for <dev@dpdk.org>; Tue, 28 Jul 2020 06:41:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rDUrKPVqy8ssKvh9mOWkP953LeiWqc15DN+TYDhtkWg=; b=pm0lSNFvXB+5Rd5IlSSORgf7SjWKdsQgwLFToFhCd8ahvVlpWm0keHMh/5e7pPBHId Ws90u+c7pHcVSSn/VcbZEJIWqSDQbCth2pa1V2AFt8t2zBiU5WyXRkdXmLP6R5snHHbg Gu7mSHr5QuwyZWj08VptlKplY7qwD+FVODvJjLxlQAzG9JHOnGGLUQRuNPzmDXfvocnm A9k4F1/ag3ntINELD8yG94sv2LVleWt+KYvD/ybhPktBeshD5vOcTgEWuhJ+P3ExkHr7 S7q+FomrWvlLTVN6OBmvZal5GAMGmqe+DF4QO09GEtrJ8gf91VjRSWBZrQOpD6PmhhlW KNtA== X-Gm-Message-State: AOAM531k6YLGZK3yxUtmClWznzecPXLsrgRipaYtr93sfQAo/wrgRPRE +gu4Yp7M6rH/bF0/jq5wqk2ZsVu1HwqWHRWHmh/pjB5Ta8bnUCeQcvwgBb44fHS7sfzVHFRslN0 b9U5Yvx2JZUcnWYptp6c= X-Received: by 2002:ab0:a8a:: with SMTP id d10mr5267041uak.41.1595943717289; Tue, 28 Jul 2020 06:41:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRbu7zIgOmj+3PZST4BgwoMC0mTziWjkxhBsGD3uslXJwcDRL3HhH+G8FIcH9Q68O3/p9BFAMs9k0Rb5gf82U= X-Received: by 2002:ab0:a8a:: with SMTP id d10mr5267021uak.41.1595943716944; Tue, 28 Jul 2020 06:41:56 -0700 (PDT) MIME-Version: 1.0 References: <20200710171946.23246-1-hemant.agrawal@nxp.com> <20200711081716.25173-1-hemant.agrawal@nxp.com> <69e3b354-ca32-e109-8385-ffc6b973f0cc@intel.com> <11996214.pnvohz1kia@thomas> <AM6PR04MB4456070B0D884576E7B6112D897B0@AM6PR04MB4456.eurprd04.prod.outlook.com> In-Reply-To: <AM6PR04MB4456070B0D884576E7B6112D897B0@AM6PR04MB4456.eurprd04.prod.outlook.com> From: David Marchand <david.marchand@redhat.com> Date: Tue, 28 Jul 2020 15:41:45 +0200 Message-ID: <CAJFAV8xc0jigKq1-eJi4qe14=bx8UkVo0yZCyAt+fb0T-Vqwbg@mail.gmail.com> To: Hemant Agrawal <hemant.agrawal@nxp.com> Cc: Thomas Monjalon <thomas@monjalon.net>, Sachin Saxena <sachin.saxena@nxp.com>, "dev@dpdk.org" <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>, "techboard@dpdk.org" <techboard@dpdk.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 1/8] net/dpaa: add support for fmlib in dpdk X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Hello Hemant, On Mon, Jul 20, 2020 at 6:50 AM Hemant Agrawal <hemant.agrawal@nxp.com> wrote: > >Why dropping this codebase in DPDK instead of pulling it as a dependency? > [Hemant] >I don't like seeing DPDK becoming a pile of code duplicated from somewhere else. > [Hemant] We are not using the library as it is and making some serious changes in the generic library to suit the DPDK use-case. > So, it is not possible for us to use the *original* code of fmlib, which is public. Looking at https://github.com/qoriq-open-source/fmlib which I think is the original code for this library (?). Some symbols from the original code were dropped in the dpdk copy of the file. Part of the API changed, with a param pointer now being passed. The VSP symbols are in the fm_lib.c file from the original code while they have been separated in a fm_vsp.c file in the dpdk copy. Some logs / comments have changed. For the sake of understanding: - can you point at the problems with reusing this externally maintained library? - this library is tightly linked to the fm kmod drivers I guess, how is maintained the compatibility? Thanks. -- David Marchand