From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6069FA09FF; Tue, 5 Jan 2021 22:26:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E0701607DC; Tue, 5 Jan 2021 22:26:59 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id E9E891607D9 for ; Tue, 5 Jan 2021 22:26:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1609882017; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=laZ7SvWLNBnY73x9nVSYdbnwJV6ynkzxyX0ge/GJ45U=; b=gCN27SChh5qXmoZ7yDT1tWFMgpOFGeFLxT3gOZUFnHmJGnEjVAYy4vmvWzot4ghNBmFD0r +jcPlpX2+E0yXICwusfz9fH/Igbw0trIH4oa1vQKr86DMR+3b1cRsqDIgsh1BE8eTwivt0 8ODE2PIIHobZg8NKxSY4yeD9kT/1DDw= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-368-6FeIL9eTO0CzJ2vgIvoaPQ-1; Tue, 05 Jan 2021 16:26:53 -0500 X-MC-Unique: 6FeIL9eTO0CzJ2vgIvoaPQ-1 Received: by mail-ua1-f72.google.com with SMTP id k2so265221uan.20 for ; Tue, 05 Jan 2021 13:26:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=laZ7SvWLNBnY73x9nVSYdbnwJV6ynkzxyX0ge/GJ45U=; b=nKZfafGHNDFhtAd7WJea8Gj0uLcvYaEgreGMOKWEEY4tHgbhUPDddeu4JnUvHS4RgX BddoW2teM+Gi6m3QMeQg/N2oxfTWW5xcjNYeSOkOg2LcQTIw9C1BB255pd8a0nYk5cYE tHFOfoK6b8M/UHEHFXgdUwMaSOab8hfBwxIbKU6VWDIyCM+5cdLsCcp7ktRJmD92qRB1 18IXrfIm1xfEAZJnUXtTXqTQdLQb9nb1L9bUkDaAx+G5T1pum4b7hZLBReMtZhrzfiEc G8CC49N3oD+wrV853ljc6A2PqesB4tJOgckWFADK0/BsmqeK8rlYIU198Rk18VGqyZ3/ mbhg== X-Gm-Message-State: AOAM531cL588WvfNFOkhxhxVb0c2hR0aEWq5EIaIBANoHlIPjo1ccPuD +eRLXB496vtTaXestKPp1QE5f9oybCthytqBRodeyrnmtcAxTIvr6blHKoWtdP1Ec5zviqL1t5I QB7KEqyDa0/gSHjYk6bQ= X-Received: by 2002:a67:6781:: with SMTP id b123mr1130284vsc.10.1609882013285; Tue, 05 Jan 2021 13:26:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyZFsUy+bRY6NlwkNEU2fnHiDoxMU1Kev6Jsd56tfd8Q/GdOU2T6bwk/nfwk6FXI6GLI2QfL7bKDlVrRVff88A= X-Received: by 2002:a67:6781:: with SMTP id b123mr1130278vsc.10.1609882013115; Tue, 05 Jan 2021 13:26:53 -0800 (PST) MIME-Version: 1.0 References: <20201220211405.313012-1-maxime.coquelin@redhat.com> <20201220211405.313012-38-maxime.coquelin@redhat.com> In-Reply-To: <20201220211405.313012-38-maxime.coquelin@redhat.com> From: David Marchand Date: Tue, 5 Jan 2021 22:26:42 +0100 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" , Olivier Matz , Adrian Moreno Zapata Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 37/40] net/virtio: introduce backend data X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Dec 20, 2020 at 10:16 PM Maxime Coquelin wrote: > diff --git a/drivers/net/virtio/virtio_user/vhost_kernel.c b/drivers/net/virtio/virtio_user/vhost_kernel.c > index 2fd00afa84..023fddcd69 100644 > --- a/drivers/net/virtio/virtio_user/vhost_kernel.c > +++ b/drivers/net/virtio/virtio_user/vhost_kernel.c > @@ -357,6 +357,12 @@ vhost_kernel_setup(struct virtio_user_dev *dev) > return 0; > } > > +static int > +vhost_kernel_destroy(struct virtio_user_dev *dev) > +{ Missing a __rte_unused. > + return 0; > +} > + > static int > vhost_kernel_set_backend(int vhostfd, int tapfd) > { > @@ -455,6 +461,7 @@ vhost_kernel_get_backend_features(uint64_t *features) > > struct virtio_user_backend_ops virtio_ops_kernel = { > .setup = vhost_kernel_setup, > + .destroy = vhost_kernel_destroy, > .get_backend_features = vhost_kernel_get_backend_features, > .set_owner = vhost_kernel_set_owner, > .get_features = vhost_kernel_get_features, > diff --git a/drivers/net/virtio/virtio_user/vhost_vdpa.c b/drivers/net/virtio/virtio_user/vhost_vdpa.c > index c826f333e0..b29426d767 100644 > --- a/drivers/net/virtio/virtio_user/vhost_vdpa.c > +++ b/drivers/net/virtio/virtio_user/vhost_vdpa.c > @@ -287,6 +287,13 @@ vhost_vdpa_setup(struct virtio_user_dev *dev) > return 0; > } > > +static int > +vhost_vdpa_destroy(struct virtio_user_dev *dev __rte_unused) > +{ > + return; > + return 0; Rebase damage ? :) > +} > + -- David Marchand