From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5C83A04BC; Thu, 8 Oct 2020 09:10:10 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 984921B9E0; Thu, 8 Oct 2020 09:10:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 17D7E1B9DC for ; Thu, 8 Oct 2020 09:10:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602141005; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=3rcAx1taPvYiManJyWN8FSm6TJZKGGJVi2s3TR988L0=; b=gJg/h2REpOur2L+SCXXCMq2/BSJ+swfbga6lg2ak9scucnaAPdzY92pwlKb47+ZhC1LBgX 5YHYgqgD65+5qhFVfgSDaD1xFtnqOR9WZbG/TnOaJ1+ryGYboGWhcM9teSEd2pSQ6NKoJ2 AfyxCpg+rET6FWMfWCUdvtR/25WJrpU= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-QTJB42xgNjap6Q_MZUGxXg-1; Thu, 08 Oct 2020 03:10:04 -0400 X-MC-Unique: QTJB42xgNjap6Q_MZUGxXg-1 Received: by mail-vk1-f197.google.com with SMTP id v129so743434vke.23 for ; Thu, 08 Oct 2020 00:10:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3rcAx1taPvYiManJyWN8FSm6TJZKGGJVi2s3TR988L0=; b=gK9I6B5/afila0J2PVWmBJbQtftHl0bVeq+Tz8PPX03NItpDqJEsQ6BXB5tsNC44k4 hvPxTEzFRS8P1eVOKA50V7SNLllHR7jaqXlBPTWrhb2CMbvvUH0DrAtSnXpevjyz4/Z+ 5RjHrcDvIzUKi3Q2AkrK/HVSfXUNaFAAwTGoYbcgX7R6dKGGmbg6lx7z65tkBP91TOep LPj7DNYweBcB4pSN6WO7qRsb5cZTaERsMWWFoRI5Moc1TmIKo44SEHFknqlUm/4yDcPI fziYDN76agSp9vc3AvQUsqItEoHUzHjC+8Air9sLO6vMNXHofbAjaVytSdtp9XSf+O5H n8jA== X-Gm-Message-State: AOAM531L4FoyqFBFlI1mWbARu1HX7by5ZYtTXIHdQUkOApLjg/jTukL8 otU1IuMr2CnTrAZiyBjBnzcLRY1iPwsItFdClNUMFlurZBC7ixc+gBtfZxJC/yCER6mQWIPwDtR aCRJU++rdQWuc5PsDOoE= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr3963149vsa.27.1602141003530; Thu, 08 Oct 2020 00:10:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx0B1CHIZ1tnvCfZ9Fdo2K6/zXlxWNL9oNvI6J8Bi7PRrp0KHHesjA/HYgaKKaxaGq0uts+u/7yhiL5q4chIX4= X-Received: by 2002:a67:fd7a:: with SMTP id h26mr3963138vsa.27.1602141003304; Thu, 08 Oct 2020 00:10:03 -0700 (PDT) MIME-Version: 1.0 References: <1599700614-22809-1-git-send-email-omkar.maslekar@intel.com> <1601512112-12577-1-git-send-email-omkar.maslekar@intel.com> <1601512112-12577-2-git-send-email-omkar.maslekar@intel.com> In-Reply-To: <1601512112-12577-2-git-send-email-omkar.maslekar@intel.com> From: David Marchand Date: Thu, 8 Oct 2020 09:09:52 +0200 Message-ID: To: Omkar Maslekar Cc: dev , Bruce Richardson , "Ananyev, Konstantin" , Ciara Loftus , David Christensen , Jerin Jacob Kollanukkaran , Honnappa Nagarahalli , "Ruifeng Wang (Arm Technology China)" , Jan Viktorin , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5] eal: add cache-line demote support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 1, 2020 at 2:30 AM Omkar Maslekar wrote: > > rte_cldemote is similar to a prefetch hint - in reverse. cldemote(addr) > enables software to hint to hardware that line is likely to be shared. > Useful in core-to-core communications where cache-line is likely to be > shared. ARM and PPC implementation is provided with NOP and can be added > if any equivalent instructions could be used for implementation on those > architectures. > > Signed-off-by: Omkar Maslekar > Acked-by: Bruce Richardson I find this "rte_cldemote" name too close to the Intel instruction, but I can see no complaint from other arch maintainers, so I guess everyone is happy with it. In any case, this is a new API, so it should be marked experimental. As for unit tests, not sure there is much to do, maybe rename test_prefetch.c and call this new API too, wdyt? -- David Marchand