Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix missing include

Re: [dpdk-dev] [dpdk-stable] [PATCH] eal: fix missing include

[David Marchand]

On Sun, Jun 21, 2020 at 9:49 AM Yunjian Wang <yunjian.wang@foxmail.com> wrote:
>
> This patch adds the missing include and fixes the build error:
> /dpdk/build/include/rte_uuid.h: In function 'rte_uuid_copy':
> /dpdk/build/include/rte_uuid.h:58:2: error: implicit declaration
> of function 'memcpy' [-Werror=implicit-function-declaration]
>   memcpy(dst, src, sizeof(rte_uuid_t));
>   ^~~~~~
>
> Fixes: 6bc67c497a51 ("eal: add uuid API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Yunjian Wang <yunjian.wang@foxmail.com>
> ---
>  lib/librte_eal/include/rte_uuid.h | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_eal/include/rte_uuid.h b/lib/librte_eal/include/rte_uuid.h
> index 044afbdfa..dc86eb292 100644
> --- a/lib/librte_eal/include/rte_uuid.h
> +++ b/lib/librte_eal/include/rte_uuid.h
> @@ -15,6 +15,7 @@ extern "C" {
>  #endif
>
>  #include <stdbool.h>
> +#include <string.h>
>
>  /**
>   * Struct describing a Universal Unique Identifier
> --
> 2.18.1
>

A fix for this issue has been submitted before and made it to the main
branch this week.
https://git.dpdk.org/dpdk/commit/?id=edca6d883eb0137bc3caf7f93651a67360ebdf96

Thanks.


-- 
David Marchand