From: David Marchand <david.marchand@redhat.com>
To: Steven Lariau <steven.lariau@arm.com>
Cc: dev <dev@dpdk.org>, nd <nd@arm.com>,
Dharmik Thakkar <Dharmik.Thakkar@arm.com>,
"Ruifeng Wang (Arm Technology China)" <ruifeng.wang@arm.com>,
Gage Eads <gage.eads@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2 0/5] lib/stack: improve lockfree C11 implementation
Date: Wed, 30 Sep 2020 21:14:56 +0200 [thread overview]
Message-ID: <CAJFAV8xdQjmruA-XegiRAoCXLWyuG7JEYi3H28oANkwDTmsv5g@mail.gmail.com> (raw)
In-Reply-To: <20200925174340.10014-1-steven.lariau@arm.com>
On Fri, Sep 25, 2020 at 7:44 PM Steven Lariau <steven.lariau@arm.com> wrote:
>
> One implementation of the DPDK stack library is lockfree,
> based on C11 memory model for atomics.
> Some of these atomic operations use unnecessary memory orders,
> that can be relaxed.
> This patch relax some of these operations in order to improve
> the performance of the stack library.
>
> The patch was tested on several architectures, to ensure that
> the implementation is correct, and to measure performance.
> Below are the results for a few architectures on multithread stack
> lockfree test.
> The cycles count is the average number of cycles per item to perform
> a bulk push / pop.
>
> $sudo ./builddir/app/dpdk-test
> RTE>>stack_lf_perf_autotest
> difference compared to main
> Cycles count on ThunderX2
> 2 cores, bulk size = 8: -15.85%
> 2 cores, bulk size = 32: -04.56%
> 4 cores, bulk size = 8: -05.00%
> 4 cores, bulk size = 32: -04.35%
> 16 cores, bulk size = 8: -02.38%
> 16 cores, bulk size = 32: -01.88%
>
> difference compared to main
> Cycles count on N1SDP
> 2 cores, batch size = 8: +00.77%
> 2 cores, batch size = 32: -16.00%
>
> difference compared to main
> Cycles count on Skylake
> 2 cores, bulk size = 8: -00.18%
> 2 cores, bulk size = 32: -00.95%
> 4 cores, bulk size = 8: -01.19%
> 4 cores, bulk size = 32: +00.64%
> 16 cores, bulk size = 8: +01.20%
> 16 cores, bulk size = 32: +00.48%
>
> v2: add comment to explain why pop head CAS relaxed is valid
> added Fixes information
>
> Steven Lariau (5):
> lib/stack: fix inconsistent weak / strong cas
> lib/stack: remove push acquire fence
> lib/stack: remove redundant orderings for list->len
> lib/stack: reload head when pop fails
> lib/stack: remove pop cas release ordering
>
> lib/librte_stack/rte_stack_lf_c11.h | 32 +++++++++++++++++++----------
> 1 file changed, 21 insertions(+), 11 deletions(-)
Series applied, thanks for those optimisations.
--
David Marchand
prev parent reply other threads:[~2020-09-30 19:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-11 15:29 [dpdk-dev] [PATCH " Steven Lariau
2020-09-11 15:29 ` [dpdk-dev] [PATCH 1/5] lib/stack: fix inconsistent weak / strong cas Steven Lariau
2020-09-21 17:16 ` Eads, Gage
2020-09-11 15:29 ` [dpdk-dev] [PATCH 2/5] lib/stack: remove push acquire fence Steven Lariau
2020-09-21 17:16 ` Eads, Gage
2020-09-11 15:29 ` [dpdk-dev] [PATCH 3/5] lib/stack: remove redundant orderings for list->len Steven Lariau
2020-09-21 17:16 ` Eads, Gage
2020-09-11 15:29 ` [dpdk-dev] [PATCH 4/5] lib/stack: reload head when pop fails Steven Lariau
2020-09-21 17:16 ` Eads, Gage
2020-09-11 15:29 ` [dpdk-dev] [PATCH 5/5] lib/stack: remove pop cas release ordering Steven Lariau
2020-09-21 17:17 ` Eads, Gage
2020-09-25 14:27 ` David Marchand
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 0/5] lib/stack: improve lockfree C11 implementation Steven Lariau
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 1/5] lib/stack: fix inconsistent weak / strong cas Steven Lariau
2020-09-28 10:22 ` David Marchand
2020-09-28 15:58 ` Eads, Gage
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 2/5] lib/stack: remove push acquire fence Steven Lariau
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 3/5] lib/stack: remove redundant orderings for list->len Steven Lariau
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 4/5] lib/stack: reload head when pop fails Steven Lariau
2020-09-25 17:43 ` [dpdk-dev] [PATCH v2 5/5] lib/stack: remove pop cas release ordering Steven Lariau
2020-09-25 17:57 ` Eads, Gage
2020-09-30 19:14 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xdQjmruA-XegiRAoCXLWyuG7JEYi3H28oANkwDTmsv5g@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=Dharmik.Thakkar@arm.com \
--cc=dev@dpdk.org \
--cc=gage.eads@intel.com \
--cc=nd@arm.com \
--cc=ruifeng.wang@arm.com \
--cc=steven.lariau@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).