From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A25F43B04; Tue, 13 Feb 2024 12:12:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8525A4029C; Tue, 13 Feb 2024 12:12:55 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 1A8FB4027B for ; Tue, 13 Feb 2024 12:12:54 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707822773; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOAjZcdvluesHYnK08vPL/Ex05ZSap4gasNLQYlCZW0=; b=Fl6+w6O7pwYvifIjXn/7qMZcDjIUi1R7I08y6p7Lyl2Mue824nMOYDq4Ej9882ASjGe+98 IzEEe8Anc94O+gVhjrAVijTG16PcTCBNUyYISBoMpRtr5UHIs4J27N1Luqx+2tAeUJZfr1 Dgc6GPNHnDQmd46hsAoieQZXED6cbqQ= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-175-0bElknHGNi2rnwan2LrhiA-1; Tue, 13 Feb 2024 06:12:51 -0500 X-MC-Unique: 0bElknHGNi2rnwan2LrhiA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-511559b30edso3065420e87.3 for ; Tue, 13 Feb 2024 03:12:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707822770; x=1708427570; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jOAjZcdvluesHYnK08vPL/Ex05ZSap4gasNLQYlCZW0=; b=Di0C9uIgvJGpBY4EpmGBvNmaeW+YG5rWjuFMEKck+/tUFedmJXYjHFuB9qYNwho2Yl Po+ZfwhOa8Nkr35MJbLqOAvKcBY8mXPoLOsjLHVEjJmJkhdUi7xRfPSriOqYu4EdUK0I PXSGoCHwVp1Y/D0WBVLflHaAbR0BnCmZ5cZLwIISKszBHeSquHVqHm1Tolh6UyNtxEte E2Op8n5sbzUOxAbz4dbrWjVy+fCliWL7GyUIq+Murwjo0LsktyRRo+vQuaQo3GWTryJd 8eAO+h5blK4/zHVQXjXobagh1/NQnk/Os1Y9DxN489NrVsvryPYzKu0JPvqw4ZXRJrEI JyEA== X-Gm-Message-State: AOJu0YxijknD4zZDC+veuW13pUwxrjnP9SNeQLYxc+6a+HKwgXz8uhRP HLPIi8hgePPLRdA3enmUNZWGNO9CvPZ2leJo+8fzByB2d4eAkIcTqJj6qwBmrRCvH8TiETDDfoK Gin8eu+QYrR8qERZOSe14TtkLn0/P5Bru7fNTgK4dqbFO9WhKqeGqBcZp0FVrl+xQD9mv0R3rpS B36EK7wHsejJDmw6E= X-Received: by 2002:a05:6512:3b6:b0:511:9489:dda8 with SMTP id v22-20020a05651203b600b005119489dda8mr2106859lfp.6.1707822769947; Tue, 13 Feb 2024 03:12:49 -0800 (PST) X-Google-Smtp-Source: AGHT+IGdTEEg5vNRZ+CpVf/4Y4bJMn+DUK29Ud4u/EgFA72ndU7Loau9OiiEbPWrrVRqfWTFGnZgZUXRy5USLLOZOWw= X-Received: by 2002:a05:6512:3b6:b0:511:9489:dda8 with SMTP id v22-20020a05651203b600b005119489dda8mr2106843lfp.6.1707822769627; Tue, 13 Feb 2024 03:12:49 -0800 (PST) MIME-Version: 1.0 References: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1703006864-27378-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Tue, 13 Feb 2024 12:12:37 +0100 Message-ID: Subject: Re: [PATCH 0/2] remove __typeof__ from expansion of per lcore macros To: Tyler Retzlaff Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Dec 19, 2023 at 6:28=E2=80=AFPM Tyler Retzlaff wrote: > > The design of the macros requires a type to be provided to the macro. > > By expanding the type parameter inside of typeof it also inadvertently > allows an expression to be used which appears not to have been intended > after evaluating the parameter name and existing macro use. > > Technically this is an API break but only for applications that were > using these macros outside of the original design intent. Please add a release note on this topic (I am fine with just a reply to this mail, I can fold this change when applying). The rest lgtm. --=20 David Marchand