From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7941AA00C2; Thu, 6 Oct 2022 21:25:31 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5ED52400D6; Thu, 6 Oct 2022 21:25:31 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 8B27F40042 for ; Thu, 6 Oct 2022 21:25:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1665084329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w5qKGCAAOiZ45B8p4FSA8kna62i3VP5HUNw+O+OMwzE=; b=V4/XRSzDQ7UHkcIDDQbm4qnPmyiyCojCfoSJl0CPP3Dhr3UMzEiGa6R4ebvJ1e5evrS5/6 nsr8LhuFogJ8lS2esFweieJAP/0ybra92MSRnXCQXaFDXsSyrVQ6siLPlUG8QF6xsbkAeL 0PgzQa0Uvr5gLwuA/yrWh8d97u79iAI= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-332-ENzcNam8PTCnZDnli0WzOw-1; Thu, 06 Oct 2022 15:25:27 -0400 X-MC-Unique: ENzcNam8PTCnZDnli0WzOw-1 Received: by mail-pj1-f71.google.com with SMTP id nn14-20020a17090b38ce00b0020acfa1403bso3112860pjb.1 for ; Thu, 06 Oct 2022 12:25:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=w5qKGCAAOiZ45B8p4FSA8kna62i3VP5HUNw+O+OMwzE=; b=5blVpECGuaIz5Gl6fVY3z6WL1Gztfl12Lxdz5CKKwlzZUcF/fHxDddYnR21HDPFycF GcZ8MHGIgmApHB7klYCpNa5GY3S1FBQ6kgckgOaPqmAADAw8NWzfGaLlJJ7h+QUAVxqp eY1zLb9O20iXLalgM1Y4mAdN7j+thOv45cgnppsGHLZwM5nvfYMk9k21sd5Aowm1DlYe pbhSAPngzbvmsJCKiCT9veqkUS8j4HTJ+rte30Qkjsm8PfvrVg6zL2Y+mxd0gsfSskN6 D0TMqP34GPG9obkQBaHgS/Uy0724fa5UMBCkOhCS3C4mSdVrdkOo7adA8nWG0hf9aFrb hLkA== X-Gm-Message-State: ACrzQf3C2UKiXZv2liS9PXpB9M7taI0dcj0SbdPxTDRk9s06kpRieXM0 KrklSNZzKqlCVqfE35zbryWvbwtk7fgROEgeovQYP9JpT1akSXZzOqUXdYA4E5pPqvKTsGykQyg gGrBuSTDcUkkFzsyhPVU= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr1112132pgm.223.1665084326441; Thu, 06 Oct 2022 12:25:26 -0700 (PDT) X-Google-Smtp-Source: AMsMyM78wI6FyA2m31OPGlHeBgxy78COpJI8ZqgqaKdNPjGj60PK/YFa83mlA8uO4BuMeULGyQ+fZ/0G0/HIrLGAAvs= X-Received: by 2002:a63:5b58:0:b0:452:2ba4:f86b with SMTP id l24-20020a635b58000000b004522ba4f86bmr1112118pgm.223.1665084326160; Thu, 06 Oct 2022 12:25:26 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1664989651-29303-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1664989651-29303-1-git-send-email-roretzla@linux.microsoft.com> From: David Marchand Date: Thu, 6 Oct 2022 21:25:12 +0200 Message-ID: Subject: Re: [PATCH v5 0/6] add thread lifetime and attributes API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 7:07 PM Tyler Retzlaff wrote: > > add rte thread lifetime and attributes api. with these api additions > there is now sufficient platform abstracted thread api to remove the > use of pthread in the unit tests. > > v5: > * include errno.h in rte_thread.c since errno.h is no longer included > in rte_common.h > * move rte_thread_attr symbols from 22.07 to 22.11 section of > version.map. > * remove RTE_HAS_CPUSET guards from rte_thread.h Here is a summary of what I did: - I had to rollback part of RTE_HAS_CPUSET guards. I had forgotten about the reason for those guards: the "culprit" is Alpine Linux / musl where cpuset is not exposed unless an application is built with _GNU_SOURCE. See: https://git.dpdk.org/dpdk/commit/lib/librte_eal/include/rte_thread.h?id=e0473c6d5b18560dd11fd4d7ebc81dea6774f33e - I squashed patch 6 in patch 4 to fix the compilation. - I moved rte_thread.c content to eal_common_thread.c. - I still added Dmitry acks from v4, as the functional parts/API did not change. Series applied, thanks. -- David Marchand