DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] doc: remove cmdline_poll deprecation notice
@ 2023-12-11 16:52 Stephen Hemminger
  2023-12-11 17:05 ` Bruce Richardson
  2024-02-13 15:48 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: Stephen Hemminger @ 2023-12-11 16:52 UTC (permalink / raw)
  To: dev; +Cc: Stephen Hemminger

cmdline_poll has been removed by:
commit f44f2edd198a ("cmdline: remove poll function")
but deprecation notice was left behind.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 doc/guides/rel_notes/deprecation.rst | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 81b93515cbd9..10630ba25564 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -27,10 +27,6 @@ Deprecation Notices
 * kvargs: The function ``rte_kvargs_process`` will get a new parameter
   for returning key match count. It will ease handling of no-match case.
 
-* cmdline: The function ``cmdline_poll`` does not work correctly on either
-  Linux or Windows and is unused by any part of DPDK.
-  This function is now deprecated and will be removed in DPDK 23.11.
-
 * telemetry: The functions ``rte_tel_data_add_array_u64`` and ``rte_tel_data_add_dict_u64``,
   used by telemetry callbacks for adding unsigned integer values to be returned to the user,
   are renamed to ``rte_tel_data_add_array_uint`` and ``rte_tel_data_add_dict_uint`` respectively.
-- 
2.42.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] doc: remove cmdline_poll deprecation notice
  2023-12-11 16:52 [PATCH] doc: remove cmdline_poll deprecation notice Stephen Hemminger
@ 2023-12-11 17:05 ` Bruce Richardson
  2024-02-13 15:48 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: Bruce Richardson @ 2023-12-11 17:05 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev

On Mon, Dec 11, 2023 at 08:52:37AM -0800, Stephen Hemminger wrote:
> cmdline_poll has been removed by:
> commit f44f2edd198a ("cmdline: remove poll function")
> but deprecation notice was left behind.
> 

Suggest adding that commit in a fixes line and adding stable on Cc so this
can be picked up for backport.

> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 81b93515cbd9..10630ba25564 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -27,10 +27,6 @@ Deprecation Notices
>  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
>    for returning key match count. It will ease handling of no-match case.
>  
> -* cmdline: The function ``cmdline_poll`` does not work correctly on either
> -  Linux or Windows and is unused by any part of DPDK.
> -  This function is now deprecated and will be removed in DPDK 23.11.
> -
>  * telemetry: The functions ``rte_tel_data_add_array_u64`` and ``rte_tel_data_add_dict_u64``,
>    used by telemetry callbacks for adding unsigned integer values to be returned to the user,
>    are renamed to ``rte_tel_data_add_array_uint`` and ``rte_tel_data_add_dict_uint`` respectively.
> -- 
> 2.42.0
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] doc: remove cmdline_poll deprecation notice
  2023-12-11 16:52 [PATCH] doc: remove cmdline_poll deprecation notice Stephen Hemminger
  2023-12-11 17:05 ` Bruce Richardson
@ 2024-02-13 15:48 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2024-02-13 15:48 UTC (permalink / raw)
  To: Stephen Hemminger; +Cc: dev, Bruce Richardson

On Mon, Dec 11, 2023 at 5:53 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> cmdline_poll has been removed by:
> commit f44f2edd198a ("cmdline: remove poll function")
> but deprecation notice was left behind.
>

Fixes: f44f2edd198a ("cmdline: remove poll function")
Cc: stable@dpdk.org

> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-02-13 15:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-12-11 16:52 [PATCH] doc: remove cmdline_poll deprecation notice Stephen Hemminger
2023-12-11 17:05 ` Bruce Richardson
2024-02-13 15:48 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).