From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EC33243CA3; Thu, 14 Mar 2024 15:40:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61D3640297; Thu, 14 Mar 2024 15:40:40 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D17184028C for ; Thu, 14 Mar 2024 15:40:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1710427238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wKBor6P5dwSh/5KE96qeVo7LTxyq75Jw3D96+01ryh4=; b=CKEou4kReImJk5LXI5aGvUcxQkj7/u0UDhZLqAwlC+uKXEZVkXfC/nQ8IavGq720jkJSor 76/F1eSuYcNtGMExfPaRsuZh2F1MeJ+1btINos6vJzxYYjzS1YUZLptRqb04Jv5Mxu5Dtf RbGLkrH45vgn+k7rgag4EMNmq+LPsmA= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-463-UrYpXfXjOFOH3iNNMblIfA-1; Thu, 14 Mar 2024 10:40:36 -0400 X-MC-Unique: UrYpXfXjOFOH3iNNMblIfA-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-5135aa34125so794194e87.0 for ; Thu, 14 Mar 2024 07:40:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710427235; x=1711032035; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wKBor6P5dwSh/5KE96qeVo7LTxyq75Jw3D96+01ryh4=; b=Az8hOVb9alj9wpPWvrVIwbFZvoaoO30iNGUSnH5tiToSnjd1HeWGwyn9Fowru6gJeH w4IHKxp2GnChEDL45eQtGtdQCufGK54CF1kjx+hz1hGi7PuyRLS6bl2OrXMaLZRqPIk9 zitzt7cPbCxwPcL3DTqwQ6/+boV6ttO5NwPqoXxsN7nwyVoft69+sGM8ox+gE+GIABnl ilThHiishCSoeL97Oxr8RzKUJwHnpGcpEo4lVN03wmpIzaN/vyIfOnoZHf3hxqyjDN9f dXHJIAQJCwagWVPgpCtBkS4eIw++bKrBHOxmmjPktbfB2F5XuYlUNRkrF0b0wdmYFLXy 2Nbg== X-Gm-Message-State: AOJu0Yzxday8TqXf87vEPGUbzG+kOVAVQB/9EalQbHRdieFSQ4brfofM 9qclDjrsGFgVvja472rRznATQcsu95+S6+KEL+rsorGE9EOPOVUtd3CZ22HfsP/aiqeaTrgLZzf +Myt/sKlLyW45liFYtqFZZn5Zrmq+m8XWc0ZTo1ffv4CDTEvwqfVl6KxGtibbHMIUmNW91Ig3I4 jgmGiyp6fqJr3kTU8= X-Received: by 2002:ac2:457a:0:b0:513:d3b7:7578 with SMTP id k26-20020ac2457a000000b00513d3b77578mr903257lfm.60.1710427235173; Thu, 14 Mar 2024 07:40:35 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEX4Qs09yrVN1+NR+UpM5xF1Srxd9Tep3XX2bWKOZ6kQGmNNgDonra8U6iWjELFByLNUdhrDCr/5H4knYiJb5c= X-Received: by 2002:ac2:457a:0:b0:513:d3b7:7578 with SMTP id k26-20020ac2457a000000b00513d3b77578mr903240lfm.60.1710427234830; Thu, 14 Mar 2024 07:40:34 -0700 (PDT) MIME-Version: 1.0 References: <20240308185401.150651-1-stephen@networkplumber.org> In-Reply-To: <20240308185401.150651-1-stephen@networkplumber.org> From: David Marchand Date: Thu, 14 Mar 2024 15:40:22 +0100 Message-ID: Subject: Re: [RFC] eal: increase the number of availble file descriptors for MP To: Stephen Hemminger Cc: dev@dpdk.org, Anatoly Burakov , Ferruh Yigit , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Mar 8, 2024 at 7:54=E2=80=AFPM Stephen Hemminger wrote: > > The current limit of file descriptors is too low, it should have > been set to the maximum possible to send across an unix domain > socket. > > This is an attempt to allow increasing it without breaking ABI. > But in the process it exposes what is broken about how symbol > versions are checked in check-symbol-maps.sh. That script is > broken in that it won't allow adding a backwards compatiable > version hook like this. - It could be enhanced maybe, but I see no problem with the script. The versions for compat symbols in this patch are wrong. We want to keep compat with ABI 24, not 23. And next ABI will be 25. - rte_mp_old_msg does not have to be exported as public in rte_eal.h. - I think the patch is not complete: * rte_mp_action_register and rte_mp_request_async need versioning too, * because of the former point, handling of msg requests probably needs to keep track of accepted length per registered callbacks, --=20 David Marchand