From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E831CA0553; Mon, 17 Feb 2020 12:20:08 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2E0131D6E3; Mon, 17 Feb 2020 12:20:08 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 5CC741BF9F for ; Mon, 17 Feb 2020 12:20:06 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581938405; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=R95ucyuhaGSy4yj4D10FBh9zlBNolQfz0VHu8N513u0=; b=Dq6gbjfkraCSiB7PZDMhgH6xNh/LnXCVhBYm9l4HqwaD+J1ysUkgG3s8pNT4RxIXDK9wEd tWEGYH8BahqH+hMWuqvUDgTStAc3d6s2mxJVC8bsfm8cazEzlh/Iw2SBh7LFoHbkKExLrT VXz5b5+fJS+JtJC3ZXXcR7oIOUdm++o= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-361-jw_qmQcPOv6eisVTFxqvRg-1; Mon, 17 Feb 2020 06:20:04 -0500 Received: by mail-vk1-f200.google.com with SMTP id i123so6631416vkg.8 for ; Mon, 17 Feb 2020 03:20:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=R95ucyuhaGSy4yj4D10FBh9zlBNolQfz0VHu8N513u0=; b=ExAP2AjIesxZ24jzZg0BElr81LwEK/PN4ZAIspXpADsv/OlgpeZEtRJQV4FSOs/CT3 RpzWX9Dw4iW8BdOdrJTovBc5ND2H1YDivn5Rq6Yvy1BMxtwjoPdU70mSVopeFCnTMs1M xSeP44QQDmLB6slKd4egMGWXRYCj5RDYkL4npDNs6i0j/VwO4gzdvDb9dYRzLLAzWMsH Vi/j869BJFs5tsP4Wz/xefHiHL1K/kBXsV9ZOq+vc4DGMmE4CA+rtkykVnPUKM26Eu0v bHwYvoAoLGC44jj158Oo2/iuJTB6rWTSYQxVpy5/wx4INu3PINVgA4hoTjuXZFppq7B4 LPiQ== X-Gm-Message-State: APjAAAVJ+opXRlX/VmKDQ9EV9npM1qDvbiEjfVCxh41VQMcxUQ8ro9X0 K6KV1mQDU/fsj8w+5zBMcnSfRblwJ3Dw5QCr8ou4uF7ZHXoEzmW+Gf8koH6mJJ1eG2dp5EGgScP bFvvYAMizljzfXXzTr/Q= X-Received: by 2002:a67:b303:: with SMTP id a3mr7958772vsm.141.1581938403441; Mon, 17 Feb 2020 03:20:03 -0800 (PST) X-Google-Smtp-Source: APXvYqyzgKryPmVF1giFNKUxHOftcvcHL82tUHn2PZ5mxWcYxinAwAeqtC69m3E0HsJvAiKKJ+SgaqbmInf28nO2EAM= X-Received: by 2002:a67:b303:: with SMTP id a3mr7958760vsm.141.1581938403184; Mon, 17 Feb 2020 03:20:03 -0800 (PST) MIME-Version: 1.0 References: <20200217164345.6207-1-taox.zhu@intel.com> In-Reply-To: <20200217164345.6207-1-taox.zhu@intel.com> From: David Marchand Date: Mon, 17 Feb 2020 12:19:52 +0100 Message-ID: To: taox.zhu@intel.com Cc: Jerin Jacob Kollanukkaran , Nithin Dabilpuram , Vamsi Attunuru , dev , Jeremy Plsek , Bruce Richardson , Aaron Conole X-MC-Unique: jw_qmQcPOv6eisVTFxqvRg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] mempool/octeontx2: fix compile issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch has been sent with a date in the future. Date: Mon, 17 Feb 2020 16:43:45 +0000 Please fix your mail setup, this triggers an error with meson in UNH CI (at least). --=20 David Marchand On Mon, Feb 17, 2020 at 9:09 AM wrote: > > From: Tao Zhu > > Change the definition of C99 style to C90 style. > compile log as below: > > otx2_mempool_ops.c: In function =E2=80=98otx2_npa_populate=E2=80=99: > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: error: \ > =E2=80=98for=E2=80=99 loop initial declarations are only allowed = in C99 mode > for (int i =3D 0; i < OTX2_L1D_NB_SETS; i++) > ^ > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c:790:2: \ > note: use option -std=3Dc99 or -std=3Dgnu99 to compile your code > /dpdk/drivers/mempool/octeontx2/otx2_mempool_ops.c: At top level: > cc1: error: unrecognized command line option \ > "-Wno-address-of-packed-member" [-Werror] > cc1: all warnings being treated as errors > make[6]: *** [otx2_mempool_ops.o] Error 1 > make[5]: *** [octeontx2] Error 2 > make[4]: *** [mempool] Error 2 > > Fixes: 9ed8e95c ("mempool/octeontx2: optimize for L1D cache architecture"= ) > > Signed-off-by: Tao Zhu > --- > drivers/mempool/octeontx2/otx2_mempool_ops.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mempool/octeontx2/otx2_mempool_ops.c b/drivers/mempo= ol/octeontx2/otx2_mempool_ops.c > index 6b55447..ac2d618 100644 > --- a/drivers/mempool/octeontx2/otx2_mempool_ops.c > +++ b/drivers/mempool/octeontx2/otx2_mempool_ops.c > @@ -754,6 +754,7 @@ > size_t total_elt_sz; > uint8_t set; > size_t off; > + int i; > > if (iova =3D=3D RTE_BAD_IOVA) > return -EINVAL; > @@ -787,7 +788,7 @@ > otx2_npa_dbg("requested objects %"PRIu64", possible objects %"PRI= u64"", > (uint64_t)max_objs, (uint64_t)(len / total_elt_sz)); > otx2_npa_dbg("L1D set distribution :"); > - for (int i =3D 0; i < OTX2_L1D_NB_SETS; i++) > + for (i =3D 0; i < OTX2_L1D_NB_SETS; i++) > otx2_npa_dbg("set[%d] : objects : %"PRIu64"", i, > distribution[i]); > > -- > 1.8.3.1 >