From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 910A7A04A7; Tue, 5 May 2020 19:08:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9FC441D5CE; Tue, 5 May 2020 19:08:07 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 037AE1D59C for ; Tue, 5 May 2020 19:08:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588698485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/6TwnEz+O3+EOD3liXtD5XEab6YV+3mEIi6dvdjbtK0=; b=cpfjECUDziU2aUPD3rsAKq9ecOq+4XfRTbFmReVTy/AulEf8lvGCc3yW1QUu5XCGwodOQs ehPnDcNl2LC2HGzuDQhf0kAdlvXaB+/R14ubzInevq1ePbAfm6U+8pfdYSpQ/TpIMvkxu3 zlVXSXY/1oSFyLqPabqxyZLAlzWXLz0= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479--jsMbP1RMoaLSmkdF7GlFQ-1; Tue, 05 May 2020 13:08:01 -0400 X-MC-Unique: -jsMbP1RMoaLSmkdF7GlFQ-1 Received: by mail-vk1-f200.google.com with SMTP id b137so1278965vke.18 for ; Tue, 05 May 2020 10:08:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IoHI1tWVl7ahkPnI8/0jMcG6lnP2eH/27t++r8IqmhI=; b=spkjqJfTTpX4LOz3EFmkwzMw0M9RlqUSHSmR8WI4lJCAp9js91AeFZtiMClPHRW/tx WsaByadqhQ81CQGd0LUwoeB3HDggNZzjnUZfWEC3+HLrzeVTzdi512caAqEfF8eSIaG5 dEO8b6LVq/APsDQ+IsLuXjYHvLg4Y0NXe9CJp5usn3abxTreiDL6KqAXM2d/jmzmKot0 01K26+yiEOtyb8XDevKUKdWnSZW6dnH8rJCJnU77HJbSOnLYXiSByLU1wWY815Q/fGkT v03Yv4LIC6QI3FCuBMBnnjlevRaHj6bDWYvNoF591+LRP+l9Ot99AntYwu6f4cX6DvXs FFzw== X-Gm-Message-State: AGi0PuZn1eskv3YNpAxeMRzAI6wLjRGTVVpS/TR+9hF6LqWVh/mobr9A Lwy/D/uEzhozHNlzmOlhn5YLs6gzgmli3kL7nGD0vIE1NVcAvQSF5c2F2hsvZBoPFZygPCwrqxn XgIlDlnueBZJJik35M2M= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr3615229uaj.41.1588698481388; Tue, 05 May 2020 10:08:01 -0700 (PDT) X-Google-Smtp-Source: APiQypI6zh/WzOp8ITJ9dtXisA3+3Xf0bqtLl/jOrnY+Yekz2K8e+S8hEz8h5RInLyqYqejtzSy9g+tfyxI8AiNowKE= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr3615196uaj.41.1588698480982; Tue, 05 May 2020 10:08:00 -0700 (PDT) MIME-Version: 1.0 References: <20200505140832.646-1-hemant.agrawal@nxp.com> In-Reply-To: <20200505140832.646-1-hemant.agrawal@nxp.com> From: David Marchand Date: Tue, 5 May 2020 19:07:48 +0200 Message-ID: To: Hemant Agrawal Cc: dev , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH 1/7] common/dpaax: move internal symbols into INTERNAL section X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Cc: Ray. On Tue, May 5, 2020 at 4:10 PM Hemant Agrawal wrot= e: > > This patch moves the internal symbols to INTERNAL sections > so that any change in them is not reported as ABI breakage. Talking about the series (not just this patch as I did not look at the details), travis reported a build issue: https://travis-ci.com/github/ovsrobot/dpdk/builds/163985766 It looks like there is a versioned symbol for a static function of one of those drivers. $ git grep dpaa2_get_qbman_swp origin/master origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c:static struct dpaa2_dpio_dev *dpaa2_get_qbman_swp(int lcoreid) origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c: dpaa2_io_portal[lcore_id].dpio_dev =3D dpaa2_get_qbman_swp(lcore_id); origin/master:drivers/bus/fslmc/portal/dpaa2_hw_dpio.c: dpaa2_get_qbman_swp(lcore_id); origin/master:drivers/bus/fslmc/rte_bus_fslmc_version.map: dpaa2_get_qbman_swp; Once fixed, I don't understand how you chose to move some symbols to INTERNAL and not others. Can you explain the differences? Finally, I would still expect a failure in the ABI check even if using __rte_internal marking. Marking them internal will make you free of changing those symbols in the future. The problem is the transient state we are in. In 20.02 (and I suppose 19.11 too), those symbols were exported and versioned as stable DPDK_20. So with the current ABI check script, this move will still be seen as a rem= oval. --=20 David Marchand