From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FB6EA04B5; Wed, 13 Jan 2021 15:52:51 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CFD2E140D93; Wed, 13 Jan 2021 15:52:50 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 1FE9E140D25 for ; Wed, 13 Jan 2021 15:52:49 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1610549568; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/v3CnmnlaUoEFSP/DLf/++JLmeF+SgZV9rvQDcDCP1M=; b=AIgDElx6l2Ppwl8d9Pp0PdTaD31LMQmJxNzWiqssPYVt+S93NXd2y++6XHHfWhitzvSGGH KvsJE+KuYCMkziI0JxX78flo7/H0hm8GlXNNje7djgSMNL0lA/LKLfjXOP2wk5weCZl7Fl vDQvTNlAZ8LpJh4qb0Rp//REllZxlEI= Received: from mail-io1-f71.google.com (mail-io1-f71.google.com [209.85.166.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-260-IhUGZsB-Oj20exe7YLi3rQ-1; Wed, 13 Jan 2021 09:52:47 -0500 X-MC-Unique: IhUGZsB-Oj20exe7YLi3rQ-1 Received: by mail-io1-f71.google.com with SMTP id x7so3308571ion.12 for ; Wed, 13 Jan 2021 06:52:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/v3CnmnlaUoEFSP/DLf/++JLmeF+SgZV9rvQDcDCP1M=; b=se587zMOEdzZlW3CF2gDB1Azrn504EjqbK90ArPu0Kka09RGMZjuCC2sY/786RpP8p DgNMH3QfSwY4FMMra++X8vIPCDEn3hRQNKZMq9Qcu3/DVPY7a4/zdjxvH+9UJFP2r2Sb iD218UEl0Ky7g5WDkD5zkvPEdUYkDIhKhxZZH7cTjy8s+OmLPGPWDFt+VxkYLGW0Wv8N kWjZO6qb95p2HgJdcXqW+sO63mV+9GXoMPX850XHmVBURazqWER0TII8c2J3x+OXpaLY eUXKsZ4AeymBhMwQW2Qba4UtU8QbjIrBLD+GTPyiMj76EU19Ey6lgx7jYmYUYAtyyjP9 vaSQ== X-Gm-Message-State: AOAM533M4S5O7KweI4bQiRk12UoXocNrmc5VDNlVL2iDNVE4i8ZILSB1 GJUOVz9GoWJFQcaSpiqgosElPVR5WeJdqWFKKw5YM8BUSQPa6s00t+G5+tia2Js46hb9u/8wZbI h6AiBv4AZD00heuCUDs8= X-Received: by 2002:a6b:dc0f:: with SMTP id s15mr2060297ioc.180.1610549566332; Wed, 13 Jan 2021 06:52:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzv8uGs76AcmOoiWpLstz8qGaQDtWBw7eeeYPqJY/2LI60Gqb8/JhfY4q36r3j9/dYPoq7wGwDZ3Kj3inHcf2g= X-Received: by 2002:a6b:dc0f:: with SMTP id s15mr2060284ioc.180.1610549566131; Wed, 13 Jan 2021 06:52:46 -0800 (PST) MIME-Version: 1.0 References: <20210108082127.1061538-1-ruifeng.wang@arm.com> In-Reply-To: <20210108082127.1061538-1-ruifeng.wang@arm.com> From: David Marchand Date: Wed, 13 Jan 2021 15:52:34 +0100 Message-ID: To: Ruifeng Wang , Vladimir Medvedkin , Bruce Richardson Cc: dev , nd , Jerin Jacob Kollanukkaran , David Christensen , Honnappa Nagarahalli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 0/4] lpm lookupx4 fixes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jan 8, 2021 at 9:22 AM Ruifeng Wang wrote: > > This series fixed bug in lpm4 vector lookup implementations. > When more than 256 tbl8 groups are created, lookupx4 could > retrieve next hop data from wrong group. > The bug is there since next_hop field was expanded from > 8-bit to 24-bit, and inherited by other implementations. This is a single issue: I would squash those 3 patches as a single patch (with 3 Fixes: tags). > > Also updated test case to improve coverage to detect such > failure. > > Ruifeng Wang (4): > lpm: fix vector lookup for Arm > lpm: fix vector lookup for x86 > lpm: fix vector lookup for ppc64 > test/lpm: improve coverage on tbl8 Reviews please? -- David Marchand