From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00F36A00C4; Thu, 29 Sep 2022 09:02:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5D2741140; Thu, 29 Sep 2022 09:02:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id D1BE540E5A for ; Thu, 29 Sep 2022 09:02:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664434940; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fvpDcFebSk9g7WTALFIcVwsuGsmmnvDi9z2IJLP5rx0=; b=StmZx2FMFvQFe8Ud0+9r5mF7XM7KmyL05O8fM8JqyjdIeWJz8T252PvtJz1cASDD8gIwGo aLoBnv8aCFhoNAXp9yhAOV48PoeGZeqX44G/hKDIKWLo3Y8OEnZqA4Qcq7ynXzbRectIAL AXlePNwQqSeHJBrdXEqlYvBBgY0rTVo= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-655-nCJ0MwVkOdu8IU2PGMfwnQ-1; Thu, 29 Sep 2022 03:02:17 -0400 X-MC-Unique: nCJ0MwVkOdu8IU2PGMfwnQ-1 Received: by mail-pj1-f70.google.com with SMTP id ru14-20020a17090b2bce00b00205cc5a4e8eso288144pjb.6 for ; Thu, 29 Sep 2022 00:02:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=fvpDcFebSk9g7WTALFIcVwsuGsmmnvDi9z2IJLP5rx0=; b=AAogow4ukqtmkUx19Hg8RhSaWHQVCIXOEQiTspXBRgoTOJ8sFqbZDBTX/bSaG/KQs/ 8m0TXgBGpAJpFsA/byQSUovDlGX8CbPGHK1r91ppYzY40RXXRpufYGXQ283adZw29/3d MfMBXh3cgQx/MhH6cP0A/yXceXQzZY4ADcESYe3XMCZLtKpadR433ywWN3Lr96mebZ6J RRdDeqEzI0JT03C9943zzYfs5jQoCgTRGpZuJLdNvPYYS+dEtHXJLbXePfH40koPbSDw L0golzzF4cXGWLsEcoBwiOl3JFS+TDGf0R8yp6lto986f6ViuJa7+TgCJoCq0iSNZTsn D70A== X-Gm-Message-State: ACrzQf3jVwEcAV0nlwxBZAouAGC6+FMCg0mlWwl6uDT/0cBOJH5z6gpG o9PNB5uVaQYmHj1LMiwpqHrINjVxjJV25/125zjq5Z6pZkySg+qrbV24JL6xr+xPfFU9ZFBCrml 9MCKMeCkznO8hEE+d3b4= X-Received: by 2002:a63:a556:0:b0:439:f022:426a with SMTP id r22-20020a63a556000000b00439f022426amr1676848pgu.120.1664434936058; Thu, 29 Sep 2022 00:02:16 -0700 (PDT) X-Google-Smtp-Source: AMsMyM51IcHq/LDCTZFpolGqVRJm4y/BU6hDrdbeSxky7AIMksjOpGezWv3LQiQWBqDuYG5p31GmU92WUjyy3PLt/q8= X-Received: by 2002:a63:a556:0:b0:439:f022:426a with SMTP id r22-20020a63a556000000b00439f022426amr1676830pgu.120.1664434935821; Thu, 29 Sep 2022 00:02:15 -0700 (PDT) MIME-Version: 1.0 References: <1654783134-13303-1-git-send-email-roretzla@linux.microsoft.com> <1656348966-10194-1-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: From: David Marchand Date: Thu, 29 Sep 2022 09:02:04 +0200 Message-ID: Subject: Re: [PATCH v4 0/6] add thread lifetime and attributes API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, dmitry.kozliuk@gmail.com, anatoly.burakov@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Sep 21, 2022 at 10:15 AM David Marchand wrote: > > On Mon, Jun 27, 2022 at 6:56 PM Tyler Retzlaff > wrote: > > > > add rte thread lifetime and attributes api. with these api additions > > there is now sufficient platform abstracted thread api to remove the > > use of pthread in the unit tests. > > > > v4: > > * update version.map to show api from series added in 22.11 instead > > of 22.07. > > Patch 1 still adds symbols in 22.07 section of the experimental block. > > Compilation is broken when stopping at patch 4. > > Newly added code can go to eal_common_thread.c rather than introduce a > new common/rte_thread.c file (or is there a rationale for this?). > > There are guards for the new structs against RTE_HAS_CPUSET being defined. > Can you elaborate why those guards are needed? > > Commitlogs / comments sentences must start with a capital letter. > > Can you prepare a new revision for -rc1? Any update? -- David Marchand