From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C83CDA057B; Tue, 14 Apr 2020 15:48:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ABD1B1C2A1; Tue, 14 Apr 2020 15:48:08 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 6A5B01C297 for ; Tue, 14 Apr 2020 15:48:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586872087; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Me5QILxnQHBXKc8xtoFZw6Ud8oUXeDVHwpYHDJKPK2w=; b=h6mbd4JK5DIG7b/9XTuTHwhs6ltrGqE2oSRYBgbFOIghz5h51amIecHsaCjGQ5FrEdo5fs lczv81O5KTZsjq89r2ruwQXTZtPECNnFI/GrP+9YFio06TbPTivQQf7guyywlYR2tpLTcZ uDmqN0tNF8V4aqkdIF/q1yqQhUmTcIc= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-337-BEbIrsO0MFKVyqgmVV-Kqg-1; Tue, 14 Apr 2020 09:48:05 -0400 X-MC-Unique: BEbIrsO0MFKVyqgmVV-Kqg-1 Received: by mail-vk1-f200.google.com with SMTP id v83so5793191vke.2 for ; Tue, 14 Apr 2020 06:48:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IvjrhbmOxeaK7JsDHq9G9c7QFDVDGb3hClh6V/ySVGA=; b=D//4FzaWXaOgCpuIQzC5qLCTeFBnocAXIXgKuGzmlXjKZxifCVwjddPtXuXjsqjU7B 65mIgQW9KMDk4nsX6Tmd/2rgmJtxAwBZOA3kw72WEP4XwJTaYY1+GcwgzAOC9PhX3B6+ 7wjMhv1YkRnYIQCDS+T1eRZv3z3wDmCD6YKiuxs97oE8SpC1TdpvudH8diu3X2xXvxic +InWBTsWMWKv05Vftzq9oq1Ox8WWd7jWaVjn02WpHXwtP3JK8NcVzqQ53ADry5WJjPIm DhC7qk94nPWjhcTA+wHvdXZmICxRb4qsCeHOqI68x6H18JlSn9hfF/IcZ/TsD/oIR5xM EpUw== X-Gm-Message-State: AGi0PuaXOQ6ww1BjUBfVr9o1S4J/TalzF4fETs8UrAAjvgE9to/ab7lC UASIHFXGGhj0UwE2QkqaaSUEcZkbNAf10uZsr5UPYvVDLJWPnhUM5n3g4EX3TVQ/qBLQHKWWvgH B2A/4JSk+X5oD5WUrKZY= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr255828uaj.41.1586872084003; Tue, 14 Apr 2020 06:48:04 -0700 (PDT) X-Google-Smtp-Source: APiQypIT628YtZO8r+l3+wscpj78ouRzhT9cNB/y44H8s2fDpnzRQlw0VeRIA0AuG3JH8l1LxCBL/Q+wBxGcbgK/FEg= X-Received: by 2002:a9f:2c87:: with SMTP id w7mr255801uaj.41.1586872083705; Tue, 14 Apr 2020 06:48:03 -0700 (PDT) MIME-Version: 1.0 References: <20200402220959.29885-1-konstantin.ananyev@intel.com> <20200403174235.23308-1-konstantin.ananyev@intel.com> <20200403174235.23308-4-konstantin.ananyev@intel.com> In-Reply-To: From: David Marchand Date: Tue, 14 Apr 2020 15:47:52 +0200 Message-ID: To: Honnappa Nagarahalli Cc: "Ananyev, Konstantin" , "dev@dpdk.org" , "jielong.zjl@antfin.com" , nd , "Kinsella, Ray" , "thomas@monjalon.net" , "jerinj@marvell.com" , Dodji Seketeli X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v3 3/9] ring: introduce RTS ring mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Honnappa, On Mon, Apr 13, 2020 at 6:42 PM Honnappa Nagarahalli wrote: > > Reviews on those structures must be extra careful, as we are blind with= those > > rules in place. > Yes, this is my concern. Why not remove these fixes and ignore the errors= manually (i.e. merge the patches knowing that they are false errors) from = libabigail? Do you know if libabigail will fix these in the future? A lot of people ignore the errors reported by the CI. I don't want to give a valid reason to ignore the reports. Dodji (libabigail maintainer) has been working on the issue. He showed me his progress last week. I don't know when the fix is ready but we can expect it before the 20.05 release. Do you expect other changes on the ring structure in this release ? --=20 David Marchand