From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3202A42932; Thu, 13 Apr 2023 13:59:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 244E74021F; Thu, 13 Apr 2023 13:59:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 57FE04014F for ; Thu, 13 Apr 2023 13:59:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681387192; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BUo2NNuBrnOB6Y52tLpjcC/1w/Gmcj1hY8Uf1lDwU2g=; b=jOtrTanp0pl3NYAISUVVNTOu3NeXUIGJni6IQNZ+YVrF7DLt6xrMiBYV5iLuYmQhHxCzFs zT8bXa5FlUVQx+9w5lkqKv92LFX2uplBf9mWMns6qqlrblsvwhqi2aJJ1EwhWdmsliZYaM XFxD/PqbYqL71Wj7cHxdKRQJnTC/q+Y= Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-358-hiiLEP52PYmvcAlFpQmY8g-1; Thu, 13 Apr 2023 07:59:51 -0400 X-MC-Unique: hiiLEP52PYmvcAlFpQmY8g-1 Received: by mail-pg1-f200.google.com with SMTP id bs190-20020a6328c7000000b00513efd36285so11424305pgb.17 for ; Thu, 13 Apr 2023 04:59:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681387190; x=1683979190; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BUo2NNuBrnOB6Y52tLpjcC/1w/Gmcj1hY8Uf1lDwU2g=; b=ZzVz++HNT/6mtOpWhlMhZuRwIQWTD4JilQmwHNuTkQ/HYPgN3gVMoutENzNgLnwfpf 9U4IDtIj355A1NZ7cwa8bfkKBLWlEK+QleJ20Yd6LDwI12DKdln/PVbAtwtQWB8V/2od Le2pWpmXbwJ6r54XwrsfDdKwDo1m0PU2+gIShDgkdmpkI0d2FF5rDxUl5qY/3RD+DWv2 aJovXaXNNnNyx2YFCDB7bpmSi/l01ZxPrP+WBt4AecviG0Ob8ls++2WRufMrARSaW2sd 2+aHMJCjksvgbUlorQtBfHpdvKvvDeB1ikteeId5da+nTjLp2pJ5YhMo7CsHyu+LJVoM nTDw== X-Gm-Message-State: AAQBX9fM3LCqSBn97Q/5UgbGP8YOEsPUjlYapsseHTFFBA5iq4tkfjIF Cu9a+Wk/FtgivdG5Gx4mYeAeAcj77fBfbKdLnl4/Aqc9rwZnFId+IVE11uSLJiBr17+WVmRv8g7 F6ujHi+rI5bkk6HFZ7zk= X-Received: by 2002:a17:90a:12c6:b0:233:cc2c:7dae with SMTP id b6-20020a17090a12c600b00233cc2c7daemr428370pjg.8.1681387190466; Thu, 13 Apr 2023 04:59:50 -0700 (PDT) X-Google-Smtp-Source: AKy350aIgMAn5NRrSgYaMRvm78Ms/bo3BTN6KHSlBKXcqoGE9biRQpy2YXHvaKkuMfgYuwTAS9Q23LdzenXjIzR/qHM= X-Received: by 2002:a17:90a:12c6:b0:233:cc2c:7dae with SMTP id b6-20020a17090a12c600b00233cc2c7daemr428359pjg.8.1681387190139; Thu, 13 Apr 2023 04:59:50 -0700 (PDT) MIME-Version: 1.0 References: <20230413115334.43172-1-sivaprasad.tummala@amd.com> In-Reply-To: <20230413115334.43172-1-sivaprasad.tummala@amd.com> From: David Marchand Date: Thu, 13 Apr 2023 13:59:39 +0200 Message-ID: Subject: Re: [PATCH v2 1/3] eal: add x86 cpuid support for monitorx To: Sivaprasad Tummala Cc: david.hunt@intel.com, dev@dpdk.org, Thomas Monjalon , "Burakov, Anatoly" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Apr 13, 2023 at 1:54=E2=80=AFPM Sivaprasad Tummala wrote: > > Add a new CPUID flag to indicate support for monitorx instruction > on AMD Epyc processors. > > Signed-off-by: Sivaprasad Tummala > --- > lib/eal/include/generic/rte_cpuflags.h | 2 ++ > lib/eal/x86/include/rte_cpuflags.h | 1 + > lib/eal/x86/rte_cpuflags.c | 3 +++ > 3 files changed, 6 insertions(+) > > diff --git a/lib/eal/include/generic/rte_cpuflags.h b/lib/eal/include/gen= eric/rte_cpuflags.h > index d35551e931..db653a8dd7 100644 > --- a/lib/eal/include/generic/rte_cpuflags.h > +++ b/lib/eal/include/generic/rte_cpuflags.h > @@ -26,6 +26,8 @@ struct rte_cpu_intrinsics { > /**< indicates support for rte_power_pause function */ > uint32_t power_monitor_multi : 1; > /**< indicates support for rte_power_monitor_multi function */ > + uint32_t amd_power_monitorx : 1; > + /**< indicates amd support for rte_power_monitor function */ I did not look at the patch detail, I just stopped at this part. What makes the AMD monitorx stuff special that it needs to be exposed in the generic API? --=20 David Marchand