From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A1A4742662; Thu, 28 Sep 2023 16:42:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C6540273; Thu, 28 Sep 2023 16:42:27 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C77BC4021D for ; Thu, 28 Sep 2023 16:42:25 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695912145; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ynnre/+unUP8x4xnm81NYpvB4gKo/Yn/6j73bAZaFdk=; b=O644c7XDbMbfHy5BtlKY7KiFImGmNHoVTz7uCa0udBP3vlmkpuVCSBgAB8bV5zGuC3dx09 w92G+RyZu1AhqzQWka89q9yPPmJULToS70N43G2zAVBgfb6a2ZsYbi4Kp7Z0oNjU7hMCWX Ug89IQv2Bie1uluJFgr6b96ome7eWFY= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-32-apCASF50NpCCsX5-62BQsA-1; Thu, 28 Sep 2023 10:42:23 -0400 X-MC-Unique: apCASF50NpCCsX5-62BQsA-1 Received: by mail-lf1-f72.google.com with SMTP id 2adb3069b0e04-504319087d9so18174009e87.1 for ; Thu, 28 Sep 2023 07:42:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695912142; x=1696516942; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ynnre/+unUP8x4xnm81NYpvB4gKo/Yn/6j73bAZaFdk=; b=XE4YXWG3se1Zd+s7nxd5L509bIw+3EhsGOG3cdsNBtiwrBAoyK5/LFZPE3WuAx3ydc qrH6BKgLBEJkaBsb+2KYM5ik8zY9FROA+irq33Lbefy3Ucsf1/5FVrK45vU+spQzCjtN GJ+xTssCitAXadNyXc1WhdtyHP9kGenmgESV+7EgnA18o+pIjvE2ogOTVmqr6cWGXzeO V9WbPtr4Iy/0ca0HLxUzYNnF9O9SnCZyGCBQu8jfiDYRRqqT9qROZxLMnnPi2CU7FGMG 90qokhPUZftckOXPynMPeiKl8TDebaLVKECcPkccE84RN22eqhW1upzLGHlvYvLZTZS+ b2ZA== X-Gm-Message-State: AOJu0YwPEhAbjjiGI/+JFhUEQ+EFZCy6a9JemM1RkK2FQ/ZGThv24dvW Pv2aG0YyiRu2AbS1FOGtmBtekQDz+U1owRaWaGLuTa3+eHgO5AqsTcAjI4agh/gMftFpdtAgl+R wLm17G95Ps13OPMiPXwFkCJ4D3t0= X-Received: by 2002:a19:6549:0:b0:500:acf1:b432 with SMTP id c9-20020a196549000000b00500acf1b432mr1314575lfj.63.1695912142168; Thu, 28 Sep 2023 07:42:22 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGRO///qdCEOBzz5wW4lyh1uvY6FDWhVvrI62o+dh5DQa5BL6joVZn+xjW/s1BqmwhT0LEflykGFgg4/IwKhvc= X-Received: by 2002:a19:6549:0:b0:500:acf1:b432 with SMTP id c9-20020a196549000000b00500acf1b432mr1314561lfj.63.1695912141818; Thu, 28 Sep 2023 07:42:21 -0700 (PDT) MIME-Version: 1.0 References: <20230928092639.162449-1-bruce.richardson@intel.com> <20230928110450.862698-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Thu, 28 Sep 2023 16:42:10 +0200 Message-ID: Subject: Re: [EXT] Re: [PATCH 1/2] app/test: add support for optional dependencies To: Bruce Richardson Cc: Akhil Goyal , "dev@dpdk.org" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 28, 2023 at 3:06=E2=80=AFPM Akhil Goyal wr= ote: > > > Some tests make optionally use a component but don't require it for > > > > s/make // > > > > > building. If we include the dependency in the per-file lists, then te= sts > > > may be unnecessarily omitted, as the dependency is not required. > > > On the other hand, removing the optional dependency from the list can > > > cause build failures, as the test case may include the optional code, > > > but then fail to build as the build system won't have added the neces= sary > > > paths for header inclusion, or the necessary libraries for linking. > > > > > > Resolve this by explicitly providing a list of optional dependencies. > > > Any items in this list will be added to the dependency list if > > > available, but otherwise won't be involved in enable/disable of speci= fic > > > tests. > > > > > > Signed-off-by: Bruce Richardson > > Reviewed-by: David Marchand > Tested-by: Akhil Goyal Series applied, thanks for the quick fix Bruce. --=20 David Marchand