From: David Marchand <david.marchand@redhat.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: dev <dev@dpdk.org>, "Xia, Chenbo" <chenbo.xia@intel.com>
Subject: Re: [dpdk-dev] [PATCH v7 0/7] vhost: Fix and improve NUMA reallocation
Date: Wed, 30 Jun 2021 09:57:22 +0200 [thread overview]
Message-ID: <CAJFAV8xg74Q12orbtvbuPS=FV_n=gQyT88uDRLAN46dZmzMQcQ@mail.gmail.com> (raw)
In-Reply-To: <20210629161133.79472-1-maxime.coquelin@redhat.com>
On Tue, Jun 29, 2021 at 6:11 PM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This patch series first fixes missing reallocations of some
> Virtqueue and device metadata.
>
> Then, it improves the numa_realloc function by using
> rte_realloc_socket API that takes care of the memcpy &
> freeing. The VQs NUMA IDs are also saved in the VQ metadata
> and used for every allocations so that all allocations
> before NUMA realloc are on the same VQ, later ones are
> allocated on the proper one.
>
> Finally inflight feature metada are converted from calloc()
> to rte_zmalloc_socket() and their reallocation is handled
> in numa_realloc().
>
Series lgtm with some little nits.
Thanks Maxime!
--
David Marchand
next prev parent reply other threads:[~2021-06-30 7:57 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-29 16:11 Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 1/7] vhost: fix missing memory table NUMA realloc Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 2/7] vhost: fix missing guest pages " Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 3/7] vhost: fix missing cache logging " Maxime Coquelin
2021-06-30 5:20 ` Xia, Chenbo
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 4/7] vhost: fix NUMA reallocation with multiqueue Maxime Coquelin
2021-06-30 5:20 ` Xia, Chenbo
2021-06-30 7:24 ` David Marchand
2021-06-30 7:47 ` Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 5/7] vhost: improve NUMA reallocation Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 6/7] vhost: allocate all data on same node as virtqueue Maxime Coquelin
2021-06-29 16:11 ` [dpdk-dev] [PATCH v7 7/7] vhost: convert inflight data to DPDK allocation API Maxime Coquelin
2021-06-30 5:20 ` Xia, Chenbo
2021-06-30 7:55 ` David Marchand
2021-06-30 11:16 ` Maxime Coquelin
2021-06-30 7:57 ` David Marchand [this message]
2021-06-30 11:53 ` [dpdk-dev] [PATCH v7 0/7] vhost: Fix and improve NUMA reallocation Xia, Chenbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xg74Q12orbtvbuPS=FV_n=gQyT88uDRLAN46dZmzMQcQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).