From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 280F5A0A0F; Wed, 30 Jun 2021 09:57:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0BB2540141; Wed, 30 Jun 2021 09:57:40 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 6B17C40040 for ; Wed, 30 Jun 2021 09:57:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1625039856; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xHHCUYB92RqNU+v/1dQEpic2MxfbLgm3jF2TlHrNRiQ=; b=gqSlM2SscivwCWYPlt+sLYEN/+HMkZU8an/pNj0B7mW7BaUbrkH/VbxXYNrhrFumlhvyUY rUwOZ85bSHegVqn2ZgS3LRBLx0pincdnSCnKicSWEK7FVsN+NYKGjCc9azeTah01V2INZH VsAzqnz6HaextdRstWWPN/b8c7R5HRY= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-XmJlrT9bMyGOAz8mG5rpVg-1; Wed, 30 Jun 2021 03:57:34 -0400 X-MC-Unique: XmJlrT9bMyGOAz8mG5rpVg-1 Received: by mail-vs1-f70.google.com with SMTP id n124-20020a6772820000b029026ec17d2dd5so683298vsc.20 for ; Wed, 30 Jun 2021 00:57:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xHHCUYB92RqNU+v/1dQEpic2MxfbLgm3jF2TlHrNRiQ=; b=Mf+qMf3BLHaAbyM8ZYMni4HM4G8xAFhRV7D/IV10K1UUWnEjd62HZ2RX5432AAkq6I i6+aOYTNQoertPlX7vbVSPnTOGWIyXsXROoTU/2JZ7eQTG6lxnOTPX5gnt7GUQuhM0MI QO+bMaAzkPsQUnQPv1cFQnS8wSwwyJFUT/2TKVp1Gde/GAAXtnA44iPepYJZBvwB6zbV qWKDSwZSjQXu2FyaRKPofVd0nzzVctTscJ0ne8k0X6xAlHNoX+he/LKzo0o2XS1Fxnzl o9vxseskOLq83kXXYKqrc++y5QoUUOIgqUG6Fbh/0Mbh5kpb9hj50GxZtMgzzFXXbTZv Meag== X-Gm-Message-State: AOAM532I6zfHeshoMqGNxcuBro5+BABny77epRF2aXtm1mNChuH2GtCz DoEgVCDhfR39NqUMEgNuTW/AwqpkCXHlXkLRM45/vWSrtSeeWxOGbTR3nfDiGJNXAMc8mDvPWMF wJyZJ4cmxRbTVa8fE6JU= X-Received: by 2002:ab0:996:: with SMTP id x22mr31818278uag.53.1625039854321; Wed, 30 Jun 2021 00:57:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwl2DUVfaZUGQy5ZNJf5tOcdTfgeKAw9NFfgoONOT0CLrx9eak6fh4OvNvRzzqxTHgiF50hjmJxrtICnZH/yYs= X-Received: by 2002:ab0:996:: with SMTP id x22mr31818270uag.53.1625039854169; Wed, 30 Jun 2021 00:57:34 -0700 (PDT) MIME-Version: 1.0 References: <20210629161133.79472-1-maxime.coquelin@redhat.com> In-Reply-To: <20210629161133.79472-1-maxime.coquelin@redhat.com> From: David Marchand Date: Wed, 30 Jun 2021 09:57:22 +0200 Message-ID: To: Maxime Coquelin Cc: dev , "Xia, Chenbo" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v7 0/7] vhost: Fix and improve NUMA reallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jun 29, 2021 at 6:11 PM Maxime Coquelin wrote: > > This patch series first fixes missing reallocations of some > Virtqueue and device metadata. > > Then, it improves the numa_realloc function by using > rte_realloc_socket API that takes care of the memcpy & > freeing. The VQs NUMA IDs are also saved in the VQ metadata > and used for every allocations so that all allocations > before NUMA realloc are on the same VQ, later ones are > allocated on the proper one. > > Finally inflight feature metada are converted from calloc() > to rte_zmalloc_socket() and their reallocation is handled > in numa_realloc(). > Series lgtm with some little nits. Thanks Maxime! -- David Marchand