From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5AD01A0563; Mon, 23 Mar 2020 10:31:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0D7501C067; Mon, 23 Mar 2020 10:31:03 +0100 (CET) Received: from us-smtp-delivery-74.mimecast.com (us-smtp-delivery-74.mimecast.com [216.205.24.74]) by dpdk.org (Postfix) with ESMTP id 4E8F91C067 for ; Mon, 23 Mar 2020 10:31:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584955860; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Lo2iwJYp3ZEvuR3sR+4WuyGfcM5JpSUrtl+ouBCfwEQ=; b=GSs8fTd8Zq8ctRiqiDrv/S6Bi03kr/SnhLKWslIEH1Qnvtgx6mIbfZmci79lRC1t3VZ5N3 p1c7gbtuhw632qvnSobi4HiWj43v0v7UPYXH2oHYlWHTOFHT5+lNioRuFF+HikTUJXKTU0 ofDABrLvOd3Z7j8g4lxYppORDoS9wBU= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-399-6x2UjW2fNxSG5hKDqIXIeg-1; Mon, 23 Mar 2020 05:30:57 -0400 X-MC-Unique: 6x2UjW2fNxSG5hKDqIXIeg-1 Received: by mail-vk1-f199.google.com with SMTP id v83so1439317vke.2 for ; Mon, 23 Mar 2020 02:30:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vC22cvXwMg2bMv1q+P1tRa6Pg6DHEamgkq45X0KMND4=; b=oXgXsAOohiGROByBwv8e6p365Htmb2zCW8DLr3qq/0HJicT6Sgn/YkT3jKuavX7jgr l8actN1yz9O3b1jMHAq4zJDpZhTIyOl4WsU/BNhfeCq4NTJ6MqY6kU6XdH6zLRPAGMk7 LRBwM2nyzjGVkAYu/Dy6km/70x15mODfM6eZW0igQo4fAfPX6x4L7XAuWkMJUprhuYYy oE/TLUeqQVbYp1lMl5018XM2hnAOJxyqf7GR8pLADe2scTMJTVQWOymqkgfzWi0eiYw7 vD0stw8v3T8nwiXUd4Fb+kvrff46kCaFl4EwmwuuOvRfAhSU3WTrxeDEmyOJxkA6l+DC tXGA== X-Gm-Message-State: ANhLgQ3xO0iNewqRzabzmkkRiU4Txl9g1wwqKZ0mEJdDvQcThcIi3j64 Zrbqdzgmv2IzQQMo2U0dozlg5lvI9EW1cWxua/s7pc1bTDmxpf+et4Drc1hlzucPvFGlG9HwBKQ mVLjFebuxHzqsRbM9I8U= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12802013uad.87.1584955856641; Mon, 23 Mar 2020 02:30:56 -0700 (PDT) X-Google-Smtp-Source: ADFU+vuDvXgQpgDfqW9EMiTCd7H+qDMhIaUgJQ5x7HG0o13+TjkIvExb+JZv+soAHqSTeFDGvKwMJ35I1UwwsmctaYo= X-Received: by 2002:a9f:2204:: with SMTP id 4mr12802000uad.87.1584955856316; Mon, 23 Mar 2020 02:30:56 -0700 (PDT) MIME-Version: 1.0 References: <20200319144418.15661-1-ndabilpuram@marvell.com> <20200323092809.GA16547@outlook.office365.com> In-Reply-To: <20200323092809.GA16547@outlook.office365.com> From: David Marchand Date: Mon, 23 Mar 2020 10:30:45 +0100 Message-ID: To: Nithin Dabilpuram Cc: Thomas Monjalon , Neil Horman , dev , Jerin Jacob Kollanukkaran , dpdk stable , bingz@mellanox.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [EXT] Re: [PATCH] devtools: fix check symbol change script X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Mar 23, 2020 at 10:28 AM Nithin Dabilpuram wrote: > On Mon, Mar 23, 2020 at 09:13:22AM +0100, David Marchand wrote: > > ---------------------------------------------------------------------- > > On Thu, Mar 19, 2020 at 3:44 PM Nithin Dabilpuram > > wrote: > > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-= change.sh > > > index c5434f3..19ce82f 100755 > > > --- a/devtools/check-symbol-change.sh > > > +++ b/devtools/check-symbol-change.sh > > > @@ -17,13 +17,13 @@ build_map_changes() > > > # map files are altered, and all section/symbol names > > > # appearing between a triggering of this rule and the > > > # next trigger of this rule are associated with this = file > > > - /[-+] a\/.*\.map/ {map=3D$2; in_map=3D1} > > > + /[-+] [ab]\/.*\.map/ {map=3D$2; in_map=3D1} > > > > > > # Same pattern as above, only it matches on anything = that > > > # does not end in 'map', indicating we have left the = map chunk. > > > # When we hit this, turn off the in_map variable, whi= ch > > > # supresses the subordonate rules below > > > - /[-+] a\/.*\.[^map]/ {in_map=3D0} > > > + /[-+] [ab]\/.*\.[^map]/ {in_map=3D0} > > > > [^map] does not mean "not word map" but actually "none of the > > character m, a or p". > > > > So potentially, any file extension starting with m, a or p could > > trigger an issue. > > For example, a change in .mk files, .py files and > > ./devtools/check-forbidden-tokens.awk ./devtools/libabigail.abignore > > could lead to incorrect symbol check. > > > > How about the following change: > > > > diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-ch= ange.sh > > index c5434f3bb0..ed2178e36e 100755 > > --- a/devtools/check-symbol-change.sh > > +++ b/devtools/check-symbol-change.sh > > @@ -17,13 +17,11 @@ build_map_changes() > > # map files are altered, and all section/symbol names > > # appearing between a triggering of this rule and the > > # next trigger of this rule are associated with this fi= le > > - /[-+] a\/.*\.map/ {map=3D$2; in_map=3D1} > > + /[-+] [ab]\/.*\.map/ {map=3D$2; in_map=3D1; next} > > > > - # Same pattern as above, only it matches on anything th= at > > - # does not end in 'map', indicating we have left the ma= p chunk. > > - # When we hit this, turn off the in_map variable, which > > - # supresses the subordonate rules below > > - /[-+] a\/.*\.[^map]/ {in_map=3D0} > > + # The previous rule catches all .map files, anything el= se > > + # indicates we left the map chunk. > > + /[-+] [ab]\// {in_map=3D0} > > > > # Triggering this rule, which starts a line and ends it > > # with a { identifies a versioned section. The section= name is > > > > > > Agreed. I tested and it works fine for me. I can send a V2 with this chan= ge if it is fine. Sure, thanks! --=20 David Marchand