From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAE88A0A05; Tue, 19 Jan 2021 13:15:22 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C5CAF140DE2; Tue, 19 Jan 2021 13:15:22 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5AB60140E01 for ; Tue, 19 Jan 2021 13:15:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611058520; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=gzlJit17T5408bXEEd9rtduQZRdmDiUX7AqILn0Tbeo=; b=Jb2OH6XAbroOp4f2szRm9YWcuezcfh3mY6XlRP4wxxiwDisQKSxvqfjiD185qEV3gHQwTU Y0bb1I8eCKlFyxsBOaz2uPejBwdcI+gi04FytsjLTMOP+9MOR0uWkYsTiIh0SXFQFNIB2d OfzkLVS800dQNuxx5wNp0R2p5WDHysc= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-175-w22hubsYMmiaENv61NHrjA-1; Tue, 19 Jan 2021 07:15:17 -0500 X-MC-Unique: w22hubsYMmiaENv61NHrjA-1 Received: by mail-vk1-f198.google.com with SMTP id k192so10552539vkk.9 for ; Tue, 19 Jan 2021 04:15:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gzlJit17T5408bXEEd9rtduQZRdmDiUX7AqILn0Tbeo=; b=F2T3BRXhu3hjZTnJbrwy0lDISse0hBeWvgpQnCTYKQ22MxOYNqhHCvCrO254zUWf49 R6T/JQOKE33iw59y6hl2kQspMFGPmEIatt2e3wYVJXOquwfTAFoA2YGTV5qJ0TZR23HN f+OSxa3pX2C/45B9FBBEmxxRCINoQ/2knF6eTEX4zVHi2J2jZYpETlSL9swerezUn/Uk rgBC3WccAcAPqF96EhSLgQFcdtbPNlr8ugbDqQCkHf14p0YNVmfyr/GHYnC5cFtXg3dS jbE+GH+ZPDHbFqAtJQ3OsoR47yxkYK5Y0J0Tg8CWpg4jQmD0cpGfALGsLLvzdj0AzWLF E0/Q== X-Gm-Message-State: AOAM5308ODLK13yy3Utd8WZy2X2Y0qWl4Ps5w37Xs3k2rrnvQYVgAoyu sQfdZqSn4SWDi2NICYr0DrT9y9JEeuth3UDGTiNdrRcLDRNBo1rkQhCX2xkUMz7GnoWT8JkpLdk kUxik5PrG5dN0e93B5+M= X-Received: by 2002:a67:3093:: with SMTP id w141mr2395083vsw.27.1611058515895; Tue, 19 Jan 2021 04:15:15 -0800 (PST) X-Google-Smtp-Source: ABdhPJzLAF3XbJZJgbnGFTScnVArAPcfzsjz29z1QkUuHpFDIPGc/JkAPCwsZMjSG3EKkeKGZWTLIhOjMGp8RiT9Ino= X-Received: by 2002:a67:3093:: with SMTP id w141mr2395076vsw.27.1611058515640; Tue, 19 Jan 2021 04:15:15 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Tue, 19 Jan 2021 13:15:04 +0100 Message-ID: To: Anatoly Burakov Cc: dev , dpdk stable Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] fbarray: fix incorrect overlap check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 14, 2021 at 4:03 PM Anatoly Burakov wrote: > > When we're attaching fbarrays in secondary processes, we check for > whether the intended memory address for the fbarray is already in use by > some other, local fbarray. However, the check for end-overlap (i.e. to > see if our memory area's end overlaps with some other fbarray) is > incorrectly counting end offset as part of the overlap. Fix the check. > > Fixes: 5b61c62cfd76 ("fbarray: add internal tailq for mapped areas") > Cc: stable@dpdk.org > > Signed-off-by: Anatoly Burakov Tested-by: Zhihong Peng Applied. -- David Marchand