From: David Marchand <david.marchand@redhat.com>
To: Ashish Gupta <ashish.gupta@marvell.com>,
Bruce Richardson <bruce.richardson@intel.com>
Cc: dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>
Subject: Dead code in compress/octeontx ?
Date: Wed, 10 Nov 2021 17:28:17 +0100 [thread overview]
Message-ID: <CAJFAV8xgy6ZGTog4btnnJqk2NKOmVntki06c8Xop=tu+wSc9jg@mail.gmail.com> (raw)
Looking at drivers/compress/octeontx/meson.build:
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Cavium, Inc
if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
build = false
reason = 'only supported on 64-bit Linux'
subdir_done()
endif
sources = files('otx_zip.c', 'otx_zip_pmd.c')
includes += include_directories('include')
deps += ['mempool_octeontx', 'bus_pci']
ext_deps += dep
We have a reference to a "dep" token for external dependencies.
But. I see no dep variable defined in this file.
Correct me if I am wrong, but I understand this driver meson.build
inherits some dep variable that was previously set evaluating other
meson.build in dpdk.
If this is the case, I guess we can drop it.
--
David Marchand
reply other threads:[~2021-11-10 16:28 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xgy6ZGTog4btnnJqk2NKOmVntki06c8Xop=tu+wSc9jg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=ashish.gupta@marvell.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).