DPDK patches and discussions
 help / color / mirror / Atom feed
* Dead code in compress/octeontx ?
@ 2021-11-10 16:28 David Marchand
  0 siblings, 0 replies; only message in thread
From: David Marchand @ 2021-11-10 16:28 UTC (permalink / raw)
  To: Ashish Gupta, Bruce Richardson; +Cc: dev, Thomas Monjalon

Looking at drivers/compress/octeontx/meson.build:
# SPDX-License-Identifier: BSD-3-Clause
# Copyright(c) 2018 Cavium, Inc

if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
    build = false
    reason = 'only supported on 64-bit Linux'
    subdir_done()
endif

sources = files('otx_zip.c', 'otx_zip_pmd.c')
includes += include_directories('include')
deps += ['mempool_octeontx', 'bus_pci']
ext_deps += dep


We have a reference to a "dep" token for external dependencies.
But. I see no dep variable defined in this file.

Correct me if I am wrong, but I understand this driver meson.build
inherits some dep variable that was previously set evaluating other
meson.build in dpdk.

If this is the case, I guess we can drop it.


-- 
David Marchand


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2021-11-10 16:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 16:28 Dead code in compress/octeontx ? David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).