From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F919A034F; Wed, 10 Nov 2021 17:28:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 790294068B; Wed, 10 Nov 2021 17:28:34 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C0DAB40683 for ; Wed, 10 Nov 2021 17:28:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1636561713; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=6kQUIki8ZQdGktW8CLntUiHxI3mkPjWmabRc27OrmuM=; b=hDwqrhUdrjySPR/4wXqgqgz2Pld0Qfkv/PoMpeW1uhrJNigIqBLZY+qcWOccXQNmNTKWX7 UUaKt+UHAPYjtcun3bynmuAWp0K/JTV0qF8dkp7k536in3/eNyXzRdQzelVa0aHBMEAlbT V0bpyEKvkBaketpjejGVjrM66iWJg7Q= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-375-IGBv3yOgMZizDts9NUUvGQ-1; Wed, 10 Nov 2021 11:28:29 -0500 X-MC-Unique: IGBv3yOgMZizDts9NUUvGQ-1 Received: by mail-lj1-f197.google.com with SMTP id l9-20020a2e8349000000b00218c7c981bcso829107ljh.8 for ; Wed, 10 Nov 2021 08:28:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=6kQUIki8ZQdGktW8CLntUiHxI3mkPjWmabRc27OrmuM=; b=v5oim3VLEjf/bom+OgvVSkktZu8l5/14cuWY5O14c+c7tVZRLovWbVgpxfYzvOpHrv wwVYZ41BVQRNkHlKChnzqL9UZvxU3RzqakbS9YV9dJm/Y+9uaYPhmQfYK2k/idctQUop bv/siQjndIcJveM9xWjc75fj3QHILpt+k5+VxRYjXCbaDUe2ogLgzJ3Ykxf1PmeQ8mJ9 9a/rPWjOzfq3AJk+cEJfAarno6a28ykbpFpwd02ddXMjWlrAuADKY4D33Ko7IjZ1UNdz cUjYM+S1IMwXVee6yoPi20F0swl3KsohWybVHIt1I5yGyiZPGdLe3vCH+hCOgrW4kwny zu/A== X-Gm-Message-State: AOAM531InA/cAUobxhtQD356V8GbZbOLRWIDUhv5QOO/KelgR2CH8cNS E/7dhp82tztK0HiaMPlT3qwZY+ADaYNDzERaYmP8Dm6MmfOYUJm5hriPmbv9Bd5isf7fpi7BX1C nYbojC9dRW4Qt5x3Nr+Y= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr330198lfv.560.1636561708051; Wed, 10 Nov 2021 08:28:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzfIJq528dQLsvlc3G81cVKynqISRW+KFaPPNwBa541kp2Og45cUbWMuS3atWQoq8C5J5nbOpSpbW80ddDiVqQ= X-Received: by 2002:a05:6512:3e11:: with SMTP id i17mr330185lfv.560.1636561707889; Wed, 10 Nov 2021 08:28:27 -0800 (PST) MIME-Version: 1.0 From: David Marchand Date: Wed, 10 Nov 2021 17:28:17 +0100 Message-ID: Subject: Dead code in compress/octeontx ? To: Ashish Gupta , Bruce Richardson Cc: dev , Thomas Monjalon Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Looking at drivers/compress/octeontx/meson.build: # SPDX-License-Identifier: BSD-3-Clause # Copyright(c) 2018 Cavium, Inc if not is_linux or not dpdk_conf.get('RTE_ARCH_64') build = false reason = 'only supported on 64-bit Linux' subdir_done() endif sources = files('otx_zip.c', 'otx_zip_pmd.c') includes += include_directories('include') deps += ['mempool_octeontx', 'bus_pci'] ext_deps += dep We have a reference to a "dep" token for external dependencies. But. I see no dep variable defined in this file. Correct me if I am wrong, but I understand this driver meson.build inherits some dep variable that was previously set evaluating other meson.build in dpdk. If this is the case, I guess we can drop it. -- David Marchand