DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: dev <dev@dpdk.org>
Cc: Thomas Monjalon <thomas@monjalon.net>,
	Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
	 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
	Dmitry Malloy <dmitrym@microsoft.com>,
	 Pallavi Kadam <pallavi.kadam@intel.com>,
	Ray Kinsella <mdr@ashroe.eu>,
	 Neil Horman <nhorman@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file
Date: Tue, 6 Apr 2021 18:40:37 +0200
Message-ID: <CAJFAV8xh4TBK9CTUrmN__wYd17cjmW2haTcCESYumQQfPK5oQQ@mail.gmail.com> (raw)
In-Reply-To: <20210406163231.19663-1-david.marchand@redhat.com>

On Tue, Apr 6, 2021 at 6:33 PM David Marchand <david.marchand@redhat.com> wrote:
> diff --git a/buildtools/map_to_win.py b/buildtools/map_to_win.py
> index 2a6cb88605..34434d96fa 100644
> --- a/buildtools/map_to_win.py
> +++ b/buildtools/map_to_win.py
> @@ -7,7 +7,7 @@
>
>
>  def is_function_line(ln):
> -    return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln
> +    return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln and "# WINDOWS_NO_EXPORT" not in ln
>
>  # MinGW keeps the original .map file but replaces per_lcore* to __emutls_v.per_lcore*
>  def create_mingw_map_file(input_map, output_map):
> @@ -24,12 +24,6 @@ def main(args):
>          create_mingw_map_file(args[1], args[2])
>          return 0
>
> -# special case, allow override if an def file already exists alongside map file
> -    override_file = join(dirname(args[1]), basename(args[2]))
> -    if exists(override_file):
> -        with open(override_file) as f_in:
> -            functions = f_in.readlines()
> -

Forgot to clean associated python imports.
Will be fixed in a v2 if no objection is raised on the principle of the patch.


>  # generate def file from map file.
>  # This works taking indented lines only which end with a ";" and which don't
>  # have a colon in them, i.e. the lines defining functions only.


-- 
David Marchand


  reply	other threads:[~2021-04-06 16:40 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-06 16:32 David Marchand
2021-04-06 16:40 ` David Marchand [this message]
2021-04-06 16:50 ` Bruce Richardson
2021-04-06 16:53   ` David Marchand
2021-04-07 20:06   ` Kinsella, Ray
2021-04-06 17:59 ` [dpdk-dev] [PATCH v2] " David Marchand
2021-04-06 18:52   ` Thomas Monjalon
2021-04-06 20:09     ` David Marchand
2021-04-06 22:39       ` Thomas Monjalon
2021-04-07  8:16       ` David Marchand
2021-04-07  8:53         ` Dmitry Kozlyuk
2021-04-07  8:57           ` Thomas Monjalon
2021-04-07 11:38             ` Tal Shnaiderman
2021-04-08 14:51   ` Thomas Monjalon
2021-04-08 16:11   ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xh4TBK9CTUrmN__wYd17cjmW2haTcCESYumQQfPK5oQQ@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=dmitry.kozliuk@gmail.com \
    --cc=dmitrym@microsoft.com \
    --cc=mdr@ashroe.eu \
    --cc=navasile@linux.microsoft.com \
    --cc=nhorman@tuxdriver.com \
    --cc=pallavi.kadam@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git