From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3352A0546; Tue, 6 Apr 2021 18:40:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52207140FB8; Tue, 6 Apr 2021 18:40:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id C8EBA40F35 for ; Tue, 6 Apr 2021 18:40:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617727251; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kj5ob27gYf7wLll5z4ejo3AM3P0gzDmfVQPlK/X+Vpc=; b=Zg1SHXuUYcs0LA0c8U8W+OT9ACGeKqmXQtj5s67gbEWq1z0cE5vk7SFa8thymlBJEJOXtz D5NznPEHUMVhzS4aRPfukJINJt+6tK0iO+PGA2DYQ8gL/PdW9r6NWYvUTJ2VZUkzXnA5jB o1ZzPnVCN3DzmVJzzYlCCUxGkb5rmh8= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-fgLOwcGaOJSGVTXEHtZs5A-1; Tue, 06 Apr 2021 12:40:49 -0400 X-MC-Unique: fgLOwcGaOJSGVTXEHtZs5A-1 Received: by mail-vk1-f198.google.com with SMTP id q15so5261133vkd.1 for ; Tue, 06 Apr 2021 09:40:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kj5ob27gYf7wLll5z4ejo3AM3P0gzDmfVQPlK/X+Vpc=; b=EXiOyTv64eTkpdjpxnBtwQSbgtlxMa32wr0r0InTpgy88zKAFSVTiZOW93f2z7T2Ma U3L86joXYYrVrU2CmzK2fgQTcn2TqI2ToHZhUOMT/9Ir9xrCbZzJCUyVRUbrYieUDTXX fq1iZPgtZdOagNuXGLFQnH9SqVwgALjS4RPLOc5+a2kBhjkOtB2njqTYax2tckBR9nI1 u6xWM78r/bjG4enDSeaWJO8329lqfOa2hOnf5kF0FHLZQlVh0C0/6TvUM2GZupx69fPx 2sWPZyN6u+fOugiVccmYixd5mqga5/YzVwW1kdOv3fPCNjnf4ifNCc6dvFP2j7VgGvHz IeMA== X-Gm-Message-State: AOAM531dozKF2gD9uuJEK8iP61A8RDg+l6717frGq6E4+92L5r4TiRhP 0rfV5G7Vviwxxz0qGIEGE1fFMMrqkFWxOlMhiiQfhrXak2wn44AiK6KKPw64JLIKtwTtuzuWWmJ vAPYnWvWYeWC10KSLhnQ= X-Received: by 2002:a67:f557:: with SMTP id z23mr4294052vsn.27.1617727249052; Tue, 06 Apr 2021 09:40:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx5JvKebdz3yFAU/EQgCPpq/FeY1YyMOXg4EE8oa485Pq87YJgxkhe/F1sVghIAQEBehdEHYuMA+zpcxnut5mg= X-Received: by 2002:a67:f557:: with SMTP id z23mr4294031vsn.27.1617727248819; Tue, 06 Apr 2021 09:40:48 -0700 (PDT) MIME-Version: 1.0 References: <20210406163231.19663-1-david.marchand@redhat.com> In-Reply-To: <20210406163231.19663-1-david.marchand@redhat.com> From: David Marchand Date: Tue, 6 Apr 2021 18:40:37 +0200 Message-ID: To: dev Cc: Thomas Monjalon , Dmitry Kozlyuk , Narcisa Ana Maria Vasile , Dmitry Malloy , Pallavi Kadam , Ray Kinsella , Neil Horman Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] build: list symbols exports in a single file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 6, 2021 at 6:33 PM David Marchand wrote: > diff --git a/buildtools/map_to_win.py b/buildtools/map_to_win.py > index 2a6cb88605..34434d96fa 100644 > --- a/buildtools/map_to_win.py > +++ b/buildtools/map_to_win.py > @@ -7,7 +7,7 @@ > > > def is_function_line(ln): > - return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln > + return ln.startswith('\t') and ln.endswith(';\n') and ":" not in ln and "# WINDOWS_NO_EXPORT" not in ln > > # MinGW keeps the original .map file but replaces per_lcore* to __emutls_v.per_lcore* > def create_mingw_map_file(input_map, output_map): > @@ -24,12 +24,6 @@ def main(args): > create_mingw_map_file(args[1], args[2]) > return 0 > > -# special case, allow override if an def file already exists alongside map file > - override_file = join(dirname(args[1]), basename(args[2])) > - if exists(override_file): > - with open(override_file) as f_in: > - functions = f_in.readlines() > - Forgot to clean associated python imports. Will be fixed in a v2 if no objection is raised on the principle of the patch. > # generate def file from map file. > # This works taking indented lines only which end with a ";" and which don't > # have a colon in them, i.e. the lines defining functions only. -- David Marchand