From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D720AA0547; Mon, 21 Jun 2021 10:28:59 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C491941158; Mon, 21 Jun 2021 10:28:59 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 5A4A940040 for ; Mon, 21 Jun 2021 10:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624264136; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wNV4wn41B4IBve51xw8Tr0KxNTZrCy+N9VNEsdKvxzY=; b=Wvche1krLUXG0jZxDA+1lq/txzyB6fDOSw77g6Wm/hR6cTfl5FZ26msOwhb7x3P00XUdl5 xPuH+d6wSLheycBK8/f45iudWa8esGPLj5ZRq6jDbOnJBe5KyWGZ8aRDkd0H2OZRO/DDRJ qPJa1xX1Gx5iXOjmisiHFB634kHtOq4= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-479-jV09If9rMsOzf0PDbgm-wA-1; Mon, 21 Jun 2021 04:28:55 -0400 X-MC-Unique: jV09If9rMsOzf0PDbgm-wA-1 Received: by mail-ua1-f72.google.com with SMTP id g13-20020ab028cd0000b029027838cf9d1dso5700966uaq.21 for ; Mon, 21 Jun 2021 01:28:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wNV4wn41B4IBve51xw8Tr0KxNTZrCy+N9VNEsdKvxzY=; b=IqT8FU5aMfyjllbA9aYUY325nhVuTumapQ+lFXgvKV1XoPCsJykLZKzwchpVoDcmfH V5ZQM1qkhQdI65l0B0nmWe4+xtvwryE8LbrNrbvGAFFURFbibPN8Yx4neSjTURl78q2f IDUKH0CNKMffzHE1Ed1/fM04khmSNcldjVSb7xmYu29H6u3VWwQvjbZ97qjc1P43u3m+ cpa5biSe4jzhVuLGX/1pu8uVy1mJiJQIseQknllKJByRWKU2TWv6Dcm37wS6rw8jd2tB VBZs8rvsi2qbt2FFeVZZU9y+8ds1LY9Jxfkly0QL7QDWB9BLc+Y4nhql+jx7XCt8uWCy 7/RQ== X-Gm-Message-State: AOAM531M15Wh42/ILYCYthreFNsXC8cI7N+TGT0s7fh7gOo+Khs57h8E mIF9EbWroVGtPWIX5o1BH0Ye+DZRU6eOWo7CPcDJFzCVB/qaEhZaXtdRHkVEjoDBIpUBzhpf7t4 1Gc+k2YVo58Wonnfvvkg= X-Received: by 2002:a1f:2e86:: with SMTP id u128mr13711188vku.22.1624264134741; Mon, 21 Jun 2021 01:28:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwhDWuDMxllwV7hqwx/7C0s4jAGemefqpK6ZQDvLkp6t2oF/rBV+8UxHDV2ThtbQutAfrZrTrqCmIE3aaOyP0U= X-Received: by 2002:a1f:2e86:: with SMTP id u128mr13711180vku.22.1624264134411; Mon, 21 Jun 2021 01:28:54 -0700 (PDT) MIME-Version: 1.0 References: <20210527152510.1551026-1-andrew.rybchenko@oktetlabs.ru> <20210618134032.1922012-1-andrew.rybchenko@oktetlabs.ru> <20210618134032.1922012-20-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210618134032.1922012-20-andrew.rybchenko@oktetlabs.ru> From: David Marchand Date: Mon, 21 Jun 2021 10:28:43 +0200 Message-ID: To: Andrew Rybchenko , Bruce Richardson Cc: dev , Igor Romanov , Andy Moreton , Ivan Malov Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 19/20] net/sfc: support flow action COUNT in transfer rules X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Jun 18, 2021 at 3:41 PM Andrew Rybchenko wrote: > diff --git a/drivers/net/sfc/meson.build b/drivers/net/sfc/meson.build > index f8880f740a..32b58e3d76 100644 > --- a/drivers/net/sfc/meson.build > +++ b/drivers/net/sfc/meson.build > @@ -39,6 +39,16 @@ foreach flag: extra_flags > endif > endforeach > > +# for clang 32-bit compiles we need libatomic for 64-bit atomic ops > +if cc.get_id() == 'clang' and dpdk_conf.get('RTE_ARCH_64') == false > + ext_deps += cc.find_library('atomic') > +endif I don't think this block is needed. The atomic library is globally required in config/meson.build for the clang + 32bits case. > + > +# for gcc compiles we need -latomic for 128-bit atomic ops > +if cc.get_id() == 'gcc' > + ext_deps += cc.find_library('atomic') > +endif > + This patch breaks compilation on rhel/fedora (most failures in UNH for this series are linked to this issue) when the libatomic rpm is not installed. ninja: Entering directory `/home/dmarchan/builds/build-gcc-static' [1/18] Linking target drivers/librte_net_sfc.so.21.3 FAILED: drivers/librte_net_sfc.so.21.3 gcc -o drivers/librte_net_sfc.so.21.3 drivers/librte_net_sfc.so.21.3.p/meson-generated_.._rte_net_sfc.pmd.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ethdev.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_kvargs.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mcdi.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_sriov.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_intr.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ev.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_port.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_rx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_tx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_tso.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_filter.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_switch.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_mae_counter.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_flow.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_dp.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ef10_rx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ef10_essb_rx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ef10_tx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ef100_rx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_ef100_tx.c.o drivers/libtmp_rte_net_sfc.a.p/net_sfc_sfc_service.c.o -I/home/dmarchan/intel-ipsec-mb/install/include -L/home/dmarchan/intel-ipsec-mb/install/lib -Wl,--as-needed -Wl,--no-undefined -shared -fPIC -Wl,--start-group -Wl,-soname,librte_net_sfc.so.21 -Wl,--no-as-needed -pthread -lm -ldl -lnuma -lfdt lib/librte_ethdev.so.21.3 lib/librte_eal.so.21.3 lib/librte_kvargs.so.21.3 lib/librte_telemetry.so.21.3 lib/librte_net.so.21.3 lib/librte_mbuf.so.21.3 lib/librte_mempool.so.21.3 lib/librte_ring.so.21.3 lib/librte_meter.so.21.3 drivers/librte_bus_pci.so.21.3 lib/librte_pci.so.21.3 drivers/librte_bus_vdev.so.21.3 drivers/librte_common_sfc_efx.so.21.3 -Wl,--version-script=/home/dmarchan/dpdk/drivers/net/sfc/version.map /usr/lib/gcc/x86_64-redhat-linux/10/libatomic.so /usr/lib64/libbsd.so -Wl,--end-group '-Wl,-rpath,$ORIGIN/../lib:$ORIGIN/' -Wl,-rpath-link,/home/dmarchan/builds/build-gcc-static/lib -Wl,-rpath-link,/home/dmarchan/builds/build-gcc-static/drivers /usr/bin/ld: cannot find /usr/lib64/libatomic.so.1.2.0 collect2: error: ld returned 1 exit status It seems meson related. I do see: Library atomic found: YES Message: drivers/net/sfc: Defining dependency "net_sfc" But looking at /home/dmarchan/build/build-gcc-static/meson-logs/meson-log.txt: """ Running compile: Working directory: /home/dmarchan/builds/build-gcc-static/meson-private/tmpdu27j15z Command line: gcc -L/home/dmarchan/intel-ipsec-mb/install/lib -I/home/dmarchan/intel-ipsec-mb/install/include /home/dmarchan/builds/build-gcc-static/meson-private/tmpdu27j15z/testfile.c -o /home/dmarchan/builds/build-gcc-static/meson-private/tmpdu27j15z/output.exe -pipe -D_FILE_OFFSET_BITS=64 -O0 -Wl,--start-group -latomic -Wl,--end-group -Wl,--allow-shlib-undefined Code: int main(void) { return 0; } Compiler stdout: Compiler stderr: /usr/bin/ld: cannot find /usr/lib64/libatomic.so.1.2.0 collect2: error: ld returned 1 exit status Library atomic found: YES """ And: [dmarchan@wsfd-netdev66 dpdk]$ cat /usr/lib/gcc/x86_64-redhat-linux/10/libatomic.so INPUT ( /usr/lib64/libatomic.so.1.2.0 ) [dmarchan@wsfd-netdev66 dpdk]$ file /usr/lib64/libatomic.so.1.2.0 /usr/lib64/libatomic.so.1.2.0: cannot open `/usr/lib64/libatomic.so.1.2.0' (No such file or directory) [dmarchan@wsfd-netdev66 dpdk]$ meson --version 0.55.3 -- David Marchand