From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EFF7A04FD; Fri, 29 Jul 2022 13:14:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 195C542C1A; Fri, 29 Jul 2022 13:14:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 83D564069C for ; Fri, 29 Jul 2022 13:14:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1659093293; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wQL2e8sQQHcJ4sp3ljvwA/KpHKMG2EWBjEo6qTiKnco=; b=GYksrHKsjjx173JA98HXoHWSb/5VnXq+VfPpkiqVCVRmW3D1xf/I3yH+cnOZg8qi42dH2D TuWKg2FYMOPhPepfFBSibMl2kA/efVk9ujWg61fJBEqdnfQcfKSYUHdd2jg5NIZ0fXKNLy 6hPEm3Nka1aiVJAB2pEfB6ohNThRfpQ= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-132-XEQJJo1vNMmjatjLOTPlHg-1; Fri, 29 Jul 2022 07:14:42 -0400 X-MC-Unique: XEQJJo1vNMmjatjLOTPlHg-1 Received: by mail-lj1-f200.google.com with SMTP id z6-20020a2e8e86000000b0025e128449adso911216ljk.22 for ; Fri, 29 Jul 2022 04:14:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wQL2e8sQQHcJ4sp3ljvwA/KpHKMG2EWBjEo6qTiKnco=; b=LDJWMJg/IyOAEyAb245xVJaYQliu8iW4RN9LHi3PnjwV1fnVcsPqZR4+yQlb12wnpF 5w43XTaLbx8bo6nvHSwaWVcd7vly8oDHIOEfZf5K2rELSdssIqpr2hdLLRcu3/F704Dj K2unWKK0qwiEkBv3ru5XVxCW+yOzerXEtxsSQAsrQteg6Esqxes0gDPqXLxc3PFgTnrX EdM5VM06WxU9w6EnwfFluBkKF1ijnF2PnYqdQinzqoxjrLsnSp82tlknrvA8+vtjuP2z FmOr3vJZqqIkJkA+7GZ3mG+XewrewxsZaKxFHcvwWpVNySSs4BkFgCD5lyVDuMOyetOy 208A== X-Gm-Message-State: AJIora8dI7353ZvW2Ye1npvtOGwxGVa5Sx5rvIbrhCBeGvwLK5LuNwhm fTXeQT8UMF4/XAgEHbWAWqnqPYYncmM3nSQmu22Rg3mwUR02F1hTUP4DRVJJXV8/hAsiiFvvIly NmQHn9p0cLnXgaA4ENEI= X-Received: by 2002:a05:651c:106c:b0:25e:11f3:1e with SMTP id y12-20020a05651c106c00b0025e11f3001emr929316ljm.55.1659093280961; Fri, 29 Jul 2022 04:14:40 -0700 (PDT) X-Google-Smtp-Source: AGRyM1votS+s4GorXNsPtkBPOdbXTYZai/bQ99NAi3LhmiaI5MQXp2t+6wif8Tv/TRpbi3MVuIOfKLFWhtkZlseB3Jw= X-Received: by 2002:a05:651c:106c:b0:25e:11f3:1e with SMTP id y12-20020a05651c106c00b0025e11f3001emr929305ljm.55.1659093280641; Fri, 29 Jul 2022 04:14:40 -0700 (PDT) MIME-Version: 1.0 References: <20220628144643.1213026-1-david.marchand@redhat.com> <20220728152640.547725-1-david.marchand@redhat.com> <20220728152640.547725-22-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Fri, 29 Jul 2022 13:14:29 +0200 Message-ID: Subject: Re: [RFC v3 21/26] bus: hide bus object To: Bruce Richardson Cc: dev , Ray Kinsella , Parav Pandit , Xueming Li , Hemant Agrawal , Sachin Saxena , Rosen Xu , Anatoly Burakov , Stephen Hemminger , Long Li , Matan Azrad , Viacheslav Ovsiienko , Kevin Laatz , Chas Williams , "Min Hu (Connor)" , Gaetan Rivet , Maxime Coquelin , Chenbo Xia , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Reshma Pattan Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jul 29, 2022 at 12:02 PM Bruce Richardson wrote: > However, if we do look to fix, how about just dropping the runtime check > completely and just using a build-time one for the RTE_NET_RING macro. I > don't consider it valid for the tests to run with some of the built drivers > deleted. If it was enabled in the build, I think the tests are ok to assume > it is present at runtime. The build time check is likely enough, added to my todolist.. -- David Marchand