DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: thomas@monjalon.net, bruce.richardson@intel.com
Cc: dev@dpdk.org, andremue@linux.microsoft.com,
	 dpdk-techboard <techboard@dpdk.org>
Subject: Re: [RFC v4 0/8] Symbol versioning and export rework
Date: Wed, 26 Mar 2025 13:02:32 +0100	[thread overview]
Message-ID: <CAJFAV8xiZB8r9=5D2tpc9Onrh+7582ZzM8cY_2VHojaQ7xe=BQ@mail.gmail.com> (raw)
In-Reply-To: <20250317154308.2782689-1-david.marchand@redhat.com>

On Mon, Mar 17, 2025 at 4:43 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> So far, each DPDK library (or driver) exposing symbols in an ABI had to
> maintain a version.map and use some macros for symbol versioning,
> specially crafted with the GNU linker in mind.
>
> This series proposes to rework the whole principle, and instead rely on
> marking the symbol exports in the source code itself, then let it to the
> build framework to produce a version script adapted to the linker in use
> (think GNU linker vs MSVC linker).
>
> This greatly simplifies versioning symbols: a developer does not need to
> know anything about version.map, or that a versioned symbol must be
> renamed with _v26, annotated with __vsym, exported in a header etc...
>
> Checking symbol maps becomes unnecessary since generated by the build
> framework.
>
> Updating to a new ABI is just a matter of bumping the value in
> ABI_VERSION.
>
>
> Comments please.

- I am considering making rte_function_versioning.h a non exported
header (precisely, moving it to buildtools/ and maybe renaming it).

This header contains macros not prefixed with RTE_.
Using it requires some build trick (see use_function_versioning).
And I don't see symbol versioning as a MUST infrastructure that DPDK
needs to provide to datapath applications.

Yet technically, this change would be an API breakage if some
applications indeed relied on it.

Cc: techboard for info.


- On a similar note, this RFC series adds the rte_exports.h header
(defining RTE_EXPORT*_SYMBOL()) in config/, though its job is for
extracting a symbol list during the build.
So a better location is probably buildtools/.


-- 
David Marchand


  parent reply	other threads:[~2025-03-26 12:02 UTC|newest]

Thread overview: 74+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-05 21:23 [RFC] eal: add new function versioning macros David Marchand
2025-03-06  2:57 ` Patrick Robb
2025-03-06 10:23 ` Bruce Richardson
2025-03-06 12:50 ` [RFC v2 1/2] " David Marchand
2025-03-06 12:50   ` [RFC v2 2/2] build: generate symbol maps David Marchand
2025-03-06 15:45   ` [RFC v2 1/2] eal: add new function versioning macros Andre Muezerie
2025-03-11  9:55 ` [RFC v3 0/8] Symbol versioning and export rework David Marchand
2025-03-11  9:55   ` [RFC v3 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-11  9:56   ` [RFC v3 2/8] drivers: " David Marchand
2025-03-11  9:56   ` [RFC v3 3/8] eal: rework function versioning macros David Marchand
2025-03-13 16:53     ` Bruce Richardson
2025-03-13 17:09       ` David Marchand
2025-03-11  9:56   ` [RFC v3 4/8] buildtools: display version when listing symbols David Marchand
2025-03-11  9:56   ` [RFC v3 5/8] build: generate symbol maps David Marchand
2025-03-13 17:26     ` Bruce Richardson
2025-03-14 15:38       ` David Marchand
2025-03-14 14:24     ` Thomas Monjalon
2025-03-14 15:38       ` David Marchand
2025-03-14 15:27     ` Andre Muezerie
2025-03-14 15:51       ` David Marchand
2025-03-11  9:56   ` [RFC v3 6/8] build: mark exported symbols David Marchand
2025-03-13 17:30     ` Bruce Richardson
2025-03-14 16:14       ` David Marchand
2025-03-14 16:23         ` Bruce Richardson
2025-03-14 16:53           ` David Marchand
2025-03-14 17:21             ` David Marchand
2025-03-14 17:28             ` Bruce Richardson
2025-03-14 17:39               ` David Marchand
2025-03-14 17:51                 ` Bruce Richardson
2025-03-11  9:56   ` [RFC v3 7/8] build: use dynamically generated version maps David Marchand
2025-03-11  9:56   ` [RFC v3 8/8] build: remove static " David Marchand
2025-03-11 10:18   ` [RFC v3 0/8] Symbol versioning and export rework Morten Brørup
2025-03-11 13:43     ` David Marchand
2025-03-17 15:42 ` [RFC v4 " David Marchand
2025-03-17 15:42   ` [RFC v4 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-17 15:42   ` [RFC v4 2/8] drivers: " David Marchand
2025-03-17 15:42   ` [RFC v4 3/8] eal: rework function versioning macros David Marchand
2025-03-17 15:43   ` [RFC v4 4/8] buildtools: display version when listing symbols David Marchand
2025-03-17 15:43   ` [RFC v4 5/8] build: generate symbol maps David Marchand
2025-03-19 16:19     ` Stephen Hemminger
2025-03-19 17:12       ` David Marchand
2025-03-20 15:06         ` Andre Muezerie
2025-03-17 15:43   ` [RFC v4 6/8] build: mark exported symbols David Marchand
2025-03-17 15:43   ` [RFC v4 7/8] build: use dynamically generated version maps David Marchand
2025-03-17 15:43   ` [RFC v4 8/8] build: remove static " David Marchand
2025-03-18  8:19   ` [RFC v4 0/8] Symbol versioning and export rework David Marchand
2025-03-26 12:02   ` David Marchand [this message]
2025-03-26 12:26     ` Morten Brørup
2025-03-26 13:07     ` Bruce Richardson
2025-03-26 13:36     ` Bruce Richardson
2025-03-26 13:54       ` David Marchand
2025-03-26 14:16         ` Bruce Richardson
2025-03-27 13:36 ` [PATCH v5 " David Marchand
2025-03-27 13:36   ` [PATCH v5 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-27 13:36   ` [PATCH v5 2/8] drivers: " David Marchand
2025-03-27 13:36   ` [PATCH v5 3/8] buildtools: display version when listing symbols David Marchand
2025-03-27 13:36   ` [PATCH v5 4/8] build: generate symbol maps David Marchand
2025-03-27 13:36   ` [PATCH v5 5/8] build: mark exported symbols David Marchand
2025-03-27 18:21     ` David Marchand
2025-03-27 13:36   ` [PATCH v5 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:19     ` Aaron Conole
2025-03-27 13:36   ` [PATCH v5 7/8] build: remove static " David Marchand
2025-03-27 13:36   ` [PATCH v5 8/8] eal: rework function versioning macros David Marchand
2025-03-27 18:22   ` [PATCH v5 0/8] Symbol versioning and export rework David Marchand
2025-03-28 10:52 ` [PATCH v6 " David Marchand
2025-03-28 10:52   ` [PATCH v6 1/8] lib: remove incorrect exported symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 2/8] drivers: " David Marchand
2025-03-28 10:52   ` [PATCH v6 3/8] buildtools: display version when listing symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 4/8] build: generate symbol maps David Marchand
2025-03-28 10:52   ` [PATCH v6 5/8] build: mark exported symbols David Marchand
2025-03-28 10:52   ` [PATCH v6 6/8] build: use dynamically generated version maps David Marchand
2025-03-28 13:20     ` Aaron Conole
2025-03-28 10:52   ` [PATCH v6 7/8] build: remove static " David Marchand
2025-03-28 10:52   ` [PATCH v6 8/8] eal: rework function versioning macros David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJFAV8xiZB8r9=5D2tpc9Onrh+7582ZzM8cY_2VHojaQ7xe=BQ@mail.gmail.com' \
    --to=david.marchand@redhat.com \
    --cc=andremue@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=techboard@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).