From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EEF19A0353; Tue, 19 Nov 2019 21:47:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9553F1C0B; Tue, 19 Nov 2019 21:47:32 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 2B2CDCF3 for ; Tue, 19 Nov 2019 21:47:31 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574196450; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=H98On3B4zCYABlyFeLMN08CE9zCm1KcYm++KqVe27xU=; b=dvcsRueTznMBy1VqZmX6KGzQcIOT7vNwPNcqJwbZZG1GAgC2OKIjOrYNSv+fVkPFUsDpKc YGpJRjN1h8w9Qy05bsLMPaBIP6TH4LsqD4lsYSGzecBfrE6iYR6TfwdsLO/zwSIgNaIiLj vLCF//FlDBQijF7M4FEI28Jq/i2M5v4= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-36-OMx2-u9_Ny-JVpA0EiPfLA-1; Tue, 19 Nov 2019 15:47:27 -0500 Received: by mail-vs1-f71.google.com with SMTP id o18so3291730vsa.0 for ; Tue, 19 Nov 2019 12:47:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l/ywcpMyYcZfa6Lrqp5NliVLJYwIBLRCPnwXsomAmAQ=; b=hSodRjyDhUzCvKdeZ9IIlrMv3aBDpaVJWy13PONRYd28LqNJQly9nC1FObp/xXn8mT yFH5LiWFEKUkYXGEY6f1lvUN1WcxlezEzax4xwDKZee/gow24LK0vRUJQY7y+SkqvgUS xmUnQwU1RCqBzItDlReKnGS9bwYSZiTaFcvPBxbTcO3BYI0bZ54JyVYv4Rw4hSa2DeaZ 4kTeeoWeHs9hUhV17A4pcoFIexO2DWrGN4j0OdXU4YEdmbUTbAwOXlhFBhibr19nvTbe HUiWdIp8daOrKk5/IsmbdHWPnb9kw6aOE4SmcG+Z6QRQEx0d/G6dCmLvChuzAtR46eGb s0AQ== X-Gm-Message-State: APjAAAWWFrLZ+QkVDdGYt/Lt82TlI3Wv9qr8bKcKOCwLszcTc/jBeHoI 5vVrJZYmfN6Ma96KQE3KYPDq2B/kIA64V1BT377VHFKUnD//fNDawcfaxQzPe2vjHYQa88j4BOE IUuqGu6oAX++A37aOWWU= X-Received: by 2002:a1f:e243:: with SMTP id z64mr3247418vkg.56.1574196446593; Tue, 19 Nov 2019 12:47:26 -0800 (PST) X-Google-Smtp-Source: APXvYqzvwTvCA9YzPxmh2y+DLzEUV9oO4XC46vg0D8NXVG4oWiT7E6gZu4CQASh0NwTX+ZIuusLbfX87F6+f3C6JhE0= X-Received: by 2002:a1f:e243:: with SMTP id z64mr3247388vkg.56.1574196446145; Tue, 19 Nov 2019 12:47:26 -0800 (PST) MIME-Version: 1.0 References: <1573570228-15676-1-git-send-email-xuemingl@mellanox.com> <1573570228-15676-2-git-send-email-xuemingl@mellanox.com> In-Reply-To: <1573570228-15676-2-git-send-email-xuemingl@mellanox.com> From: David Marchand Date: Tue, 19 Nov 2019 21:47:15 +0100 Message-ID: To: Xueming Li , Anatoly Burakov Cc: Asaf Penso , dev , dpdk stable X-MC-Unique: OMx2-u9_Ny-JVpA0EiPfLA-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH 2/2] malloc: fix realloc padded element size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Nov 12, 2019 at 3:50 PM Xueming Li wrote: > > When resize a memory with next element, the original element size grows. > If the orginal element has padding, the real inner element size didn't > grow as well and this causes trailer verification failure when malloc > debug enabled. I did not see this when running the malloc_autotest with debug enabled. What is missing for me to catch it? Just a bit chilly to apply this series. The first patch seems an optimisation. The second one seems more interesting if we fix the debug mode, but I suppose we can live without them in 19.11. --=20 David Marchand