From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id CA7681B725 for ; Fri, 22 Mar 2019 18:43:25 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id o187so653567vkg.4 for ; Fri, 22 Mar 2019 10:43:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p5VKJkab4dGNG+s9bQtNKzXcs+atu44/B99YwUEJZhY=; b=ojb2VDGfq/QNcEpcXzBaAh/JoC3wJW5N+gQ9AQ4keKyFhsneDeu+4JvmitQ0jE72VF /h+blTy9a2humG5aNC6SNhGZo9ssSkykjRZk/D+olUpGud57b9HUbfRwFeDCPhJExQpg dRTo6p5xF5SYUVxexDldFSoAS8o3ODOHe77FxE2kPWl5srWPfnJCCxvIvwpubUNyDj/z 2bJqusQ3GFzKr8scNqD+cW0vKnYON7BTc+kc/CpFoeGFoO5GAzsd+Fum0n6SB+kvfWaa TMzW0qpsyDle8qwzH3/E/xhsptieV+6Jf5nPucurxP/IPC5IY+CxYAZCcPpmIkHdZM62 b0Gw== X-Gm-Message-State: APjAAAUecTxvogi018k4fRwAEL/mdLvw1bY4Ndj+ObiBfYh/37vY5vBg EFmUr2gBh2lt7mDIvms8gfNxz+LFPewPGTIb0hzEcQ== X-Google-Smtp-Source: APXvYqzO5WNyshft0ZWaGJpQHj1tEWDU3ktBeAUd5tVn3HWZEdLfsNmIwr0ibSAmQ/U28IvaEzakeEJha7qsGTUXmko= X-Received: by 2002:a1f:c06:: with SMTP id 6mr6811612vkm.52.1553276605209; Fri, 22 Mar 2019 10:43:25 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> In-Reply-To: <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> From: David Marchand Date: Fri, 22 Mar 2019 18:43:14 +0100 Message-ID: To: Andrew Rybchenko Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Mar 2019 17:43:26 -0000 On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko wrote: > On 22.03.2019 16:37, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > > > After: > > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Reviewed-by: Rami Rosen > > Reviewed-by: Andrew Rybchenko > > --- > > Changelog since v2: > > - Cc'd stable > > > > --- > > app/test-pmd/testpmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 216be47..40199c1 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1459,7 +1459,7 @@ struct extmem_param { > > "TX Port=%2d/Queue=%2d %s\n", > > fwd_top_stats_border, fs->rx_port, fs->rx_queue, > > fs->tx_port, fs->tx_queue, fwd_top_stats_border); > > - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", > > + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", > > fs->rx_packets, fs->tx_packets, fs->fwd_dropped); > > > > /* if checksum mode */ > > > In fact bad Rx checksum counters follow and I think they should be in > this line. > > That's why there is no \n here from the very beginning. > > My fix for the bug (local) just add \n in else branch below. > Mm, ok, I will look at this monday. I might add the \n in pkt_burst_stats_display() and update other callers. -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 01D29A00E6 for ; Fri, 22 Mar 2019 18:43:28 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E97C01B726; Fri, 22 Mar 2019 18:43:26 +0100 (CET) Received: from mail-vk1-f194.google.com (mail-vk1-f194.google.com [209.85.221.194]) by dpdk.org (Postfix) with ESMTP id CA7681B725 for ; Fri, 22 Mar 2019 18:43:25 +0100 (CET) Received: by mail-vk1-f194.google.com with SMTP id o187so653567vkg.4 for ; Fri, 22 Mar 2019 10:43:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=p5VKJkab4dGNG+s9bQtNKzXcs+atu44/B99YwUEJZhY=; b=ojb2VDGfq/QNcEpcXzBaAh/JoC3wJW5N+gQ9AQ4keKyFhsneDeu+4JvmitQ0jE72VF /h+blTy9a2humG5aNC6SNhGZo9ssSkykjRZk/D+olUpGud57b9HUbfRwFeDCPhJExQpg dRTo6p5xF5SYUVxexDldFSoAS8o3ODOHe77FxE2kPWl5srWPfnJCCxvIvwpubUNyDj/z 2bJqusQ3GFzKr8scNqD+cW0vKnYON7BTc+kc/CpFoeGFoO5GAzsd+Fum0n6SB+kvfWaa TMzW0qpsyDle8qwzH3/E/xhsptieV+6Jf5nPucurxP/IPC5IY+CxYAZCcPpmIkHdZM62 b0Gw== X-Gm-Message-State: APjAAAUecTxvogi018k4fRwAEL/mdLvw1bY4Ndj+ObiBfYh/37vY5vBg EFmUr2gBh2lt7mDIvms8gfNxz+LFPewPGTIb0hzEcQ== X-Google-Smtp-Source: APXvYqzO5WNyshft0ZWaGJpQHj1tEWDU3ktBeAUd5tVn3HWZEdLfsNmIwr0ibSAmQ/U28IvaEzakeEJha7qsGTUXmko= X-Received: by 2002:a1f:c06:: with SMTP id 6mr6811612vkm.52.1553276605209; Fri, 22 Mar 2019 10:43:25 -0700 (PDT) MIME-Version: 1.0 References: <1553076154-3907-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-1-git-send-email-david.marchand@redhat.com> <1553261824-1881-2-git-send-email-david.marchand@redhat.com> <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> In-Reply-To: <8568275c-04a1-9d1a-6fa7-ecf7487cce3e@solarflare.com> From: David Marchand Date: Fri, 22 Mar 2019 18:43:14 +0100 Message-ID: To: Andrew Rybchenko Cc: dev , Wenzhuo Lu , Jingjing Wu , "Iremonger, Bernard" , Rami Rosen , "Yigit, Ferruh" , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 1/4] app/testpmd: add missing newline when showing statistics X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190322174314.phbam-kKdntwopj5rTFX23YbPtnlPKsKVDHaJEzhZmw@z> On Fri, Mar 22, 2019 at 6:35 PM Andrew Rybchenko wrote: > On 22.03.2019 16:37, David Marchand wrote: > > Having the standard stats and the rx burst stats on the same line gives a > > really long line and is not consistent with the rest. > > > > Before: > > RX-packets: 3542977 TX-packets: 3542971 TX-dropped: 6 > RX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of > others] > > TX-bursts : 499440 [24% of 2 pkts + 15% of 1 pkts + 61% of others] > > > > After: > > RX-packets: 4629969 TX-packets: 4629969 TX-dropped: 0 > > RX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > TX-bursts : 663328 [19% of 2 pkts + 17% of 3 pkts + 64% of others] > > > > Fixes: af75078fece3 ("first public release") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > Reviewed-by: Rami Rosen > > Reviewed-by: Andrew Rybchenko > > --- > > Changelog since v2: > > - Cc'd stable > > > > --- > > app/test-pmd/testpmd.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c > > index 216be47..40199c1 100644 > > --- a/app/test-pmd/testpmd.c > > +++ b/app/test-pmd/testpmd.c > > @@ -1459,7 +1459,7 @@ struct extmem_param { > > "TX Port=%2d/Queue=%2d %s\n", > > fwd_top_stats_border, fs->rx_port, fs->rx_queue, > > fs->tx_port, fs->tx_queue, fwd_top_stats_border); > > - printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u", > > + printf(" RX-packets: %-14u TX-packets: %-14u TX-dropped: %-14u\n", > > fs->rx_packets, fs->tx_packets, fs->fwd_dropped); > > > > /* if checksum mode */ > > > In fact bad Rx checksum counters follow and I think they should be in > this line. > > That's why there is no \n here from the very beginning. > > My fix for the bug (local) just add \n in else branch below. > Mm, ok, I will look at this monday. I might add the \n in pkt_burst_stats_display() and update other callers. -- David Marchand