From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6E9FAA0A02; Thu, 25 Mar 2021 14:14:58 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5470B4067B; Thu, 25 Mar 2021 14:14:58 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mails.dpdk.org (Postfix) with ESMTP id 702ED4067B for ; Thu, 25 Mar 2021 14:14:56 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616678095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=l72+61+C6Bno5TjBnAek6MgFEgT3tohVP0FXPO7GlTw=; b=OCSSYXQV56ezGSuO7oRoMrzP4snxtB6zLGH4+GvCtux54mKsRcO4QQFoYGitx2G1g0RQ6E +Tamf3LazxhXvwc6Co1DCemyHOl5ufOiQsxVTZ8oLyTQKYFk1dqAn7uUJLXLbPPlrpPmCe XgbfnE1Ku9VKEDhu5qGwh1iMFd5Ue+E= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-492-6QyTDBYJMgKxkLujcCcbmQ-1; Thu, 25 Mar 2021 09:14:54 -0400 X-MC-Unique: 6QyTDBYJMgKxkLujcCcbmQ-1 Received: by mail-ua1-f69.google.com with SMTP id i22so1509050uaq.0 for ; Thu, 25 Mar 2021 06:14:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=l72+61+C6Bno5TjBnAek6MgFEgT3tohVP0FXPO7GlTw=; b=e9obNDlW1Aph+vQyi3If1DNEp0Z60pyDVyQ21C3wB4uqCsv6qzupdNedcPLvPBbanw OxebduTarZUyqG5VzQ6hcPDH0VZkIbH0sC4TQqIOsSAeDYtzK2aRHDhaLYx6ejX+Dz99 WvzLqE8vurTjJvrp7SmbnNHtziVUSidtygCtZMUWau+dgIJlN014FO1c7mDIIQrymBmK ibc9qnNeAwEOrSl+bCW9nWzl5aVgjTYmZkMvLP/GRjDhurmNWza9HQHUswgftRwgtLRS PsQPH7j03KmcVp2wdb6JzPpFLsv1ZVH1prgJFB3EfEGxzVsHQ+OVpscxZPCtYZR7jOwd oibg== X-Gm-Message-State: AOAM531dqsxmfukYbDD33BtmX6vPOq0TjxUjBDG+J5OqGo1/ZseLe0t4 tFAUGv+l/FjA7PemSJHTmgC3ycHqDBEuHS00+wg/Ys7wNHIFyqFwSJ5VpGjmh0nC/qRIv0DPAN3 Y4iFkSvEklKG73pPeYxY= X-Received: by 2002:a67:d210:: with SMTP id y16mr4899395vsi.17.1616678093471; Thu, 25 Mar 2021 06:14:53 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwQ9C1QpiDpRn6kbV2Oj/cYdULewe/3nNla2EF/N38ijaYMloBgh6LNyZPnj3fvAUJPvwA8Nmwl6/AmSQY8MJE= X-Received: by 2002:a67:d210:: with SMTP id y16mr4899364vsi.17.1616678093218; Thu, 25 Mar 2021 06:14:53 -0700 (PDT) MIME-Version: 1.0 References: <20210218212746.3073-1-Renata.Saiakhova@ekinops.com> <20210218212746.3073-2-Renata.Saiakhova@ekinops.com> In-Reply-To: <20210218212746.3073-2-Renata.Saiakhova@ekinops.com> From: David Marchand Date: Thu, 25 Mar 2021 14:14:41 +0100 Message-ID: To: Renata Saiakhova Cc: Anatoly Burakov , Harman Kalra , Bruce Richardson , Ray Kinsella , Neil Horman , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4 1/1] eal/interrupts: add synchronous wrapper around unregister X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Feb 18, 2021 at 10:28 PM Renata Saiakhova wrote: > > Avoid race with unregister interrupt handler if interrupt > source has some active callbacks at the moment, use wrapper > around rte_intr_callback_unregister() to check for -EAGAIN > return value and to loop until rte_intr_callback_unregister() > succeeds. > > Signed-off-by: Renata Saiakhova > Acked-by: Anatoly Burakov > --- > drivers/bus/pci/linux/pci_vfio.c | 2 +- > lib/librte_eal/freebsd/eal_interrupts.c | 12 ++++++++++++ > lib/librte_eal/include/rte_interrupts.h | 25 +++++++++++++++++++++++++ > lib/librte_eal/linux/eal_interrupts.c | 12 ++++++++++++ > lib/librte_eal/version.map | 1 + > 5 files changed, 51 insertions(+), 1 deletion(-) Seeing the description of this function, I'd expect it to be the same on all OS implementations. Please, could you respin with Windows update? [snip] > diff --git a/lib/librte_eal/version.map b/lib/librte_eal/version.map > index fce90a112..56caa9cc9 100644 > --- a/lib/librte_eal/version.map > +++ b/lib/librte_eal/version.map > @@ -318,6 +318,7 @@ EXPERIMENTAL { > rte_fbarray_find_rev_biggest_free; > rte_fbarray_find_rev_biggest_used; > rte_intr_callback_unregister_pending; > + rte_intr_callback_unregister_sync; > rte_realloc_socket; > > # added in 19.08 > -- > 2.17.2 > The new symbol should be with other 21.05 additions. Thanks. -- David Marchand