From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DE43EA034C; Wed, 21 Dec 2022 16:02:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8221640A7F; Wed, 21 Dec 2022 16:02:56 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 226F340A7A for ; Wed, 21 Dec 2022 16:02:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671634974; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=wnGOqEKo+HP9j/37SZPnnFqss+bdui+Joni2TSIWXJ0=; b=Ogm2EKYjmIj6zByUYyWqGhU/JH17Yv1YinA9hT+fgA890bTMX9iVVE4ks5GYZRssfXWHv1 NZlG9bEayHkR/GaLcO7zPCZVa76diTiuOTtbPgwIa/mXkt5qLeXqT1ZZq08cbNqKjE9J8/ UNKAuK5PnLzyN4s/CfJEes3It41fM9w= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-283-VLRNbM79M9ua6agVbOkpsw-1; Wed, 21 Dec 2022 10:02:53 -0500 X-MC-Unique: VLRNbM79M9ua6agVbOkpsw-1 Received: by mail-pj1-f70.google.com with SMTP id b16-20020a17090a10d000b00221653b4526so1279385pje.2 for ; Wed, 21 Dec 2022 07:02:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wnGOqEKo+HP9j/37SZPnnFqss+bdui+Joni2TSIWXJ0=; b=VW4czYH0zHbCs/bmrHAbIx+U2Je7qEl7Vz2IJLF0aP/X0IhICHHwIYTrVxAs0+3G/7 T0jbnkgibgEQppYORSS+xnJw7rAx1aNt5htxIRtj0wakM1StxHHp81qEqpVouzHu3pi0 yZxJtJfYR5Xpf2Rvvc9tdvWmCpGb7FK37SbmCkb/Syamk/m9QrPyU2USHLfYDnTKptRk 6cVsbCTzQ3g5eglZQUVQ/mlR5CZjVLndcZJM8ne9YGkPapqw1nC/N1zeceQMe2lZZ/LD jOrSUz1U5ngVeM86/QpfBtFdVU8AAX4iRux83y87UaRGKT0ePEjFMMX3Qo3xnXevhDnK RLuw== X-Gm-Message-State: AFqh2kq/ExVVQey1zF04I0AkV+BY3pD6vRsSItU3DJsEWb0a+05Ltvd3 sQMsGVX57fyX1izzRte9wNG0kddGM3HYDTJR0bEcBECsS6lMS7e+9y7BW4Bpqiz/zF6viSIFZnf tKN2T5hMgz9f4djj5RR0= X-Received: by 2002:a05:6a00:c5:b0:57a:81f2:798d with SMTP id e5-20020a056a0000c500b0057a81f2798dmr161903pfj.76.1671634972328; Wed, 21 Dec 2022 07:02:52 -0800 (PST) X-Google-Smtp-Source: AMrXdXtCg9n3q9nvevXESYR4PMyqOVNSXnp/NS5Y0/gS1OQWtQVvY3FxVwQdKgJ9g5+LjhtpVN62IkeNn47LRqASNIk= X-Received: by 2002:a05:6a00:c5:b0:57a:81f2:798d with SMTP id e5-20020a056a0000c500b0057a81f2798dmr161901pfj.76.1671634972018; Wed, 21 Dec 2022 07:02:52 -0800 (PST) MIME-Version: 1.0 References: <20221206122341.3046688-1-ferruh.yigit@amd.com> <20221209090222.441690-1-david.marchand@redhat.com> <20221209090222.441690-2-david.marchand@redhat.com> In-Reply-To: <20221209090222.441690-2-david.marchand@redhat.com> From: David Marchand Date: Wed, 21 Dec 2022 16:02:40 +0100 Message-ID: Subject: Re: [PATCH v2 2/2] devtools: configure source repo to use as ABI reference To: dev@dpdk.org Cc: thomas@monjalon.net, bruce.richardson@intel.com, gakhil@marvell.com, Ferruh Yigit X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Dec 9, 2022 at 10:02 AM David Marchand wrote: > > From: Ferruh Yigit > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to clone for reference > using 'DPDK_ABI_REF_SRC' environment variable. > 'DPDK_ABI_REF_SRC' may refer to a directory containing a cloned git > repository, or a remote git repository. > > It is possible to put these variables to 'devel.config' config file, or > provide via command line, like: > ` > DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable \ > DPDK_ABI_REF_VERSION=v22.11.1 \ > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > ./devtools/test-meson-builds.sh > ` > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > previously. > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > other repo as a new 'remote' to the exiting git repository. > > Signed-off-by: Ferruh Yigit > Acked-by: Akhil Goyal > Signed-off-by: David Marchand > --- > Changes since v1: > - expanded DPDK_ABI_REF_SRC usage to "non-local" sources, Series applied, thanks. -- David Marchand