From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 22643A052A;
	Mon, 25 Jan 2021 15:35:26 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id BD5DA140E7E;
	Mon, 25 Jan 2021 15:35:24 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
 (us-smtp-delivery-124.mimecast.com [63.128.21.124])
 by mails.dpdk.org (Postfix) with ESMTP id 470DB140E11
 for <dev@dpdk.org>; Mon, 25 Jan 2021 15:35:23 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1611585322;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=XN+fU8xYTacI1EBZdBOHmU8KneWUcUcVwpLOQt0IWdE=;
 b=JtaWSTQz0o4/CFHaEZAAv7gK3hRbNmqgC4H3kdTZJF9mCD5YGYm5dP6Qjw4A3QdQ5V5yr9
 xyjeXCuivnNHZYcqoEl+MjDEg1ueTn4Wqwyp5N3mugZ08wiVL1VJwa8hzewRn4YNc6Ej0x
 0pvXqdSBdrsouQ4dhSaB0Q50pKQ0bWk=
Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com
 [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-450-xgppXjWXMG2YvI3NvJnJ1A-1; Mon, 25 Jan 2021 09:35:18 -0500
X-MC-Unique: xgppXjWXMG2YvI3NvJnJ1A-1
Received: by mail-ua1-f70.google.com with SMTP id z4so5166927uan.8
 for <dev@dpdk.org>; Mon, 25 Jan 2021 06:35:18 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=XN+fU8xYTacI1EBZdBOHmU8KneWUcUcVwpLOQt0IWdE=;
 b=lII8pkMnhILn/jgsDCNZ6YTw1Sk32V1Kv8EzmRNJmOZKuwNon063IMsmqN9EqfH5qx
 DV+7TjTjh5fuzjEyEfzY47MK4gxo0qvdazVlsEqNfk+rXFQSS+wIhIh9YRYLa2dh0ie1
 hTsGTeoRSw4An4MWIswhY7Amp91P57RaQeBkofBYKPCj8AzUsGfYx+eapYxrK0WAPclT
 fA62p56ZzxuveeZ2+MJUubrCeGiV21LcFGwHh6X8Jaq57ZI3sRgAt3Z2PCa/IMJc1Ha1
 t9dHQuE2KewTvivJKv11VPmMRlhRMTyDnqy/5qPc9DGtn1DK2oNPV3RH5Z9ikzBu/Tvg
 34hQ==
X-Gm-Message-State: AOAM532plRk6S6Mo3Ju/rzVxdArl71uiauYxS1w5OfHxiJI5JjuhX4Xp
 9fhzNLOucy9v34DRwRWqYKctHMMwZCIOIsulnD6YsqyLBI9YYmetTN4lVP6JDogNW/RaFhKFqBD
 J5on+FfTohW50bDP0eUg=
X-Received: by 2002:a05:6102:21cd:: with SMTP id
 r13mr891799vsg.5.1611585317935; 
 Mon, 25 Jan 2021 06:35:17 -0800 (PST)
X-Google-Smtp-Source: ABdhPJzjOj10KjstHcqeUxjCwhM4iH8vc/La8K5sEelfod8djvqokA+8/p6uMn26DxKQHPP1rMz7PE/jUI6BEN4FOOU=
X-Received: by 2002:a05:6102:21cd:: with SMTP id
 r13mr891776vsg.5.1611585317705; 
 Mon, 25 Jan 2021 06:35:17 -0800 (PST)
MIME-Version: 1.0
References: <20201215021945.103396-1-leyi.rong@intel.com>
 <DM6PR12MB3945A6FE02C47F856D48415BA4A20@DM6PR12MB3945.namprd12.prod.outlook.com>
 <CAJFAV8y3m4ucODUPazNZR2gMJ2hDiVpkbOmUXe4B5sGCL2J5QA@mail.gmail.com>
 <5859779.zrh4IzKrC7@thomas>
 <CAJFAV8y1RikOfDfQ5goDQmbr-z4weZU+iB7=7hCsvXj8tSaO7Q@mail.gmail.com>
 <MWHPR12MB14722E85A8F79F856ADDEFFEDAA20@MWHPR12MB1472.namprd12.prod.outlook.com>
 <b51ffeb0-e609-d996-58c5-98fd135bb6ff@intel.com>
 <0b572eb2-8abe-e673-dd01-9db6cbaf3b0f@intel.com>
In-Reply-To: <0b572eb2-8abe-e673-dd01-9db6cbaf3b0f@intel.com>
From: David Marchand <david.marchand@redhat.com>
Date: Mon, 25 Jan 2021 15:35:06 +0100
Message-ID: <CAJFAV8xkBvO3ALYzukwtCZOB75yaA8ii26rZ=dUQA2fuzu6zhw@mail.gmail.com>
To: "Kadam, Pallavi" <pallavi.kadam@intel.com>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>, Ali Alnubani <alialnu@nvidia.com>, 
 NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, "Richardson,
 Bruce" <bruce.richardson@intel.com>, 
 Tal Shnaiderman <talshn@nvidia.com>, Odi Assli <odia@nvidia.com>, "Rong,
 Leyi" <leyi.rong@intel.com>, 
 "Zhang, Qi Z" <qi.z.zhang@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, 
 "Xing, Beilei" <beilei.xing@intel.com>, "Menon,
 Ranjit" <ranjit.menon@intel.com>, 
 "dev@dpdk.org" <dev@dpdk.org>, Raslan Darawsheh <rasland@nvidia.com>
Authentication-Results: relay.mimecast.com;
 auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v3 0/3] AVX512 vPMD on i40e
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Thu, Jan 21, 2021 at 6:02 AM Kadam, Pallavi <pallavi.kadam@intel.com> wrote:
> On 1/20/2021 11:21 PM, Ferruh Yigit wrote:
>
> And for the mingw, I have same result with Ali, I can reproduce with (Fedora MinGW 9.2.1-6.fc32).
>
> But different from the CI, I am getting the error [1] for all following files:
> rte_random.c
> i40e_rxtx_vec_sse.c
> i40e_rxtx_vec_avx512.c
> i40e_rxtx_vec_avx2.c
> rte_ethdev.c
>
> [1] Error: invalid register for .seh_savexmm
>
>
> There is a stackoverflow entry for it:
> https://stackoverflow.com/questions/43152633/invalid-register-for-seh-savexmm-in-cygwin
>
> If I use '-fno-asynchronous-unwind-tables' as suggested there, the build works fine.
>
> So the problem may not be just 'i40e_rxtx_vec_avx512.c'.
>
>
> If I change the machine type from 'native' to 'corei7' [2], the build error reduced to only 'i40e_rxtx_vec_avx512.c', so the problem seems happens when avx512 is supported by CPU, in this case compiler seems has a defect.
> And since for 'i40e_rxtx_vec_avx512.c' the '-march=skylake-avx512' explicitly set can cause the problem seen in all machines.
>
> [2]
>  diff --git a/config/x86/cross-mingw b/config/x86/cross-mingw
>  index 4c15a7fa2e..7cee238add 100644
>  --- a/config/x86/cross-mingw
>  +++ b/config/x86/cross-mingw
>  @@ -9,5 +9,5 @@ pkgconfig = 'x86_64-w64-mingw32-pkg-config'
>   [host_machine]
>   system = 'windows'
>   cpu_family = 'x86_64'
>  -cpu = 'native'
>  +cpu = 'corei7'
>   endian = 'little'
>
> @Ranjit, @Pallavi,
> Are you building using mingw, and if so are you observing same problem?
>

Thanks Ferruh.


> We usually build using Clang. However, we verify with mingw as well before submitting the patch.
> As mentioned in the patch [1] comments, we replaced #include x86intrin.h with <rte_vect.h> in the file i40e_rxtx_vec_avx2.c
> And this helped fixing an error related to conflicting types for '__m_prefethw' with Clang on Windows.
> I was able to build this patch using Clang as well as mingw.
> [1] http://patches.dpdk.org/patch/84770/
>
> I verified patch fix submitted by Rong, Leyi, it builds successfully with Clang.
> However, I am getting same error "Error: invalid register for .seh_savexmm" using mingw for 'i40e_rxtx_vec_avx512.c' file.

The patch I sent https://patchwork.dpdk.org/patch/86999/ is not enough.
I have neither time nor environment to find a fix.

For now I simply stopped checking mingw builds.

Will it get fixed?


-- 
David Marchand