DPDK patches and discussions
 help / color / mirror / Atom feed
From: David Marchand <david.marchand@redhat.com>
To: Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
	 Bruce Richardson <bruce.richardson@intel.com>
Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com,
	 Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>
Subject: Re: [PATCH] fib: network byte order IPv4 lookup
Date: Mon, 30 Sep 2024 17:07:18 +0200	[thread overview]
Message-ID: <CAJFAV8xkH7j+HD7Wmws+VLd3ed60SKUsTVLSp1e3twO7vAVPvw@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zK6eZF2fuGqe8uYgvoYpvQX5i15myqMOoY-7QT47b7EA@mail.gmail.com>

On Sat, Sep 28, 2024 at 1:51 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Sep 6, 2024 at 1:07 PM Vladimir Medvedkin
> <vladimir.medvedkin@intel.com> wrote:
> >
> > Previously when running rte_fib_lookup IPv4 addresses must have been in
> > host byte order.
> >
> > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on
> > fib create, which will allow to have IPv4 in network byte order on
> > lookup.
> >
> > Signed-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
>
> _mm512_shuffle_epi8 requires avx512bw, so the dir24_8 AVX512
> implementation can only compile when such feature is supported and
> enabled.
> Like the trie AVX512 implem.
>
> IOW, we are missing an update of the library meson.build.

I also suspect that both this added support in the dir24_8
implementation and the existing trie are missing some runtime check on
RTE_CPUFLAG_AVX512BW in get_vector_fn.
Can we get a fix for trie and a respin of this current patch?

Thanks.


-- 
David Marchand


  reply	other threads:[~2024-09-30 15:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-06 17:06 Vladimir Medvedkin
2024-09-27 23:51 ` David Marchand
2024-09-30 15:07   ` David Marchand [this message]
2024-10-04 12:01     ` Vladimir Medvedkin
2024-10-08 17:33 ` [PATCH v2] " Vladimir Medvedkin
2024-10-10 11:26   ` [PATCH v3] " Vladimir Medvedkin
2024-10-11 10:32     ` Robin Jarry
2024-10-11 11:29     ` David Marchand
2024-10-11 14:33       ` David Marchand
2024-10-11 17:57     ` [PATCH v4] " Vladimir Medvedkin
2024-10-14 13:37       ` [PATCH v5] " Vladimir Medvedkin
2024-10-14 15:22         ` Stephen Hemminger
2024-10-14 16:59           ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAJFAV8xkH7j+HD7Wmws+VLd3ed60SKUsTVLSp1e3twO7vAVPvw@mail.gmail.com \
    --to=david.marchand@redhat.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.v.ananyev@yandex.ru \
    --cc=mb@smartsharesystems.com \
    --cc=rjarry@redhat.com \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).