From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AE08C45A68; Mon, 30 Sep 2024 17:07:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F5274027C; Mon, 30 Sep 2024 17:07:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id F1DA94014F for ; Mon, 30 Sep 2024 17:07:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1727708863; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tPEpqte72WMTLJfYQrSV7IyUl0f3C6RYbCGTOs98FRA=; b=fhTz24ZpRE2jOs0xIow2pQPLqO8jT29mAQIQpmStKTbq26sATjVNX8OEyzJczee5iXojD6 bhx+9t7uNtvvi/4QKRq4T+rCjcv5o1Jn77ZZgWHw/SI22avli+Ov6hMCliuKZvDbuMKzKf LOU7ur7ColH4zWSVCXjfcy1OCtAWW5o= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-570-AyO_SCXqMxqSHACsUEQK5g-1; Mon, 30 Sep 2024 11:07:42 -0400 X-MC-Unique: AyO_SCXqMxqSHACsUEQK5g-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-42cb6ed7f9dso45895755e9.3 for ; Mon, 30 Sep 2024 08:07:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727708861; x=1728313661; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tPEpqte72WMTLJfYQrSV7IyUl0f3C6RYbCGTOs98FRA=; b=uE0UGHVblJTbTjZrVVP/egVCas5loPvNroIzKWERj1P5wt2tBj1cUajfI3KDAAYXjS MtQoI8T0pRsNIEyw1zUDAEr7BxgXppM8qVpQDp8q0H2H7ute0s3aGEwznt//bgDrGnbb RHVtW49xwv4z8dBSbyEqBcn6vGDlAmTN23jneD/XNiBYUoC+rdTANKIDf4/PUmnuLcrV zQRx4oN7GdEx4bzBnwRvB7AVVx10+sz9HZIXLShspl03OzfZMePOhxYiO2VaeF9VuxOk /2rg8rpHgQo1Ab4x5yncV1zepHIWE6xAHwNgLM281QqiCkpb5s9Q9LuDTt5NEZcSTXOm hy3g== X-Gm-Message-State: AOJu0YxL+h8UtjQYYMULdEMKKrmKU8jeQohF4BkqBqogYt6VH6+NDXXC PbNoQK5SXS/X/tZmpWUq7rMoTOC8J36GVjsGuFtiTTy+3MtE1kvNqrWRsjGp+OPemossPrRP7Wc l69VebjJqgJQuCOdNsRT47qQ3dFdk0LmL9RP7enXyRbuo+2osk7iGZyDPta/pPEnp/L6DyKqejC XPN3k/7fbysHLbU0tdg4+hPw9eqHV1 X-Received: by 2002:a05:600c:46cb:b0:42c:b77a:bd21 with SMTP id 5b1f17b1804b1-42f584976e2mr119285985e9.28.1727708861094; Mon, 30 Sep 2024 08:07:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH0ka/xqHE+0eKToL/p1uvv74pKTd0Jr+KjgIhVRuhA72sK3VeARPUxbcQw6kxL6hTOn1ipovqxxtKLLwVuLjs= X-Received: by 2002:a05:6512:6cb:b0:539:901c:e2e with SMTP id 2adb3069b0e04-539901c10bfmr3616116e87.58.1727708850165; Mon, 30 Sep 2024 08:07:30 -0700 (PDT) MIME-Version: 1.0 References: <20240906170649.1325254-1-vladimir.medvedkin@intel.com> In-Reply-To: From: David Marchand Date: Mon, 30 Sep 2024 17:07:18 +0200 Message-ID: Subject: Re: [PATCH] fib: network byte order IPv4 lookup To: Vladimir Medvedkin , Bruce Richardson Cc: dev@dpdk.org, rjarry@redhat.com, mb@smartsharesystems.com, Konstantin Ananyev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Sep 28, 2024 at 1:51=E2=80=AFAM David Marchand wrote: > > On Fri, Sep 6, 2024 at 1:07=E2=80=AFPM Vladimir Medvedkin > wrote: > > > > Previously when running rte_fib_lookup IPv4 addresses must have been in > > host byte order. > > > > This patch adds a new flag RTE_FIB_FLAG_LOOKUP_BE that can be passed on > > fib create, which will allow to have IPv4 in network byte order on > > lookup. > > > > Signed-off-by: Vladimir Medvedkin > > _mm512_shuffle_epi8 requires avx512bw, so the dir24_8 AVX512 > implementation can only compile when such feature is supported and > enabled. > Like the trie AVX512 implem. > > IOW, we are missing an update of the library meson.build. I also suspect that both this added support in the dir24_8 implementation and the existing trie are missing some runtime check on RTE_CPUFLAG_AVX512BW in get_vector_fn. Can we get a fix for trie and a respin of this current patch? Thanks. --=20 David Marchand