From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by dpdk.space (Postfix) with ESMTP id E5334A046B
	for <public@inbox.dpdk.org>; Wed, 26 Jun 2019 09:37:24 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 558825B3A;
	Wed, 26 Jun 2019 09:37:24 +0200 (CEST)
Received: from mail-vs1-f65.google.com (mail-vs1-f65.google.com
 [209.85.217.65]) by dpdk.org (Postfix) with ESMTP id 01B565587
 for <dev@dpdk.org>; Wed, 26 Jun 2019 09:37:21 +0200 (CEST)
Received: by mail-vs1-f65.google.com with SMTP id v6so951046vsq.4
 for <dev@dpdk.org>; Wed, 26 Jun 2019 00:37:21 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=yxGrdrCiC0GXilYdoOPFqhXa2ymijNhiIxRLT0/3Z9s=;
 b=YLBIrhb3Gk7eap7qA/hZm/wl9MxqDxGLy5OaLj8ew37G/HrAXO3WiCJ+dAT0kFUvep
 l5k6CHXHI+JvsgZ/iHHghR69Ebd4h9ij7jVlol/kvgILMFvWB1ORhVW9RpTzzTuVBwaQ
 n+0f2u2WDN6SYbPfd2webRk71DR0CZaa1v3/CG2UqHsHzYe7jVIW8VS5Joqjp1xSi0WO
 NJy7fUEk+Qv/4zQp5pUJE3m2TV5lEB0aWzUVY3v0XAPFAz1qNL2Hu5O108bZYTEvTXiC
 wL005SSxLl/axIR7VPFz+/3KRyLP/T1IDtQUBTs2Rw2+a1Zn19aef1IjKZdQKQ6Vy1DN
 r50g==
X-Gm-Message-State: APjAAAVBKmtnsC2ZHPk/IObXzxD0mQx+2f7UKRET/voCYNCy4wc3ISAH
 mzz3nIZW1yQ6GyBknkfBqfTZJ5CwknWHPPL3Wm1GzA==
X-Google-Smtp-Source: APXvYqysx6wTMcYXv49nAFpYWaqh9/AcsscWwTewZCcITfy9Glw/lpiWc9j6rgYv7q3qgy5+OTdDh9R4K9HZg1gOj3c=
X-Received: by 2002:a67:f998:: with SMTP id b24mr2134912vsq.180.1561534641369; 
 Wed, 26 Jun 2019 00:37:21 -0700 (PDT)
MIME-Version: 1.0
References: <1561469937-16077-1-git-send-email-david.marchand@redhat.com>
 <BYAPR18MB2838082331F405138B954784B5E30@BYAPR18MB2838.namprd18.prod.outlook.com>
In-Reply-To: <BYAPR18MB2838082331F405138B954784B5E30@BYAPR18MB2838.namprd18.prod.outlook.com>
From: David Marchand <david.marchand@redhat.com>
Date: Wed, 26 Jun 2019 09:37:10 +0200
Message-ID: <CAJFAV8xkN0+P1RKKZwuCukymQVdYw6RGxUMkppc2_OT+Qk+EZQ@mail.gmail.com>
To: Rasesh Mody <rmody@marvell.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "stable@dpdk.org" <stable@dpdk.org>,
 Shahed Shaikh <shshaikh@marvell.com>
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [EXT] [PATCH] net/qede: remove interrupt reconfigure
	in handler
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Jun 26, 2019 at 12:50 AM Rasesh Mody <rmody@marvell.com> wrote:

> >From: David Marchand <david.marchand@redhat.com>
> >Sent: Tuesday, June 25, 2019 6:39 AM
> >
> >----------------------------------------------------------------------
> >rte_intr_enable/rte_intr_disable configure the interrupt context on the
> >kernel side (either uio or vfio).
> >In VFIO case, calling it from the interrupt handlers triggers an unneeded
> >interrupt handlers reconfiguration.
> >During this reconfiguration window, the device can trigger interrupts
> which
> >are left unserviced.
> >
> >Reported-at: https://bugzilla.redhat.com/show_bug.cgi?id=1654824
> >Fixes: 245aec289338 ("net/qede: fix legacy interrupt mode")
> >Fixes: 2ea6f76aff40 ("qede: add core driver")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: David Marchand <david.marchand@redhat.com>
> >---
>
> Change looks good, thanks.
>
> Acked-by: Rasesh Mody <rmody@marvell.com>
>

Something still bothers me about the meaning of rte_intr_enable()...
Let me write a mail to a little more people :-)

For now, let's put this patch on hold.


-- 
David Marchand