From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C68C442BAB; Fri, 26 May 2023 14:33:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97E3740EE7; Fri, 26 May 2023 14:33:30 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 18B8040DDA for ; Fri, 26 May 2023 14:33:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685104408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=5eeudPERiql1qzS0t7VznL6tfUHfsmbGxMvvkha+DHU=; b=goa1LjNpetib+sA6btmdatxar63ECdfcozLrKZj1meVU37EkHfMivMdj1roNePW9qYgR7n 6rVY8RSp0zznYl/c0tu/ab6hbMwpswAm1BAHosu8yh3XDcseSBAQoWzQsrqTjTiKM2XgCh iJztqxYyKb2/7QlXnIO3PBI727BGWkk= Received: from mail-pl1-f200.google.com (mail-pl1-f200.google.com [209.85.214.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-433-niFALsiUOoSzvijpWpTKjQ-1; Fri, 26 May 2023 08:33:27 -0400 X-MC-Unique: niFALsiUOoSzvijpWpTKjQ-1 Received: by mail-pl1-f200.google.com with SMTP id d9443c01a7336-1b0116fefffso4238635ad.2 for ; Fri, 26 May 2023 05:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685104406; x=1687696406; h=cc:to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5eeudPERiql1qzS0t7VznL6tfUHfsmbGxMvvkha+DHU=; b=YjP6aSAknixyQ7TFL5Lisq22EOforjKrrjrWjoG+TTGzBp/HXgOk4TR8LZo9Zyb+UM nM9QhISJENOYIDwfj4c/JSRxjdy9Xo/isdrieefuDN6Juv4t39dsilIqR5c6OzG905w3 JHrAwsPRSvipKgKNW+kqnk3ZN1of73G3gQpEmWq3Gp82zxmIRKceFcPc/5cwppzbStQ8 +BjQy0ypio1V6NQfmWAtvPkyVXAZSDColRxwc5kY0oDAAvLDDFT/2f/Gz2wwY6cvi5UU pAtQhQoenfQv29z3e1AF/gTYy+UXNv8LSEdqQd5Jqumd5xEs1Hmc9jaOXF0sU1dc2ATK DQZw== X-Gm-Message-State: AC+VfDz5eQP31UgMFXUV1IL8vpW7m+HrJeAHEWVqdno4cjVclOKhcYQg 5i4G/JdycqqVZ4ewCAeznN7aL8HiV4jptauDRW5QZxp8R0VqbIE1UPa4luNbTKdNKUVFUM0Z3ZI cKLRr2Vn8UvVZ/EDEkBlcDsEi3SEQmg== X-Received: by 2002:a17:902:da83:b0:1af:cabb:87b6 with SMTP id j3-20020a170902da8300b001afcabb87b6mr3115624plx.19.1685104406204; Fri, 26 May 2023 05:33:26 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7s/WtUByNL4ka4ftcDFAeXM/T2TJpuEoInbuBnJg+GB+QPXzprnF5wG3E8guM7rqz5mQTIWIDP5iWrC+6u9KM= X-Received: by 2002:a17:902:da83:b0:1af:cabb:87b6 with SMTP id j3-20020a170902da8300b001afcabb87b6mr3115599plx.19.1685104405913; Fri, 26 May 2023 05:33:25 -0700 (PDT) MIME-Version: 1.0 From: David Marchand Date: Fri, 26 May 2023 14:33:14 +0200 Message-ID: Subject: "Thread safety" in rte_flow To: Ori Kam , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko Cc: dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello Ori, ethdev maintainers, I am a bit puzzled at the RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE checks in rte_flow.c. - The rte_flow.h does not hint at what is being protected. All I can see is a somewhat vague, in lib/ethdev/rte_ethdev.h: /** PMD supports thread-safe flow operations */ #define RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE RTE_BIT32(0) It would be great to have a more detailed description of what this thread safety means. - I don't think many functions of the rte_flow API look at this flag. It seems it is never checked in newly added symbols (this is an impression, I did not enter the details). Could you have a look? Thanks. -- David Marchand