From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9CE90A04BC; Thu, 8 Oct 2020 09:30:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 754401B850; Thu, 8 Oct 2020 09:30:34 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 2ECCB1B81B for <dev@dpdk.org>; Thu, 8 Oct 2020 09:30:33 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602142231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SYUM1ylc2KA9IUCLwfttziqmkBOwdTxKdq4/7OcJUyw=; b=Gqc+XbzZWDQFHV3TAuaIiF+mozWr7JxwsGSOdZCTsDQEfbeGz/sUgT3H5CrckesOUya1ZK LAqO0a9HXjpCeCPW8L75isIFmPeZMlPQjEwsJFbRV5UhAmdOY2gDAGYp4rhNODdUVx0nig 4qS2mW+Fwywca/T6o2ySeUU4ADM1ZpE= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-101-ZTGmnaLHMQCscjH4wO58bA-1; Thu, 08 Oct 2020 03:30:29 -0400 X-MC-Unique: ZTGmnaLHMQCscjH4wO58bA-1 Received: by mail-vk1-f199.google.com with SMTP id l24so785679vkk.2 for <dev@dpdk.org>; Thu, 08 Oct 2020 00:30:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=SYUM1ylc2KA9IUCLwfttziqmkBOwdTxKdq4/7OcJUyw=; b=EB+zsEsBxRBkqFXUV4uGdIGcrNgBxNWgyMUuMrem/GxcBbbdhhV660nXYxZQIc8Xw/ rR+PG5MqUbAayp660d0tjRLu35QZTMiCarqgR/VBPzyhKuhzo9vu02OkE1Dvo6VV/NKx s/POe0ixsEj9b6xfnsyJ85uVK3w41tudh/YrsKJrenldzn3UjcB6m1Hp9y8Vpn8UZo0m S/2Z4rt1a27mHqyURzDfJPIN7qpjmZDv7cA1Upe99vrVpMHDAWFBw9/9Wyxu4oedABGv OjsVbMT536TRhdLgYGZE06b5K14/6WsDgzIBCe9K3T7lPNDA8rLo3DbjF39n6F1MxmIf CV/w== X-Gm-Message-State: AOAM532ea8M8WJq0wNbv268JuEVWI9bi51gNimm8ndpnjInFN2og461C 57tgY8FE4KJDNZGMdkyC7GoIBMkV5HUcfrbEsYKWITXhAdR5/AxKzugwmReEDhxJmr1bgtF4Q0r Z3jA3j83MoFPGmwYrTZI= X-Received: by 2002:a67:68c9:: with SMTP id d192mr458125vsc.5.1602142228580; Thu, 08 Oct 2020 00:30:28 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMCiVYuprHC3EC/Yc6o7+PGSVU5lovRXRH9Ng7KL8ZgdnmNHCmct5P8/zGpaZqg7niip+4QLmBoCfMq8Ezhfg= X-Received: by 2002:a67:68c9:: with SMTP id d192mr458121vsc.5.1602142228340; Thu, 08 Oct 2020 00:30:28 -0700 (PDT) MIME-Version: 1.0 References: <CGME20201008052336eucas1p16b5b1600683e33ddba30479b7fd62ce6@eucas1p1.samsung.com> <20200925224209.12173-1-l.wojciechow@partner.samsung.com> <20201008052323.11547-1-l.wojciechow@partner.samsung.com> In-Reply-To: <20201008052323.11547-1-l.wojciechow@partner.samsung.com> From: David Marchand <david.marchand@redhat.com> Date: Thu, 8 Oct 2020 09:30:17 +0200 Message-ID: <CAJFAV8xn=ao=f-_NwGcks4FYyxmUqcoXGkdqj3xz+LYHaei1KQ@mail.gmail.com> To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>, David Hunt <david.hunt@intel.com>, Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> Cc: dev <dev@dpdk.org>, Sarosh Arif <sarosh.arif@emumba.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v5 00/15] fix distributor synchronization issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Thu, Oct 8, 2020 at 7:24 AM Lukasz Wojciechowski <l.wojciechow@partner.samsung.com> wrote: > > During review and verification of the patch created by Sarosh Arif: > "test_distributor: prevent memory leakages from the pool" I found out > that running distributor unit tests multiple times in a row causes fails. > So I investigated all the issues I found. > > There are few synchronization issues that might cause deadlocks > or corrupted data. They are fixed with this set of patches for both tests > and librte_distributor library. > > --- > v5: > * implement missing functionality in burst mode - worker shutdown > * fix shutdown test to always shutdown busy worker > * use atomic stores instead of barrier in tests clear_packet_count() > * reorder patches > * new patch 7: fix call to return_pkt in single mode > * new patch 11: replacing delays with spinlock on atomics in tests > * new patch 12: fix scalar matching algorithm > * new patch 13: new test with marking and checking every packet > * new patch 14: flush also in flight packets > * new patch 15: fix clearing returns buffer > * minor fixes in other patches Thanks for working on it, Lukasz. David, Honnappa, review please. -- David Marchand