From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D4C4A00E6 for ; Mon, 8 Jul 2019 11:09:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ACF34C90; Mon, 8 Jul 2019 11:09:24 +0200 (CEST) Received: from mail-vs1-f66.google.com (mail-vs1-f66.google.com [209.85.217.66]) by dpdk.org (Postfix) with ESMTP id 205C03195 for ; Mon, 8 Jul 2019 11:09:23 +0200 (CEST) Received: by mail-vs1-f66.google.com with SMTP id 2so7714168vso.8 for ; Mon, 08 Jul 2019 02:09:23 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oFB/2PakyJa5BwuMI71KJ50/2vPDRvu6kyUrgdMTHMw=; b=RTT67I7Kn/wThhc7Qkh261gtosoAloEfNICeX8SzV7hwysIPOIuQAnrXJerrGyz7aa DzMSz+ig69HsYLde3KmQ1aR0Ss7ZQSabZHWKVEf2HYee+o/7c0TeR4//P6YaXWXD9Nfu 1fcJeCdO7+OfLgmpAfqm0sKiCm3/7ZIu+mE5KDAg4qZ0FHV9SL7rxHkdnVXP0dM5+QTk VwyAEYSqR2o5IKCqBstSS/vVzWt+to6UHCifNpJiJq8Mw5yxtwlFR+5DmYVylpXGXfix xcrNnq+28NJgIw40JZVTQInQfik4PgmIBs+RMqG177sTcwXahUUR15KGjdw1o3kC3hhK kVsw== X-Gm-Message-State: APjAAAV92ucp/odLnfnkeK5VY6q/728LiBQ3QxMva5++cTR+tEL94+cJ Yf/oLPihBbeIQ2+bydFX2ILJSGtd95pL0WJJatw7/A== X-Google-Smtp-Source: APXvYqwIcgAiXxWn+BtgRMQHrUxDISTl4PG8Fpn02hT+jxNvTfnRlMm8KBlOgBJpKpST4mBxFuOaRiLYygeuhAcJQdc= X-Received: by 2002:a67:da99:: with SMTP id w25mr9698309vsj.141.1562576962509; Mon, 08 Jul 2019 02:09:22 -0700 (PDT) MIME-Version: 1.0 References: <1562131464-58732-1-git-send-email-wei.zhao1@intel.com> <1562218537-33583-1-git-send-email-wei.zhao1@intel.com> <4930276.8mQHqxAZBW@xps> <2821745.aYemArvfLF@xps> In-Reply-To: <2821745.aYemArvfLF@xps> From: David Marchand Date: Mon, 8 Jul 2019 11:09:11 +0200 Message-ID: To: Wei Zhao Cc: dev , dpdk stable , "Iremonger, Bernard" , "Yigit, Ferruh" , Andrew Rybchenko , Jerin Jacob Kollanukkaran , "Ananyev, Konstantin" , Olivier Matz , Adrien Mazarguil , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] app/testpmd: fix to add offloads confguration for queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Wei, On Sat, Jul 6, 2019 at 6:26 PM Thomas Monjalon wrote: > 06/07/2019 18:24, Thomas Monjalon: > > 04/07/2019 07:35, Wei Zhao: > > > When adding offloads from commandline, not only port > > > related configuration bits should be set, but also queue > > > related offloads configuration bits, or it will cause error. > > > For example, test in this process for ixgbe: > > > (1)./x86_64-native-linuxapp-gcc/app/testpmd -c 0x6 -n 4 > > > -- -i --portmask=0x1 --port-topology=loop --disable-crc-strip > > > (2)port stop all > > > (3)port config all crc-strip on > > > (4)port start all > > > we will see "Fail to configure port 0 rx queues" of warning info. > > > > I'm really surprised it was so much broken. > > I did not check the code. Someone else did? > > Adding more Cc for double check. > > Did not check the code yet, but the Fixes: line is about RX offloads, and you touched both rx and tx offloads. The incriminated commit comes from 18.02. I can't reproduce your issue with ixgbe ports. In 18.11, testpmd starts fine and accepts the configuration change. In master (before this change), I can see a different issue which has to do with global offloads vs per queue offloads: # ./master/app/testpmd -w 0000:03:00.0 -w 0000:03:00.1 -- -i --disable-crc-strip EAL: Detected 28 lcore(s) EAL: Detected 1 NUMA nodes EAL: Multi-process socket /var/run/dpdk/rte/mp_socket EAL: Selected IOVA mode 'PA' EAL: Probing VFIO support... EAL: VFIO support initialized EAL: PCI device 0000:03:00.0 on NUMA socket 0 EAL: probe driver: 8086:154d net_ixgbe EAL: using IOMMU type 1 (Type 1) EAL: Ignore mapping IO port bar(2) EAL: PCI device 0000:03:00.1 on NUMA socket 0 EAL: probe driver: 8086:154d net_ixgbe EAL: Ignore mapping IO port bar(2) Interactive-mode selected testpmd: create a new mbuf pool : n=155456, size=2176, socket=0 testpmd: preferred mempool ops selected: ring_mp_mc Configuring Port 0 (socket 0) Port 0: B4:96:91:1B:67:10 Configuring Port 1 (socket 0) Port 1: B4:96:91:1B:67:12 Checking link statuses... Done testpmd> port stop all Stopping ports... Checking link statuses... Done testpmd> port config all crc-strip on testpmd> port start all Configuring Port 0 (socket 0) Ethdev port_id=0 rx_queue_id=0, new added offloads 0x10000 must be within per-queue offload capabilities 0x1 in rte_eth_rx_queue_setup() Fail to configure port 0 rx queues Can you describe your setup, like which driver is used, and the full traces of testpmd ? Thanks. -- David Marchand