From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6493BA04B7; Wed, 14 Oct 2020 15:53:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E4BB11DE37; Wed, 14 Oct 2020 15:53:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by dpdk.org (Postfix) with ESMTP id 5244D1DE35 for ; Wed, 14 Oct 2020 15:53:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602683614; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RcxyVCK2JIu7Td67RCK4kqzJu02c5MPfgdSAnqwUIcw=; b=NViy5Ik0CV4P0NbPjxVnTULtI9PUeM/Y95tgxguIV/Wgxztibad6zqcaAtWBRLym1MbpJE 3HRuCkvsMdWJg3XCSYlF783rkzb9Cx5dpOAx7OWHZivYft/cUANs8zb1Zg979FI2dl+gQe 5LS5JjEII9sfEqg0J5IDgoSOF+0mHCs= Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-289-CWwuHLXBPxqUBql5nZCOqg-1; Wed, 14 Oct 2020 09:53:33 -0400 X-MC-Unique: CWwuHLXBPxqUBql5nZCOqg-1 Received: by mail-vk1-f199.google.com with SMTP id i9so722991vki.15 for ; Wed, 14 Oct 2020 06:53:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RcxyVCK2JIu7Td67RCK4kqzJu02c5MPfgdSAnqwUIcw=; b=I3FGaKcGGp7cH3DvE1cJ5kAnCormasCbgY//7DUnIEw1La/NTVK2LeeHUbb7hXwuk7 lZNlPfaJK6SnDelg4UaNZ+3Wj/aC83KJW14KVFauxEF2SY6j+/+42TGWm3ssN5VK1W6v HGq88oLtfghSClSkkD/DmH0HUH+hJrD6TlR9qXsc1AjSkQ/wACxWyr8NCNSPuh0G4QYN mq6vS+9haDVPc7QLllZpVl//X7D/SHKCoO5mOd/GKgTY+C1QZvm/UvgEARZ05+40jJ6R dtp4aOf9mbbiOoBbiIOKH4IkwZunTqRAOhf9d9qCh06Ext/1TzpKc2yqPsn2m0OL951/ cy4g== X-Gm-Message-State: AOAM532HEx9Lwtj+FC5x2u4WvWNjtDnH5lRpqQQLhQBhEiZI2rFtVeqU Wqx+LYAfch7e5YxENacOjDHdo6tt9Bxac267LcbjxSxZ0ECw8rKB6hDrnUwfnAHxPfPnJmWOPzn lfv9UBQpS4HdwIXfGJas= X-Received: by 2002:ab0:5926:: with SMTP id n35mr2769136uad.126.1602683612819; Wed, 14 Oct 2020 06:53:32 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCQFJ+b8AK7BcAnaqXioBzpgHZnqC+hLLEb9XZOUuuh/tH4xfqoC7i43ROzZBX1p+f1fHGYitpqOtEDneddmQ= X-Received: by 2002:ab0:5926:: with SMTP id n35mr2769126uad.126.1602683612566; Wed, 14 Oct 2020 06:53:32 -0700 (PDT) MIME-Version: 1.0 References: <20200616162705.83575-1-ting.xu@intel.com> <20200722021628.17194-1-ting.xu@intel.com> In-Reply-To: <20200722021628.17194-1-ting.xu@intel.com> From: David Marchand Date: Wed, 14 Oct 2020 15:53:21 +0200 Message-ID: To: Ting Xu Cc: dev , Cristian Dumitrescu , dpdk stable , Kevin Traynor Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v4] lib/table: fix cache alignment issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 22, 2020 at 4:13 AM Ting Xu wrote: > > When create softnic hash table with 16 keys, it failed on 32-bit > environment, because the pointer field in structure rte_bucket_4_16 > is only 32 bits. Add a padding field in 32-bit environment to keep > the structure to a multiple of 64 bytes. Apply this to 8-byte and > 32-byte key hash function as well. > > Fixes: 8aa327214c ("table: hash") > Cc: stable@dpdk.org > > Signed-off-by: Ting Xu Acked-by: Cristian Dumitrescu Applied, thanks. -- David Marchand