From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BC839A00C2; Sat, 25 Apr 2020 16:34:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9ED7E1C1DE; Sat, 25 Apr 2020 16:34:40 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id E9BC81C1BB for ; Sat, 25 Apr 2020 16:34:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587825278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0v4676IE60fYfyt7kzAsBG+3hz94UOlTPdPOOyNHpBU=; b=Bo+/CFXKgpNoX0NrkAIgZqS9G9NiDXoo8RXNrnBRqsOKnWLhtLGXoDGxtLyz2dggIbcERT eQXmZ14BTcxaAiKHV1t5LwRmHuX0gb0PQjkYvTWCUXtKSUk0s0x35owy5qxy20xh8qiXDr rWiRLSjOaegIpfACEUCANObhZZVEXl0= Received: from mail-ua1-f69.google.com (mail-ua1-f69.google.com [209.85.222.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-345-ULVAMq55P7K39sLoSSmSsQ-1; Sat, 25 Apr 2020 10:34:35 -0400 X-MC-Unique: ULVAMq55P7K39sLoSSmSsQ-1 Received: by mail-ua1-f69.google.com with SMTP id x6so6859793uaj.13 for ; Sat, 25 Apr 2020 07:34:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=yedTxVxdFjgdYU7McIbbUtlPTqfiNUfNBSxB3X0DOsQ=; b=pqVZVnHkT9qoCf/iTrz7zR1IpUEOvaSzPASHRgDUH5kuf++nD9YD2ovnOlZEX2jgB/ Nf4yI5mxQMrbPOR4IWeBAMo/cvavQcvqQ4eSTLDyplFye/ct1pxVitYaAWO3in5zbD1x OVKdBZiv7oIhXiBc+IxggP77Xzq0T70s+ZpA974NUervWG/tEe0RrSelWAyh1IVX+aBd LWt01vb8rZkyqDzqT1ma58WL1/ix4syIcBpnC757vyjEEPon1c7MiewKOjTJJz/pwoZG HMWDxf1wbVmIRdQD75JE2foXJXTBa1vM3zwbP5QLC3gE6yjnQP0xUoyWr19UFuEbU05o BEbA== X-Gm-Message-State: AGi0PubWyzS9uZtSYuvawpX/USjtZtOVLY8YRmDQ9DIuMaCqgHonx0eN vJn0aOtCWkN1No2wH3zr1XhVNMDRVqX3/LPX324xpWSkyTUC5uSKyLh74gWrLO/IHv+4jKVdrur R7n1b/jJDSAR/pAAmu3w= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr7477949vkd.18.1587825274475; Sat, 25 Apr 2020 07:34:34 -0700 (PDT) X-Google-Smtp-Source: APiQypKQAk7TqQAkA9CdKoHCwOywFkla0FJ3ZxcMWQO+P1xEJqGsuDDzB+Zglm4n2LUv1nFI5h6Al874fJ//sygSVtk= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr7477934vkd.18.1587825274223; Sat, 25 Apr 2020 07:34:34 -0700 (PDT) MIME-Version: 1.0 References: <20190613142344.9188-1-nhorman@tuxdriver.com> <20200425105620.73021-1-haiyue.wang@intel.com> <20200425105620.73021-6-haiyue.wang@intel.com> In-Reply-To: <20200425105620.73021-6-haiyue.wang@intel.com> From: David Marchand Date: Sat, 25 Apr 2020 16:34:22 +0200 Message-ID: To: Haiyue Wang Cc: dev , Thomas Monjalon , Bruce Richardson , "Yigit, Ferruh" , Neil Horman , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v7 5/6] devtools: exempt internal ABI checking X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 25, 2020 at 1:02 PM Haiyue Wang wrote: > > No need to restrict the ABI on symbols that are only used by core > libraries. > > Signed-off-by: Haiyue Wang Rather than add a special case for INTERNAL, we can invert the logic in this script: identify "stable" sections symbol. I went with the following patch: diff --git a/devtools/check-symbol-change.sh b/devtools/check-symbol-change= .sh index ed2178e36e..f329d5fa62 100755 --- a/devtools/check-symbol-change.sh +++ b/devtools/check-symbol-change.sh @@ -77,6 +77,10 @@ build_map_changes() } +is_stable_section() { + [ "$1" !=3D 'EXPERIMENTAL' ] && [ "$1" !=3D 'INTERNAL' ] +} + check_for_rule_violations() { local mapdb=3D"$1" @@ -110,11 +114,11 @@ check_for_rule_violations() # section directly if [ -z "$oldsecname" ] then - if [ "$secname" =3D 'EXPERIMENTAL' ] + if ! is_stable_section $secname then echo -n "INFO: symbol $symname has = " echo -n "been added to the " - echo -n "EXPERIMENTAL section of th= e " + echo -n "$secname section of the " echo "version map" continue else @@ -137,7 +141,7 @@ check_for_rule_violations() # This symbol is moving between two sections (the # original section is not experimental). # This can be legit, just warn. - if [ "$oldsecname" !=3D 'EXPERIMENTAL' ] + if is_stable_section $oldsecname then echo -n "INFO: symbol $symname is being " echo -n "moved from $oldsecname to $secname= . " @@ -148,9 +152,9 @@ check_for_rule_violations() else if ! grep -q "$mname $symname .* add" "$mapdb" && \ - [ "$secname" !=3D "EXPERIMENTAL" ] + is_stable_section $secname then - # Just inform users that non-experimenal + # Just inform users that stable # symbols need to go through a deprecation # process echo -n "INFO: symbol $symname is being " --=20 David Marchand