From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 68F65A10DA for ; Wed, 31 Jul 2019 21:45:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 951401BE4C; Wed, 31 Jul 2019 21:45:09 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id EA1562B87 for ; Wed, 31 Jul 2019 21:45:07 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id y16so47058558vsc.3 for ; Wed, 31 Jul 2019 12:45:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oeYQZ1Yi4tvqiOdN3uRrX4ZERBDHRU498KGJ8x0YaD0=; b=sbv/vgmtnI9f74DlnHKKoQH+/cqgYfgd3R11xNBXQrcDujTpakQtHQP097lzH0Wini bJcdTpQaNQqY2C/cUdsxabcD4rXicZdsM+2XjUDyEsYgcEA7uJOPKxwGSM3YQHw99zh7 +bbEGTaH+mrBJ1Tpeija13x24huBgbFqEy5DwB5PFJ4uruOzrjXJ04qtGc80T2Q691s6 Ys4spDGeIdgGnJrK+UKAqmSyP35w+Bg7vttVO5DkHCJLkLrOjXPDNAHkDNzdeK56zzUu OrdlSSujB/FfjEcZG9+mv6vAHi2HSD98Ev1dRbn5xvjEcGe8v+hAbHtGfQWTyz7/q/6K LDxg== X-Gm-Message-State: APjAAAUFeIupoMdPgLTREAiZ3ot4owc3T5/G6c/LWwxSUFlPGbgfH9PY H28+i4ynUi3o9F564nb11sVuloLSFTgZ124s7lNn5g== X-Google-Smtp-Source: APXvYqyuvDHrhhWQmQXoRQADuyiPIelUF5EgwkvIllKo+IFtxg0g8RVBHdCw9Z1ZZPP48encXGQWESCHBXK9CSjEmQE= X-Received: by 2002:a67:e9ca:: with SMTP id q10mr48274991vso.105.1564602307298; Wed, 31 Jul 2019 12:45:07 -0700 (PDT) MIME-Version: 1.0 References: <20190731033523.2482-1-tyos@jp.ibm.com> In-Reply-To: From: David Marchand Date: Wed, 31 Jul 2019 21:44:56 +0200 Message-ID: To: Takeshi T Yoshimura Cc: dev , David Christensen Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in ppc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Jul 31, 2019 at 12:44 PM Takeshi T Yoshimura wrote: > > -----David Marchand wrote: ----- > > >To: Takeshi Yoshimura > >From: David Marchand > >Date: 07/31/2019 06:29PM > >Cc: dev > >Subject: [EXTERNAL] Re: [dpdk-dev] [PATCH] eal: forcing IOVA as PA in > >ppc > > > >On Wed, Jul 31, 2019 at 5:36 AM Takeshi Yoshimura > >wrote: > >> > >> Commit b76fafb174d2 ("eal: fix IOVA mode selection as VA for PCI > >> drivers") breaks ppc apps with no IOVA configs (or RTE_IOVA_DC) > >> because of the inconsistency of user's request and the result of > >> device capability for IOVA mode. I updated the code to force IOVA > >as > >> PA in ppc as before because current ppc driver does not support VA > >> mode. > > > >What is the "ppc driver" you are referring to? > >Do you mean the vfio implementation for ppc? > > > >> > >> Theoretically, ppc can support VA mode, but I suspect that ppc with > >> VA mode may have performance issues to create a big DMA window > >> (VA often uses higher addresses than PA). So, I didn't change the > >> code to check device capability in ppc. > > > >Sorry, I am confused. > >Is VA mode not working at all? or is it a performance issue? > > > > > >-- > >David Marchand > > > > > > Ah, I overlooked your first question. The "ppc driver" is in > drivers/bus/pci/linux/pci.c. In pci.c, pci_one_device_iommu_support_va() > always returns false in ppc. so, the driver does not allow VA mode in ppc. > > This return value is passed to rte_pci_probe_one_driver() > in drivers/bus/pci/pci_common.c. And the error log appeared like: > > EAL: PCI device 0000:01:00.0 on NUMA socket 0 > EAL: probe driver: 144d:a822 spdk_nvme > EAL: Expecting 'PA' IOVA mode but current mode is 'VA', not initializing Can you confirm on which kernel driver this device was bound ? I'd like to be sure this is the same issue than David. -- David Marchand