From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04FC8A0C41; Thu, 30 Sep 2021 17:19:38 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8F6241145; Thu, 30 Sep 2021 17:19:37 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id B859B41135 for ; Thu, 30 Sep 2021 17:19:36 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633015176; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rjJxjLqjBhtgiFZlaLOdu33mp2YR5PNROVnZljPs31A=; b=dwsH2OgxynQTJIOubeqhRswZuYZo9w/W/ziQNqoGXAC92Xi1LK45zyH/QAt88Y+Zjr/HLG L7wEQjQ4zJPnfOzSts0POSNVLmkx7xFZLl11dLB21rF1zYdvVHBgDVPlySRsFLas4y/JT/ 3KyXInKXjpgopJ3p1Iqsb+fZHE8FRyU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-155-HoDuqfmEOkaS8zw2nMKqYA-1; Thu, 30 Sep 2021 11:19:34 -0400 X-MC-Unique: HoDuqfmEOkaS8zw2nMKqYA-1 Received: by mail-lf1-f71.google.com with SMTP id x33-20020a0565123fa100b003fcfd99073dso6007347lfa.6 for ; Thu, 30 Sep 2021 08:19:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rjJxjLqjBhtgiFZlaLOdu33mp2YR5PNROVnZljPs31A=; b=I4r9NjmhM9OQVNALUuL7aaNhJ1GOXHnVUFYja8CIB4FzTxCW+j0Dbdnc2uGXQ9u1ir WXNw1D/qH93bSgzaFn7oBYrrS/ii78nPBbrQe3psG/bODl3q5n7AxI7kpuVHKxin+4W8 /sd76CIjVJXlx9SGC4cjBkknszCiaPhl5RVuamBQm37vhc9oICJpmZEQHOJpAafNI4qt gzmF3IHOsti4+4h9lo52ntXSuIli9XJrru272PPQVMtqjQavwDDutVpUn5kwbFtrxzT/ l8hB53S7tRoTB1YZ2zBTzFL/XWOLWENhXYm832yjLTOH3xawIE5C7d1uogsqmDwFKCA/ UHtg== X-Gm-Message-State: AOAM5306iJZCquSfJoWBBmUT4hF6fJZ04sO6vEcqvTr7uOOFTTtlw7Pn 9hwySrhw1TaJahwWZzySSSyjPFVYx6HPNXefZlTYslb1o9oWdTYMm0nFvkVPcKFDsCt2DbePjct c+0WaUrz6lNv6qfrdnr0= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr6387608lfe.217.1633015173198; Thu, 30 Sep 2021 08:19:33 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxRlA/LlagyXxMtHi19KzEZRmmGGHchiqeZM6fumMmiCImnw+g0FmClJUrxvFagl+HngGkYB/CZOEkody9RIjU= X-Received: by 2002:a05:6512:31c3:: with SMTP id j3mr6387583lfe.217.1633015172954; Thu, 30 Sep 2021 08:19:32 -0700 (PDT) MIME-Version: 1.0 References: <20210924155740.20510-1-olivier.matz@6wind.com> <20210929213943.17817-1-olivier.matz@6wind.com> <20210929213943.17817-5-olivier.matz@6wind.com> In-Reply-To: From: David Marchand Date: Thu, 30 Sep 2021 17:19:21 +0200 Message-ID: To: Olivier Matz Cc: dev , Bruce Richardson , Xueming Li , Gaetan Rivet , Ray Kinsella Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 4/5] kvargs: remove experimental function to compare string X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 30, 2021 at 4:00 PM Olivier Matz wrote: > > On Wed, Sep 29, 2021 at 11:39:42PM +0200, Olivier Matz wrote: > > The function was designed to be used as a handler for > > rte_kvargs_process() to compare the value string in a kvlist. For > > readability, its usages in DPDK have been replaced by > > rte_kvargs_get_with_value() in previous commit. > > > > Remove this function, as it is not used anymore. > > > > Signed-off-by: Olivier Matz > > Reviewed-by: Xueming Li > > Maybe a quick note could be added in the release note. Something like > this: > > * kvargs: The experimental function ``rte_kvargs_strcmp()`` has been > removed. Its usages have been replaced by a new function > ``rte_kvargs_get_with_value()``. > > David, do you want me to send a v3 with this note? Yes, a RN update for API changes is a good practice :-). No need to send v3, I'll add it and merge the series (soon). Thanks Olivier. -- David Marchand